fix: Major update label must be displayed only if user-defined version is greater or equal to installed version

Author: david-rodrigues

src/PackageInfo.ts

@@ -2,6 +2,7 @@ import {
   coerce,
   diff,
   gt,
+  gte,
   maxSatisfying,
   prerelease,
   ReleaseType,
@@ -98,7 +99,8 @@ export class PackageInfo {
     return Boolean(
       versionLatest &&
         versionInstalled &&
-        diff(versionLatest, versionInstalled) === "major"
+        diff(versionLatest, versionInstalled) === "major" &&
+        gte(versionLatest, versionInstalled)
     )
   }
 

src/extension.test.ts

@@ -253,6 +253,17 @@ describe("package diagnostics", () => {
     )
   })
 
+  it("valid dependency, with major already installed must not show 'major' tooltip", async () => {
+    const { decorations, diagnostics } = await vscodeSimulator({
+      packageJson: { dependencies: { "npm-outdated": "^1.0.0" } },
+      packagesInstalled: { "npm-outdated": "2.0.0" },
+      packagesRepository: { "npm-outdated": ["1.0.0", "1.0.1", "2.0.0"] },
+    })
+
+    expect(diagnostics[0]?.message).toContain("available: 1.0.1")
+    expect(decorations[0]).not.toContain("(attention: major update!)")
+  })
+
   it("dependency name is invalid", async () => {
     const { decorations, diagnostics } = await vscodeSimulator({
       packageJson: { dependencies: { "invalid!": "^1.0.0" } },