detailed exc meta

Author: mahenzon

fastapi_jsonapi/data_layers/sqla_orm.py

@@ -361,15 +361,30 @@ async def update_object(
                 has_updated = True
         try:
             await self.save()
+        except IntegrityError:
+            log.exception("Could not update object with data update %s", data_update)
+            msg = "Object update error"
+            raise BadRequest(
+                msg,
+                pointer="/data",
+                meta={
+                    "type": self.type_,
+                    "id": view_kwargs.get(self.url_id_field),
+                },
+            )
         except DBAPIError as e:
             await self.session.rollback()
 
-            err_message = f"Got an error {e.__class__.__name__} during update data in DB"
+            err_message = f"Got an error {e.__class__.__name__} during updating obj {view_kwargs} data in DB"
             log.error(err_message, exc_info=e)
 
             raise InternalServerError(
                 detail=err_message,
                 pointer="/data",
+                meta={
+                    "type": self.type_,
+                    "id": view_kwargs.get(self.url_id_field),
+                },
             )
 
         await self.after_update_object(obj=obj, model_kwargs=new_data, view_kwargs=view_kwargs)
@@ -390,12 +405,16 @@ async def delete_object(self, obj: TypeModel, view_kwargs: dict):
         except DBAPIError as e:
             await self.session.rollback()
 
-            err_message = f"Got an error {e.__class__.__name__} during update data in DB"
+            err_message = f"Got an error {e.__class__.__name__} deleting object {view_kwargs}"
             log.error(err_message, exc_info=e)
 
             raise InternalServerError(
                 detail=err_message,
                 pointer="/data",
+                meta={
+                    "type": self.type_,
+                    "id": view_kwargs.get(self.url_id_field),
+                },
             )
 
         await self.after_delete_object(obj, view_kwargs)

fastapi_jsonapi/exceptions/json_api.py

@@ -2,6 +2,7 @@
 
 from http import HTTPStatus
 from typing import (
+    Any,
     List,
     Optional,
     Union,
@@ -26,6 +27,7 @@ def __init__(
         title: Optional[str] = None,
         status_code: Optional[int] = None,
         errors: Optional[List["HTTPException"]] = None,
+        meta: Optional[dict[str, Any]] = None,
     ):
         """
         Init base HTTP exception.
@@ -36,6 +38,7 @@ def __init__(
         :param status_code: the HTTP status code applicable to this problem
         :param title: a short, human-readable summary of the problem
         :param errors: may be passed over other arguments as list of `HTTPException` objects
+        :param meta: default meta
         """
         if status_code is not None:
             self.status_code = status_code
@@ -44,7 +47,7 @@ def __init__(
             self.title = title
 
         self.source = None
-        self.meta = None
+        self.meta = meta
         self._detail = detail
 
         parameter = parameter or self.parameter

tests/test_api/test_api_sqla_with_includes.py

@@ -1304,14 +1304,18 @@ async def test_fail_to_bind_relationship_with_constraint(
         url = app.url_path_for("get_user_bio_detail", obj_id=user_1_bio.id)
         url = f"{url}?include=user"
         res = await client.patch(url, json=patch_user_bio_body)
-        assert res.status_code == status.HTTP_500_INTERNAL_SERVER_ERROR, res.text
+        assert res.status_code == status.HTTP_400_BAD_REQUEST, res.text
         assert res.json() == {
             "errors": [
                 {
-                    "detail": "Got an error IntegrityError during update data in DB",
+                    "detail": "Object update error",
                     "source": {"pointer": "/data"},
-                    "status_code": status.HTTP_500_INTERNAL_SERVER_ERROR,
-                    "title": "Internal Server Error",
+                    "status_code": status.HTTP_400_BAD_REQUEST,
+                    "title": "Bad Request",
+                    "meta": {
+                        "id": str(user_1_bio.id),
+                        "type": "user_bio",
+                    },
                 },
             ],
         }