atomic create, add tests, create obj with relationship

Author: mahenzon

fastapi_jsonapi/atomic/atomic.py

@@ -112,16 +112,10 @@ async def view_atomic(
             previous_dl = dl
             if operation.action == "add":
                 data = operation.jsonapi.schema_in_post(data=operation.data)
-                created_object = await dl.create_object(
-                    data_create=data.data,
-                    view_kwargs={},
-                )
                 assert isinstance(operation.view, ListViewBase)
                 view: "ListViewBase" = operation.view
-                response = await view.response_for_created_object(
-                    dl=operation.data_layer,
-                    created_object=created_object,
-                )
+                response = await view.process_create_object(dl=operation.data_layer, data_create=data)
+                # response.data.id
                 results.append({"data": response.data})
             elif operation.action == "update":
                 # TODO

fastapi_jsonapi/views/list_view.py

@@ -1,7 +1,6 @@
 import logging
 from typing import TYPE_CHECKING, Any, Dict
 
-from fastapi_jsonapi.data_typing import TypeModel
 from fastapi_jsonapi.schema import (
     BaseJSONAPIDataInSchema,
     JSONAPIResultDetailSchema,
@@ -49,10 +48,11 @@ async def handle_post_resource_list(
         **extra_view_deps,
     ) -> JSONAPIResultDetailSchema:
         dl: "BaseDataLayer" = await self.get_data_layer(extra_view_deps)
+        return await self.process_create_object(dl=dl, data_create=data_create)
+
+    async def process_create_object(self, dl: "BaseDataLayer", data_create: BaseJSONAPIDataInSchema):
         created_object = await dl.create_object(data_create=data_create.data, view_kwargs={})
-        return await self.response_for_created_object(dl=dl, created_object=created_object)
 
-    async def response_for_created_object(self, dl: "BaseDataLayer", created_object: TypeModel):
         created_object_id = dl.get_object_id(created_object)
 
         view_kwargs = {dl.url_id_field: created_object_id}

tests/test_atomic/test_create_objects.py

@@ -9,8 +9,8 @@
 from starlette import status
 
 from tests.misc.utils import fake
-from tests.models import User
-from tests.schemas import UserAttributesBaseSchema
+from tests.models import User, UserBio
+from tests.schemas import UserAttributesBaseSchema, UserBioBaseSchema
 
 pytestmark = mark.asyncio
 
@@ -198,3 +198,55 @@ async def test_atomic_rollback_on_create_error(
         )
         result: Result = await async_session.execute(stmt)
         assert result.scalar_one() == 0
+
+    async def test_create_bio_with_relationship_to_user_to_one(
+        self,
+        client: AsyncClient,
+        async_session: AsyncSession,
+        user_1: User,
+    ):
+        user_bio = UserBioBaseSchema(
+            birth_city=fake.city(),
+            favourite_movies=fake.sentence(),
+        )
+        stmt_bio = select(UserBio).where(UserBio.user_id == user_1.id)
+        res: Result = await async_session.execute(stmt_bio)
+        assert res.scalar_one_or_none() is None, "user has to be w/o bio"
+
+        data_atomic_request = {
+            "atomic:operations": [
+                {
+                    "op": "add",
+                    "data": {
+                        "type": "user_bio",
+                        "attributes": user_bio.dict(),
+                        "relationships": {
+                            "user": {
+                                "data": {
+                                    "id": user_1.id,
+                                    "type": "user",
+                                },
+                            },
+                        },
+                    },
+                },
+            ],
+        }
+        response = await client.post("/operations", json=data_atomic_request)
+        assert response.status_code == status.HTTP_200_OK, response.text
+        resp_data = response.json()
+        assert resp_data
+        results = resp_data["atomic:results"]
+        assert len(results) == 1, results
+        result_bio_data = results[0]
+        res: Result = await async_session.execute(stmt_bio)
+        user_bio_created: UserBio = res.scalar_one()
+        assert user_bio == UserBioBaseSchema.from_orm(user_bio_created)
+        assert result_bio_data == {
+            "data": {
+                "attributes": user_bio.dict(),
+                "type": "user_bio",
+                "id": str(user_bio_created.id),
+            },
+            "meta": None,
+        }