Skip to content

Commit d688551

Browse files
committed
rename methods for getting data layer
1 parent b7a8b03 commit d688551

File tree

3 files changed

+8
-8
lines changed

3 files changed

+8
-8
lines changed

fastapi_jsonapi/views/detail_view.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ async def handle_get_resource_detail(
2323
object_id: Union[int, str],
2424
**extra_view_deps,
2525
):
26-
dl: "BaseDataLayer" = await self._get_data_layer_for_detail(extra_view_deps)
26+
dl: "BaseDataLayer" = await self.get_data_layer_for_detail(extra_view_deps)
2727

2828
view_kwargs = {dl.url_id_field: object_id}
2929
db_object = await dl.get_object(view_kwargs=view_kwargs, qs=self.query_params)
@@ -41,7 +41,7 @@ async def handle_update_resource(
4141
detail="obj_id and data.id should be same",
4242
pointer="/data/id",
4343
)
44-
dl: "BaseDataLayer" = await self._get_data_layer_for_detail(extra_view_deps)
44+
dl: "BaseDataLayer" = await self.get_data_layer_for_detail(extra_view_deps)
4545

4646
view_kwargs = {dl.url_id_field: obj_id}
4747
db_object = await dl.get_object(view_kwargs=view_kwargs, qs=self.query_params)
@@ -55,7 +55,7 @@ async def handle_delete_resource(
5555
obj_id: str,
5656
**extra_view_deps,
5757
):
58-
dl: "BaseDataLayer" = await self._get_data_layer_for_detail(extra_view_deps)
58+
dl: "BaseDataLayer" = await self.get_data_layer_for_detail(extra_view_deps)
5959

6060
view_kwargs = {dl.url_id_field: obj_id}
6161
db_object = await dl.get_object(view_kwargs=view_kwargs, qs=self.query_params)

fastapi_jsonapi/views/list_view.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@ def _calculate_total_pages(self, db_items_count: int) -> int:
2929
return total_pages
3030

3131
async def handle_get_resource_list(self, **extra_view_deps) -> JSONAPIResultListSchema:
32-
dl: "BaseDataLayer" = await self._get_data_layer_for_list(extra_view_deps)
32+
dl: "BaseDataLayer" = await self.get_data_layer_for_list(extra_view_deps)
3333
query_params = self.query_params
3434
count, items_from_db = await dl.get_collection(qs=query_params)
3535
total_pages = self._calculate_total_pages(count)
@@ -41,7 +41,7 @@ async def handle_post_resource_list(
4141
data_create: BaseJSONAPIDataInSchema,
4242
**extra_view_deps,
4343
) -> JSONAPIResultDetailSchema:
44-
dl: "BaseDataLayer" = await self._get_data_layer_for_list(extra_view_deps)
44+
dl: "BaseDataLayer" = await self.get_data_layer_for_list(extra_view_deps)
4545
created_object = await dl.create_object(data_create=data_create.data, view_kwargs={})
4646
created_object_id = getattr(created_object, dl.get_object_id_field_name())
4747

@@ -51,7 +51,7 @@ async def handle_post_resource_list(
5151
return self._build_detail_response(db_object)
5252

5353
async def handle_delete_resource_list(self, **extra_view_deps) -> JSONAPIResultListSchema:
54-
dl: "BaseDataLayer" = await self._get_data_layer_for_list(extra_view_deps)
54+
dl: "BaseDataLayer" = await self.get_data_layer_for_list(extra_view_deps)
5555
query_params = self.query_params
5656
count, items_from_db = await dl.get_collection(qs=query_params)
5757
total_pages = self._calculate_total_pages(count)

fastapi_jsonapi/views/view_base.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -69,7 +69,7 @@ def _get_data_layer(self, schema: Type[BaseModel], **dl_kwargs):
6969
**dl_kwargs,
7070
)
7171

72-
async def _get_data_layer_for_detail(
72+
async def get_data_layer_for_detail(
7373
self,
7474
extra_view_deps: Dict[str, Any],
7575
) -> BaseDataLayer:
@@ -83,7 +83,7 @@ async def _get_data_layer_for_detail(
8383
**dl_kwargs,
8484
)
8585

86-
async def _get_data_layer_for_list(
86+
async def get_data_layer_for_list(
8787
self,
8888
extra_view_deps: Dict[str, Any],
8989
) -> BaseDataLayer:

0 commit comments

Comments
 (0)