atomic update objects

Author: mahenzon

fastapi_jsonapi/atomic/atomic.py

@@ -20,6 +20,7 @@
     OperationRelationshipSchema,
 )
 from fastapi_jsonapi.utils.dependency_helper import DependencyHelper
+from fastapi_jsonapi.views.detail_view import DetailViewBase
 from fastapi_jsonapi.views.list_view import ListViewBase
 from fastapi_jsonapi.views.utils import HTTPMethodConfig
 from fastapi_jsonapi.views.view_base import ViewBase
@@ -105,6 +106,8 @@ async def view_atomic(
 
         results = []
 
+        # TODO: try/except, catch schema ValidationError
+
         previous_dl: Optional["BaseDataLayer"] = None
         for operation in prepared_operations:
             dl = operation.data_layer
@@ -118,8 +121,16 @@ async def view_atomic(
                 # response.data.id
                 results.append({"data": response.data})
             elif operation.action == "update":
-                # TODO
                 data = operation.jsonapi.schema_in_patch(data=operation.data)
+                assert isinstance(operation.view, DetailViewBase)
+                view: "DetailViewBase" = operation.view
+                response = await view.process_update_object(
+                    dl=dl,
+                    obj_id=data.data.id,
+                    data_update=data.data,
+                )
+                # response.data.id
+                results.append({"data": response.data})
             elif operation.action == "remove":
                 pass
             else:

fastapi_jsonapi/views/detail_view.py

@@ -48,13 +48,20 @@ async def handle_update_resource(
         data_update: BaseJSONAPIItemInSchema,
         **extra_view_deps,
     ) -> JSONAPIResultDetailSchema:
+        dl: "BaseDataLayer" = await self.get_data_layer(extra_view_deps)
+        return await self.process_update_object(dl=dl, obj_id=obj_id, data_update=data_update)
+
+    async def process_update_object(
+        self,
+        dl: "BaseDataLayer",
+        obj_id: str,
+        data_update: BaseJSONAPIItemInSchema,
+    ):
         if obj_id != data_update.id:
             raise BadRequest(
                 detail="obj_id and data.id should be same",
                 pointer="/data/id",
             )
-        dl: "BaseDataLayer" = await self.get_data_layer(extra_view_deps)
-
         view_kwargs = {dl.url_id_field: obj_id}
         db_object = await dl.get_object(view_kwargs=view_kwargs, qs=self.query_params)
 

tests/test_atomic/test_update_objects.py

@@ -0,0 +1,79 @@
+import logging
+
+from httpx import AsyncClient
+from pytest import mark  # noqa
+from sqlalchemy.ext.asyncio import AsyncSession
+from starlette import status
+
+from tests.misc.utils import fake
+from tests.models import User, UserBio
+from tests.schemas import UserAttributesBaseSchema, UserBioBaseSchema
+
+pytestmark = mark.asyncio
+
+logging.basicConfig(level=logging.DEBUG)
+
+
+class TestAtomicUpdateObjects:
+    async def test_update_two_objects(
+        self,
+        client: AsyncClient,
+        async_session: AsyncSession,
+        user_1: User,
+        user_1_bio: UserBio,
+    ):
+        user_data = UserAttributesBaseSchema.from_orm(user_1)
+        user_bio_data = UserBioBaseSchema.from_orm(user_1_bio)
+        user_data.name = fake.name()
+        user_bio_data.favourite_movies = fake.sentence()
+        assert user_1.name != user_data.name
+        assert user_1_bio.favourite_movies != user_bio_data.favourite_movies
+        data_atomic_request = {
+            "atomic:operations": [
+                {
+                    "op": "update",
+                    "data": {
+                        "id": str(user_1.id),
+                        "type": "user",
+                        "attributes": user_data.dict(),
+                    },
+                },
+                {
+                    "op": "update",
+                    "data": {
+                        "id": str(user_1_bio.id),
+                        "type": "user_bio",
+                        "attributes": user_bio_data.dict(),
+                    },
+                },
+            ],
+        }
+        response = await client.post("/operations", json=data_atomic_request)
+        assert response.status_code == status.HTTP_200_OK, response.text
+        response_data = response.json()
+        assert "atomic:results" in response_data, response_data
+        results = response_data["atomic:results"]
+        assert results
+        await async_session.refresh(user_1)
+        await async_session.refresh(user_1_bio)
+        assert user_1.name == user_data.name
+        assert user_1_bio.favourite_movies == user_bio_data.favourite_movies
+
+        assert results == [
+            {
+                "data": {
+                    "attributes": user_data.dict(),
+                    "id": str(user_1.id),
+                    "type": "user",
+                },
+                "meta": None,
+            },
+            {
+                "data": {
+                    "attributes": user_bio_data.dict(),
+                    "id": str(user_1_bio.id),
+                    "type": "user_bio",
+                },
+                "meta": None,
+            },
+        ]