Use inheritance to get rid of code duplication

Author: mahenzon

fastapi_rest_jsonapi/api.py

@@ -27,7 +27,7 @@
 JSON_API_RESPONSE_TYPE = Optional[Dict[Union[int, str], Dict[str, Any]]]
 
 
-class RoutersJSONAPI(object):
+class RoutersJSONAPI:
     """API Router interface for JSON API endpoints in web-services."""
 
     def __init__(  # noqa: WPS211
@@ -88,6 +88,7 @@ def __init__(  # noqa: WPS211
         )
         self._resp_schema_list: Type[BaseModel] = list_jsonapi_schema
 
+        # todo: check for any collection except string
         if isinstance(self._path, list):
             for i_path in self._path:
                 self._add_routers(i_path)

fastapi_rest_jsonapi/schema.py

@@ -17,20 +17,22 @@
 )
 
 
-class BasePatchJSONAPISchema(BaseModel):
-    """Base PATCH JSON API schema."""
-    id: int = Field(description="ID объекта")
-    type: str = Field(description="Тип ресурса")
-    attributes: dict = Field(description="Данные объекта")
-
-
 class BasePostJSONAPISchema(BaseModel):
     """Base POST JSON API schema."""
 
     type: str = Field(description="Тип ресурса")
     attributes: dict = Field(description="Данные объекта")
 
 
+class BaseJSONAPIObjectSchema(BasePostJSONAPISchema):
+    """Base JSON:API object schema."""
+    id: int = Field(description="ID объекта")
+
+
+class BasePatchJSONAPISchema(BaseJSONAPIObjectSchema):
+    """Base PATCH JSON API schema."""
+
+
 class JSONAPIResultListMetaSchema(BaseModel):
     """JSON API list meta schema."""
 
@@ -44,28 +46,29 @@ class JSONAPIResultListJSONAPISchema(BaseModel):
     version: str = Field(default="1.0", description="json-api версия")
 
 
-class JSONAPIObjectSchema(BaseModel):
+class JSONAPIObjectSchema(BaseJSONAPIObjectSchema):
     """JSON API base object schema."""
 
-    id: int = Field(description="ID объекта")
-    type: str = Field(description="Тип ресурса")
-    attributes: dict = Field(description="Данные объекта")
+
+class BaseJSONAPIResultSchema(BaseModel):
+    """
+    JSON:API Required fields schema
+    """
+
+    meta: Optional[JSONAPIResultListMetaSchema] = Field(description="Meta данные json-api")
+    jsonapi: JSONAPIResultListJSONAPISchema = JSONAPIResultListJSONAPISchema()
 
 
-class JSONAPIResultListSchema(BaseModel):
+class JSONAPIResultListSchema(BaseJSONAPIResultSchema):
     """JSON API list base result schema."""
 
     data: Sequence[JSONAPIObjectSchema] = Field(description="Список объектов")
-    meta: Optional[JSONAPIResultListMetaSchema]
-    jsonapi: JSONAPIResultListJSONAPISchema = JSONAPIResultListJSONAPISchema()
 
 
-class JSONAPIResultDetailSchema(BaseModel):
+class JSONAPIResultDetailSchema(BaseJSONAPIResultSchema):
     """JSON API base detail schema."""
 
     data: JSONAPIObjectSchema = Field(description="Данные объекта")
-    meta: Optional[JSONAPIResultListMetaSchema] = Field(description="Meta данные json-api")
-    jsonapi: JSONAPIResultListJSONAPISchema = JSONAPIResultListJSONAPISchema()
 
 
 class BasicPipelineActionSchema(BaseModel):