push more code into the base SimilarityExporter class

Author: mneedham

algo/src/main/java/org/neo4j/graphalgo/similarity/ParallelSimilarityExporter.java

@@ -154,60 +154,7 @@ private DisjointSetStruct computePartitions(HeavyGraph graph) {
         return struct;
     }
 
-    private void export(SimilarityResult similarityResult) {
-        applyInTransaction(statement -> {
-            try {
-                createRelationship(similarityResult, statement);
-            } catch (KernelException e) {
-                ExceptionUtil.throwKernelException(e);
-            }
-            return null;
-        });
-
-    }
 
-    private void export(List<SimilarityResult> similarityResults) {
-        applyInTransaction(statement -> {
-            for (SimilarityResult similarityResult : similarityResults) {
-                try {
-                    createRelationship(similarityResult, statement);
-                } catch (KernelException e) {
-                    ExceptionUtil.throwKernelException(e);
-                }
-            }
-            return null;
-        });
-
-    }
-
-    private int writeSequential(Stream<SimilarityResult> similarityPairs, long batchSize) {
-        int[] counter = {0};
-        if (batchSize == 1) {
-            similarityPairs.forEach(similarityResult -> {
-                export(similarityResult);
-                counter[0]++;
-            });
-        } else {
-            Iterator<SimilarityResult> iterator = similarityPairs.iterator();
-            do {
-                List<SimilarityResult> batch = take(iterator, Math.toIntExact(batchSize));
-                export(batch);
-                if (batch.size() > 0) {
-                    counter[0]++;
-                }
-            } while (iterator.hasNext());
-        }
-
-        return counter[0];
-    }
-
-    private static List<SimilarityResult> take(Iterator<SimilarityResult> iterator, int batchSize) {
-        List<SimilarityResult> result = new ArrayList<>(batchSize);
-        while (iterator.hasNext() && batchSize-- > 0) {
-            result.add(iterator.next());
-        }
-        return result;
-    }
 
 
 }

algo/src/main/java/org/neo4j/graphalgo/similarity/SequentialSimilarityExporter.java

@@ -49,62 +49,5 @@ public int export(Stream<SimilarityResult> similarityPairs, long batchSize) {
         return batches;
     }
 
-    private void export(SimilarityResult similarityResult) {
-        applyInTransaction(statement -> {
-            try {
-                createRelationship(similarityResult, statement);
-            } catch (KernelException e) {
-                ExceptionUtil.throwKernelException(e);
-            }
-            return null;
-        });
-
-    }
-
-    private void export(List<SimilarityResult> similarityResults) {
-        applyInTransaction(statement -> {
-            for (SimilarityResult similarityResult : similarityResults) {
-                try {
-                    createRelationship(similarityResult, statement);
-                } catch (KernelException e) {
-                    ExceptionUtil.throwKernelException(e);
-                }
-            }
-            return null;
-        });
-
-    }
-
-    private int writeSequential(Stream<SimilarityResult> similarityPairs, long batchSize) {
-        log.info("SequentialSimilarityExporter: Writing relationships...");
-        int[] counter = {0};
-        if (batchSize == 1) {
-            similarityPairs.forEach(similarityResult -> {
-                export(similarityResult);
-                counter[0]++;
-            });
-        } else {
-            Iterator<SimilarityResult> iterator = similarityPairs.iterator();
-            do {
-                List<SimilarityResult> batch = take(iterator, Math.toIntExact(batchSize));
-                export(batch);
-                if(batch.size() > 0) {
-                    counter[0]++;
-                }
-            } while (iterator.hasNext());
-        }
-
-        return counter[0];
-    }
-
-
-    private static List<SimilarityResult> take(Iterator<SimilarityResult> iterator, int batchSize) {
-        List<SimilarityResult> result = new ArrayList<>(batchSize);
-        while (iterator.hasNext() && batchSize-- > 0) {
-            result.add(iterator.next());
-        }
-        return result;
-    }
-
 
 }

algo/src/main/java/org/neo4j/graphalgo/similarity/SimilarityExporter.java

@@ -1,14 +1,19 @@
 package org.neo4j.graphalgo.similarity;
 
+import org.neo4j.graphalgo.core.utils.ExceptionUtil;
 import org.neo4j.graphalgo.core.utils.StatementApi;
 import org.neo4j.internal.kernel.api.exceptions.EntityNotFoundException;
 import org.neo4j.internal.kernel.api.exceptions.InvalidTransactionTypeKernelException;
+import org.neo4j.internal.kernel.api.exceptions.KernelException;
 import org.neo4j.internal.kernel.api.exceptions.explicitindex.AutoIndexingKernelException;
 import org.neo4j.kernel.api.KernelTransaction;
 import org.neo4j.kernel.internal.GraphDatabaseAPI;
 import org.neo4j.logging.Log;
 import org.neo4j.values.storable.Values;
 
+import java.util.ArrayList;
+import java.util.Iterator;
+import java.util.List;
 import java.util.stream.Stream;
 
 public abstract class SimilarityExporter extends StatementApi {
@@ -44,5 +49,60 @@ protected void createRelationship(SimilarityResult similarityResult, KernelTrans
                 relationshipId, propertyId, Values.doubleValue(similarityResult.similarity));
     }
 
+    private void export(SimilarityResult similarityResult) {
+        applyInTransaction(statement -> {
+            try {
+                createRelationship(similarityResult, statement);
+            } catch (KernelException e) {
+                ExceptionUtil.throwKernelException(e);
+            }
+            return null;
+        });
+
+    }
+
+    private void export(List<SimilarityResult> similarityResults) {
+        applyInTransaction(statement -> {
+            for (SimilarityResult similarityResult : similarityResults) {
+                try {
+                    createRelationship(similarityResult, statement);
+                } catch (KernelException e) {
+                    ExceptionUtil.throwKernelException(e);
+                }
+            }
+            return null;
+        });
+
+    }
+
+    int writeSequential(Stream<SimilarityResult> similarityPairs, long batchSize) {
+        int[] counter = {0};
+        if (batchSize == 1) {
+            similarityPairs.forEach(similarityResult -> {
+                export(similarityResult);
+                counter[0]++;
+            });
+        } else {
+            Iterator<SimilarityResult> iterator = similarityPairs.iterator();
+            do {
+                List<SimilarityResult> batch = take(iterator, Math.toIntExact(batchSize));
+                export(batch);
+                if (batch.size() > 0) {
+                    counter[0]++;
+                }
+            } while (iterator.hasNext());
+        }
+
+        return counter[0];
+    }
+
+    private static List<SimilarityResult> take(Iterator<SimilarityResult> iterator, int batchSize) {
+        List<SimilarityResult> result = new ArrayList<>(batchSize);
+        while (iterator.hasNext() && batchSize-- > 0) {
+            result.add(iterator.next());
+        }
+        return result;
+    }
+
     abstract int export(Stream<SimilarityResult> similarityPairs, long batchSize);
 }