feat(session): delete deprecated session methods (#1649)

BREAKING CHANGE: this update removes deprecated session methods on the `Driver` level. In addition, this also removes the experimental `defaultTypeSystem()` method.

Author: injectives

driver/clirr-ignored-differences.xml

@@ -770,4 +770,34 @@
         <differenceType>8001</differenceType>
     </difference>
 
+    <difference>
+        <className>org/neo4j/driver/Driver</className>
+        <differenceType>7002</differenceType>
+        <method>org.neo4j.driver.async.AsyncSession asyncSession()</method>
+    </difference>
+
+    <difference>
+        <className>org/neo4j/driver/Driver</className>
+        <differenceType>7002</differenceType>
+        <method>org.neo4j.driver.async.AsyncSession asyncSession(org.neo4j.driver.SessionConfig)</method>
+    </difference>
+
+    <difference>
+        <className>org/neo4j/driver/Driver</className>
+        <differenceType>7002</differenceType>
+        <method>org.neo4j.driver.types.TypeSystem defaultTypeSystem()</method>
+    </difference>
+
+    <difference>
+        <className>org/neo4j/driver/Driver</className>
+        <differenceType>7002</differenceType>
+        <method>org.neo4j.driver.reactive.ReactiveSession reactiveSession()</method>
+    </difference>
+
+    <difference>
+        <className>org/neo4j/driver/Driver</className>
+        <differenceType>7002</differenceType>
+        <method>org.neo4j.driver.reactive.ReactiveSession reactiveSession(org.neo4j.driver.SessionConfig)</method>
+    </difference>
+
 </differences>

driver/src/main/java/org/neo4j/driver/Driver.java

@@ -17,12 +17,8 @@
 package org.neo4j.driver;
 
 import java.util.concurrent.CompletionStage;
-import org.neo4j.driver.async.AsyncSession;
 import org.neo4j.driver.exceptions.ClientException;
 import org.neo4j.driver.exceptions.UnsupportedFeatureException;
-import org.neo4j.driver.reactive.ReactiveSession;
-import org.neo4j.driver.types.TypeSystem;
-import org.neo4j.driver.util.Experimental;
 
 /**
  * Accessor for a specific Neo4j graph database.
@@ -132,7 +128,6 @@ default Session session(SessionConfig sessionConfig) {
      * @throws IllegalArgumentException for unsupported session types
      * @since 5.2
      */
-    @SuppressWarnings("deprecation")
     default <T extends BaseSession> T session(Class<T> sessionClass) {
         return session(sessionClass, SessionConfig.defaultConfig());
     }
@@ -167,7 +162,6 @@ default <T extends BaseSession> T session(Class<T> sessionClass) {
      * @throws IllegalArgumentException for unsupported session types
      * @since 5.8
      */
-    @SuppressWarnings("deprecation")
     default <T extends BaseSession> T session(Class<T> sessionClass, AuthToken sessionAuthToken) {
         return session(sessionClass, SessionConfig.defaultConfig(), sessionAuthToken);
     }
@@ -198,7 +192,6 @@ default <T extends BaseSession> T session(Class<T> sessionClass, AuthToken sessi
      * @throws IllegalArgumentException for unsupported session types
      * @since 5.2
      */
-    @SuppressWarnings("deprecation")
     default <T extends BaseSession> T session(Class<T> sessionClass, SessionConfig sessionConfig) {
         return session(sessionClass, sessionConfig, null);
     }
@@ -235,63 +228,8 @@ default <T extends BaseSession> T session(Class<T> sessionClass, SessionConfig s
      * @throws IllegalArgumentException for unsupported session types
      * @since 5.8
      */
-    @SuppressWarnings("deprecation")
     <T extends BaseSession> T session(Class<T> sessionClass, SessionConfig sessionConfig, AuthToken sessionAuthToken);
 
-    /**
-     * Create a new general purpose {@link ReactiveSession} with default {@link SessionConfig session configuration}. The {@link ReactiveSession} provides a
-     * reactive way to run queries and process results.
-     *
-     * @return a new {@link ReactiveSession} object.
-     * @deprecated superseded by {@link #session(Class)}
-     */
-    @Deprecated
-    default ReactiveSession reactiveSession() {
-        return session(ReactiveSession.class);
-    }
-
-    /**
-     * Create a new {@link ReactiveSession} with a specified {@link SessionConfig session configuration}. Use {@link SessionConfig#forDatabase(String)} to
-     * obtain a general purpose session configuration for the specified database. The {@link ReactiveSession} provides a reactive way to run queries and process
-     * results.
-     *
-     * @param sessionConfig used to customize the session.
-     * @return a new {@link ReactiveSession} object.
-     * @deprecated superseded by {@link #session(Class, SessionConfig)}
-     */
-    @Deprecated
-    default ReactiveSession reactiveSession(SessionConfig sessionConfig) {
-        return session(ReactiveSession.class, sessionConfig);
-    }
-
-    /**
-     * Create a new general purpose {@link AsyncSession} with default {@link SessionConfig session configuration}. The {@link AsyncSession} provides an
-     * asynchronous way to run queries and process results.
-     * <p>
-     * Alias to {@link #asyncSession(SessionConfig)}}.
-     *
-     * @return a new {@link AsyncSession} object.
-     * @deprecated superseded by {@link #session(Class)}
-     */
-    @Deprecated
-    default AsyncSession asyncSession() {
-        return session(AsyncSession.class);
-    }
-
-    /**
-     * Create a new {@link AsyncSession} with a specified {@link SessionConfig session configuration}.
-     * Use {@link SessionConfig#forDatabase(String)} to obtain a general purpose session configuration for the specified database.
-     * The {@link AsyncSession} provides an asynchronous way to run queries and process results.
-     *
-     * @param sessionConfig used to customize the session.
-     * @return a new {@link AsyncSession} object.
-     * @deprecated superseded by {@link #session(Class, SessionConfig)}
-     */
-    @Deprecated
-    default AsyncSession asyncSession(SessionConfig sessionConfig) {
-        return session(AsyncSession.class, sessionConfig);
-    }
-
     /**
      * Close all the resources assigned to this driver, including open connections and IO threads.
      * <p>
@@ -334,18 +272,6 @@ default AsyncSession asyncSession(SessionConfig sessionConfig) {
      */
     boolean isMetricsEnabled();
 
-    /**
-     * This will return the type system supported by the driver.
-     * The types supported on a particular server a session is connected against might not contain all of the types defined here.
-     *
-     * @return type system used by this query runner for classifying values
-     * @deprecated superseded by {@link TypeSystem#getDefault()}
-     */
-    @Experimental
-    @Deprecated
-    @SuppressWarnings("SameReturnValue")
-    TypeSystem defaultTypeSystem();
-
     /**
      * This verifies if the driver can connect to a remote server or a cluster
      * by establishing a network connection with the remote and possibly exchanging a few data before closing the connection.

driver/src/main/java/org/neo4j/driver/internal/InternalDriver.java

@@ -47,9 +47,7 @@
 import org.neo4j.driver.internal.metrics.DevNullMetricsProvider;
 import org.neo4j.driver.internal.metrics.MetricsProvider;
 import org.neo4j.driver.internal.security.BoltSecurityPlanManager;
-import org.neo4j.driver.internal.types.InternalTypeSystem;
 import org.neo4j.driver.internal.util.Futures;
-import org.neo4j.driver.types.TypeSystem;
 
 public class InternalDriver implements Driver {
     private static final Set<String> INVALID_TOKEN_CODES = Set.of(
@@ -151,12 +149,6 @@ public CompletionStage<Void> closeAsync() {
         return completedWithNull();
     }
 
-    @Deprecated
-    @Override
-    public final TypeSystem defaultTypeSystem() {
-        return InternalTypeSystem.TYPE_SYSTEM;
-    }
-
     @Override
     public CompletionStage<Void> verifyConnectivityAsync() {
         return sessionFactory.verifyConnectivity();