feat(notification): delete deprecated Notification#severity() (#1651)

BREAKING CHANGE: the deprecated `org.neo4j.driver.summary.Notification#severity()` has been deleted, please use either `org.neo4j.driver.summary.Notification#severityLevel()` or `org.neo4j.driver.summary.Notification#rawSeverityLevel()`.

Author: injectives

driver/clirr-ignored-differences.xml

@@ -806,4 +806,10 @@
         <method>java.io.File certFile()</method>
     </difference>
 
+    <difference>
+        <className>org/neo4j/driver/summary/Notification</className>
+        <differenceType>7002</differenceType>
+        <method>java.lang.String severity()</method>
+    </difference>
+
 </differences>

driver/src/main/java/org/neo4j/driver/summary/Notification.java

@@ -72,17 +72,6 @@ default Optional<InputPosition> inputPosition() {
         return Optional.ofNullable(position());
     }
 
-    /**
-     * The severity level of the notification.
-     *
-     * @deprecated superseded by {@link #severityLevel()} and {@link #rawSeverityLevel()}
-     * @return the severity level of the notification
-     */
-    @Deprecated
-    default String severity() {
-        return rawSeverityLevel().orElse("N/A");
-    }
-
     /**
      * Returns the severity level of the notification derived from the diagnostic record.
      *

driver/src/test/java/org/neo4j/driver/integration/SummaryIT.java

@@ -229,7 +229,6 @@ void shouldContainProfile() {
     }
 
     @Test
-    @SuppressWarnings("deprecation")
     void shouldContainNotifications() {
         // When
         var summary =
@@ -243,7 +242,6 @@ void shouldContainNotifications() {
         assertThat(notification.code(), notNullValue());
         assertThat(notification.title(), notNullValue());
         assertThat(notification.description(), notNullValue());
-        assertThat(notification.severity(), notNullValue());
         assertThat(notification.severityLevel(), notNullValue());
         assertThat(notification.rawSeverityLevel(), notNullValue());
         assertThat(notification.position(), notNullValue());

driver/src/test/java/org/neo4j/driver/internal/util/MetadataExtractorTest.java

@@ -250,7 +250,6 @@ void shouldBuildResultSummaryWithNotifications() {
         assertEquals("Almost bad thing", firstNotification.description());
         assertEquals("Neo.DummyNotification", firstNotification.code());
         assertEquals("A title", firstNotification.title());
-        assertEquals("WARNING", firstNotification.severity());
         assertEquals(
                 NotificationSeverity.WARNING, firstNotification.severityLevel().get());
         assertEquals("WARNING", firstNotification.rawSeverityLevel().get());
@@ -280,7 +279,8 @@ void shouldBuildResultSummaryWithNotifications() {
         assertEquals("Almost good thing", secondNotification.description());
         assertEquals("Neo.GoodNotification", secondNotification.code());
         assertEquals("Good", secondNotification.title());
-        assertEquals("INFO", secondNotification.severity());
+        assertFalse(secondNotification.severityLevel().isPresent());
+        assertEquals("INFO", secondNotification.rawSeverityLevel().get());
         assertTrue(secondNotification.inputPosition().isEmpty());
         assertNull(secondNotification.position());
         assertEquals(
@@ -348,7 +348,6 @@ void shouldBuildResultSummaryWithGqlStatusObjects() {
         assertEquals("notification_description", firstGqlStatusObject.description());
         assertEquals("neo4j_code", firstGqlStatusObject.code());
         assertEquals("title", firstGqlStatusObject.title());
-        assertEquals("WARNING", firstGqlStatusObject.severity());
         assertEquals(
                 NotificationSeverity.WARNING,
                 firstGqlStatusObject.severityLevel().get());

testkit-backend/src/main/java/neo4j/org/testkit/backend/messages/requests/SummaryUtil.java

@@ -66,7 +66,6 @@ public static Summary.SummaryBody toSummaryBody(org.neo4j.driver.summary.ResultS
                         .title(s.title())
                         .description(s.description())
                         .position(toInputPosition(s.position()))
-                        .severity(s.severity())
                         .severityLevel(s.severityLevel()
                                 .map(InternalNotificationSeverity.class::cast)
                                 .map(InternalNotificationSeverity::type)

testkit-backend/src/main/java/neo4j/org/testkit/backend/messages/responses/Summary.java

@@ -121,8 +121,6 @@ public static class Notification {
 
         private InputPosition position;
 
-        private String severity;
-
         private String severityLevel;
 
         private String rawSeverityLevel;