Disallow temporal types in query params in HTTP driver

There currently exists no way for the REST endpoint to accept spatial
and temporal types as query parameters. This commit makes driver fail
fast so that given spatial or temporal objects are not misinterpreted
as maps.

Author: lutovich

src/v1/internal/http/http-response-converter.js

@@ -21,6 +21,7 @@ import {isInt} from '../../integer';
 import {Node, Path, PathSegment, Relationship} from '../../graph-types';
 import {Neo4jError, PROTOCOL_ERROR} from '../../error';
 import {isPoint, Point} from '../../spatial-types';
+import {isDate, isDateTime, isDuration, isLocalDateTime, isLocalTime, isTime} from '../../temporal-types';
 
 const CREDENTIALS_EXPIRED_CODE = 'Neo.ClientError.Security.CredentialsExpired';
 
@@ -145,6 +146,18 @@ function encodeQueryParameter(value) {
     throw new Neo4jError('It is not allowed to pass paths in query parameters', PROTOCOL_ERROR);
   } else if (isPoint(value)) {
     throw newUnsupportedParameterError('points');
+  } else if (isDate(value)) {
+    throw newUnsupportedParameterError('dates');
+  } else if (isDateTime(value)) {
+    throw newUnsupportedParameterError('date-time');
+  } else if (isDuration(value)) {
+    throw newUnsupportedParameterError('durations');
+  } else if (isLocalDateTime(value)) {
+    throw newUnsupportedParameterError('local date-time');
+  } else if (isLocalTime(value)) {
+    throw newUnsupportedParameterError('local time');
+  } else if (isTime(value)) {
+    throw newUnsupportedParameterError('time');
   } else if (isInt(value)) {
     return value.toNumber();
   } else if (Array.isArray(value)) {

test/internal/http/http-driver.test.js

@@ -287,12 +287,40 @@ describe('http driver', () => {
     testUnsupportedQueryParameterWithHttpDriver(new neo4j.types.Path(node1, node2, []), done);
   });
 
+  it('should fail to pass point as a query parameter', done => {
+    testUnsupportedQueryParameterWithHttpDriver(new neo4j.types.Point(neo4j.int(42), 1, 2, 3), done);
+  });
+
+  it('should fail to pass date as a query parameter', done => {
+    testUnsupportedQueryParameterWithHttpDriver(new neo4j.types.Date(2000, 10, 12), done);
+  });
+
+  it('should fail to pass date-time as a query parameter', done => {
+    testUnsupportedQueryParameterWithHttpDriver(new neo4j.types.DateTime(2000, 10, 12, 12, 12, 0, 0, 0, null), done);
+  });
+
+  it('should fail to pass duration as a query parameter', done => {
+    testUnsupportedQueryParameterWithHttpDriver(new neo4j.types.Duration(1, 1, 1, 1), done);
+  });
+
+  it('should fail to pass local date-time as a query parameter', done => {
+    testUnsupportedQueryParameterWithHttpDriver(new neo4j.types.LocalDateTime(2000, 10, 12, 10, 10, 10), done);
+  });
+
+  it('should fail to pass local time as a query parameter', done => {
+    testUnsupportedQueryParameterWithHttpDriver(new neo4j.types.LocalTime(12, 12, 12, 0), done);
+  });
+
+  it('should fail to pass time as a query parameter', done => {
+    testUnsupportedQueryParameterWithHttpDriver(new neo4j.types.Time(12, 12, 12, 0, 0), done);
+  });
+
   it('should receive points', done => {
     testReceivingOfResults([
       'RETURN point({x: 42.341, y: 125.0})',
       'RETURN point({x: 13.2, y: 22.2, z: 33.3})',
       'RETURN point({x: 92.3, y: 71.2, z: 2.12345, crs: "wgs-84-3d"})',
-      'RETURN point({longitude: 56.7, latitude: 12.78})',
+      'RETURN point({longitude: 56.7, latitude: 12.78})'
     ], done);
   });