Bugfix and bump to v0.8.1 (#87)

* fixing #86

* Remove unused 'name' attributes from failure policies.

* Update failure policy references in YAML scenarios

* Few bug fixes. Update version to 0.8.1

* improve failure policy assertions in integration tests

Author: networmix

docs/reference/api-full.md

@@ -10,7 +10,7 @@ For a curated, example-driven API guide, see **[api.md](api.md)**.
 > - **[CLI Reference](cli.md)** - Command-line interface
 > - **[DSL Reference](dsl.md)** - YAML syntax guide
 
-**Generated from source code on:** August 06, 2025 at 16:18 UTC
+**Generated from source code on:** August 06, 2025 at 21:33 UTC
 
 **Modules auto-discovered:** 53
 
@@ -432,7 +432,6 @@ Example YAML configuration:
     ```yaml
     failure_policy:
       attrs:
-        name: "Texas Grid Outage Scenario"
         description: "Regional power grid failure affecting telecom infrastructure"
       fail_risk_groups: true
       rules:

docs/reference/dsl.md

@@ -411,7 +411,6 @@ Defines named failure policies for simulating network failures to test resilienc
 ```yaml
 failure_policy_set:
   policy_name_1:
-    name: "PolicyName" # Optional
     fail_risk_groups: true | false
     fail_risk_group_children: true | false
     use_cache: true | false

ngraph/cli.py

@@ -120,7 +120,9 @@ def _inspect_scenario(path: Path, detail: bool = False) -> None:
             original_level = logger.level
             logger.setLevel(logging.WARNING)
             try:
-                explorer = NetworkExplorer.explore_network(network)
+                explorer = NetworkExplorer.explore_network(
+                    network, scenario.components_library
+                )
                 print("\n   Network Hierarchy:")
                 explorer.print_tree(
                     max_depth=3 if not detail else None,

ngraph/failure_policy.py

@@ -97,7 +97,6 @@ class FailurePolicy:
         ```yaml
         failure_policy:
           attrs:
-            name: "Texas Grid Outage Scenario"
             description: "Regional power grid failure affecting telecom infrastructure"
           fail_risk_groups: true
           rules:

ngraph/scenario.py

@@ -253,7 +253,6 @@ def _build_failure_policy(
         Example:
             failure_policy_set:
               default:
-                name: "test"  # (Currently unused if present)
                 fail_risk_groups: true
                 fail_risk_group_children: false
                 use_cache: true

pyproject.toml

@@ -5,7 +5,7 @@ build-backend = "setuptools.build_meta"
 # ---------------------------------------------------------------------
 [project]
 name = "ngraph"
-version = "0.8.0"
+version = "0.8.1"
 description = "A tool and a library for network modeling and capacity analysis."
 readme = "README.md"
 authors = [{ name = "Andrey Golovanov" }]

scenarios/nsfnet.yaml

@@ -156,7 +156,6 @@ risk_groups:
 failure_policy_set:
   availability_1992:
     attrs:
-      name: "historical_availability_1992"
       description: >
         Approximates 1992 backbone reliability: each physical DS-3 has
         ~99.9 % monthly availability (p=0.001 failure), and each CNSS or
@@ -174,9 +173,8 @@ failure_policy_set:
         rule_type: random
         probability: 0.0005     # 0.05 % chance a given node is down
 
-  default:
+  single_random_link_failure:
     attrs:
-      name: single_random_link_failure
       description: Fails exactly one random link to test network resilience
     rules:
       - entity_scope: link
@@ -199,7 +197,7 @@ workflow:
     flow_placement: PROPORTIONAL
     iterations: 1000
     baseline: true
-    failure_policy: default
+    failure_policy: single_random_link_failure
     store_failure_patterns: true
   - step_type: CapacityEnvelopeAnalysis
     name: ce_2
@@ -209,7 +207,7 @@ workflow:
     parallelism: 8
     shortest_path: false
     flow_placement: PROPORTIONAL
-    iterations: 1000000
+    iterations: 10000
     baseline: true
     failure_policy: availability_1992
     store_failure_patterns: true

scenarios/simple.yaml

@@ -111,17 +111,15 @@ risk_groups:
   - name: srlg_12
 
 failure_policy_set:
-  default:
+  single_random_link_failure:
     attrs:
-      name: "single_random_link_failure"
       description: "Fails exactly one random link to test network resilience"
     rules:
       - entity_scope: "link"
         rule_type: "choice"
         count: 1
   single_shared_risk_group_failure:
     attrs:
-      name: "single_shared_risk_group_failure"
       description: "Fails exactly one random shared risk group to test network resilience"
     rules:
       - entity_scope: "risk_group"
@@ -144,7 +142,7 @@ workflow:
   seed: 42
   iterations: 1000
   baseline: true           # Enable baseline mode
-  failure_policy: "default"
+  failure_policy: "single_random_link_failure"
 - step_type: CapacityEnvelopeAnalysis
   name: "ce_2"
   source_path: "^(spoke_.+)"

tests/integration/expectations.py

@@ -121,9 +121,9 @@ def _calculate_scenario_3_total_nodes() -> int:
 
 # Failure policy expectations by scenario
 FAILURE_POLICY_EXPECTATIONS = {
-    "scenario_1": {"name": "anySingleLink", "rules": 1, "scopes": ["link"]},
-    "scenario_2": {"name": "anySingleLink", "rules": 1, "scopes": ["link"]},
-    "scenario_3": {"name": None, "rules": 0, "scopes": []},  # No failure policy
+    "scenario_1": {"rules": 1, "scopes": ["link"]},
+    "scenario_2": {"rules": 1, "scopes": ["link"]},
+    "scenario_3": {"rules": 0, "scopes": []},  # No failure policy
 }
 
 # Scenario 4: Advanced DSL features with complex data center fabric

tests/integration/helpers.py

@@ -251,15 +251,13 @@ def validate_traffic_demands(self, expected_count: int) -> None:
 
     def validate_failure_policy(
         self,
-        expected_name: Optional[str],
         expected_rules: int,
         expected_scopes: Optional[List[str]] = None,
     ) -> None:
         """
         Validate failure policy configuration.
 
         Args:
-            expected_name: Expected failure policy name (None if no policy expected)
             expected_rules: Expected number of failure rules
             expected_scopes: Optional list of expected rule scopes (node/link)
 
@@ -268,26 +266,19 @@ def validate_failure_policy(
         """
         policy = self.scenario.failure_policy_set.get_default_policy()
 
-        if expected_name is None:
-            assert policy is None, (
-                f"Expected no default failure policy, but found: {policy.attrs.get('name') if policy else None}"
+        if policy is None:
+            # No policy exists - only valid if expecting zero rules
+            assert expected_rules == 0, (
+                f"Expected a failure policy with {expected_rules} rules, but no default policy found"
             )
             return
 
-        assert policy is not None, "Expected a default failure policy but none found"
-
-        # Validate rule count
+        # Policy exists - validate rule count
         actual_rules = len(policy.rules)
         assert actual_rules == expected_rules, (
             f"Failure policy rule count mismatch: expected {expected_rules}, found {actual_rules}"
         )
 
-        # Validate policy name
-        actual_name = policy.attrs.get("name")
-        assert actual_name == expected_name, (
-            f"Failure policy name mismatch: expected '{expected_name}', found '{actual_name}'"
-        )
-
         # Validate rule scopes if specified
         if expected_scopes:
             actual_scopes = [rule.entity_scope for rule in policy.rules]
@@ -763,7 +754,7 @@ def basic_failure_scenario() -> Scenario:
         .with_failure_policy(
             "single_link_failure",
             {
-                "attrs": {"name": "single_link", "description": "Single link failure"},
+                "attrs": {"description": "Single link failure"},
                 "rules": [{"entity_scope": "link", "rule_type": "choice", "count": 1}],
             },
         )