From a40c85d77b6ce8a6c3c0cf901ce67600009f911e Mon Sep 17 00:00:00 2001 From: Andy Scherzinger Date: Wed, 2 Jul 2025 20:55:51 +0200 Subject: [PATCH] style(favorite): Use star outline variant for non-favorite state representation Signed-off-by: Andy Scherzinger --- .../owncloud/notes/edit/BaseNoteFragment.java | 2 +- .../owncloud/notes/main/items/NoteViewHolder.java | 2 +- .../notes/persistence/NotesRepository.java | 2 +- .../res/drawable/ic_star_border_grey_ccc_24dp.xml | 15 +++++++++++++++ 4 files changed, 18 insertions(+), 3 deletions(-) create mode 100644 app/src/main/res/drawable/ic_star_border_grey_ccc_24dp.xml diff --git a/app/src/main/java/it/niedermann/owncloud/notes/edit/BaseNoteFragment.java b/app/src/main/java/it/niedermann/owncloud/notes/edit/BaseNoteFragment.java index 54f23cf50..26722f4c9 100644 --- a/app/src/main/java/it/niedermann/owncloud/notes/edit/BaseNoteFragment.java +++ b/app/src/main/java/it/niedermann/owncloud/notes/edit/BaseNoteFragment.java @@ -272,7 +272,7 @@ public boolean onOptionsItemSelected(MenuItem item) { if (ShortcutManagerCompat.isRequestPinShortcutSupported(context)) { final var pinShortcutInfo = new ShortcutInfoCompat.Builder(context, String.valueOf(note.getId())) .setShortLabel(note.getTitle()) - .setIcon(IconCompat.createWithResource(context.getApplicationContext(), TRUE.equals(note.getFavorite()) ? R.drawable.ic_star_yellow_24dp : R.drawable.ic_star_grey_ccc_24dp)) + .setIcon(IconCompat.createWithResource(context.getApplicationContext(), TRUE.equals(note.getFavorite()) ? R.drawable.ic_star_yellow_24dp : R.drawable.ic_star_border_grey_ccc_24dp)) .setIntent(new Intent(getActivity(), EditNoteActivity.class).putExtra(EditNoteActivity.PARAM_NOTE_ID, note.getId()).setAction(ACTION_SHORTCUT)) .build(); diff --git a/app/src/main/java/it/niedermann/owncloud/notes/main/items/NoteViewHolder.java b/app/src/main/java/it/niedermann/owncloud/notes/main/items/NoteViewHolder.java index 53a48afbd..e33d7a5ff 100644 --- a/app/src/main/java/it/niedermann/owncloud/notes/main/items/NoteViewHolder.java +++ b/app/src/main/java/it/niedermann/owncloud/notes/main/items/NoteViewHolder.java @@ -82,7 +82,7 @@ protected void bindCategory(@NonNull Context context, @NonNull TextView noteCate } protected void bindFavorite(@NonNull ImageView noteFavorite, boolean isFavorite) { - noteFavorite.setImageResource(isFavorite ? R.drawable.ic_star_yellow_24dp : R.drawable.ic_star_grey_ccc_24dp); + noteFavorite.setImageResource(isFavorite ? R.drawable.ic_star_yellow_24dp : R.drawable.ic_star_border_grey_ccc_24dp); noteFavorite.setOnClickListener(view -> noteClickListener.onNoteFavoriteClick(getLayoutPosition(), view)); } diff --git a/app/src/main/java/it/niedermann/owncloud/notes/persistence/NotesRepository.java b/app/src/main/java/it/niedermann/owncloud/notes/persistence/NotesRepository.java index 172ebc5f9..5e0f0e1f9 100644 --- a/app/src/main/java/it/niedermann/owncloud/notes/persistence/NotesRepository.java +++ b/app/src/main/java/it/niedermann/owncloud/notes/persistence/NotesRepository.java @@ -672,7 +672,7 @@ private void updateDynamicShortcuts(long accountId) { newShortcuts.add(new ShortcutInfo.Builder(this.context, note.getId() + "") .setShortLabel(note.getTitle() + "") - .setIcon(Icon.createWithResource(this.context, note.getFavorite() ? R.drawable.ic_star_yellow_24dp : R.drawable.ic_star_grey_ccc_24dp)) + .setIcon(Icon.createWithResource(this.context, note.getFavorite() ? R.drawable.ic_star_yellow_24dp : R.drawable.ic_star_border_grey_ccc_24dp)) .setIntent(intent) .build()); } else { diff --git a/app/src/main/res/drawable/ic_star_border_grey_ccc_24dp.xml b/app/src/main/res/drawable/ic_star_border_grey_ccc_24dp.xml new file mode 100644 index 000000000..a5a654590 --- /dev/null +++ b/app/src/main/res/drawable/ic_star_border_grey_ccc_24dp.xml @@ -0,0 +1,15 @@ + + + +