NMC-2045: Customized popup menu, overflow menu and FastScroller.

surinder-tsys · surinder-tsys · commit 3b92cb70279e · 2025-12-08T13:29:52.000+05:30
NMC-2049: Customized Spinner.
diff --git a/app/src/main/java/com/owncloud/android/ui/activity/UploadFilesActivity.java b/app/src/main/java/com/owncloud/android/ui/activity/UploadFilesActivity.java
@@ -17,6 +17,8 @@
 import android.annotation.SuppressLint;
 import android.app.Activity;
 import android.content.Intent;
+import android.graphics.Color;
+import android.graphics.PorterDuff;
 import android.os.Bundle;
 import android.os.Environment;
 import android.view.Menu;
@@ -208,10 +210,12 @@ public void onCreate(Bundle savedInstanceState) {
         behaviours.add(getString(R.string.uploader_upload_files_behaviour_only_upload));
         behaviours.add(getString(R.string.uploader_upload_files_behaviour_upload_and_delete_from_source));
 
-        ArrayAdapter<String> behaviourAdapter = new ArrayAdapter<>(this, android.R.layout.simple_spinner_item,
+        //custom spinner item layout for NMC
+        ArrayAdapter<String> behaviourAdapter = new ArrayAdapter<>(this, R.layout.simple_spinner_item,
                                                                    behaviours);
         behaviourAdapter.setDropDownViewResource(android.R.layout.simple_spinner_dropdown_item);
         binding.uploadFilesSpinnerBehaviour.setAdapter(behaviourAdapter);
+        binding.uploadFilesSpinnerBehaviour.getBackground().setColorFilter(getResources().getColor(R.color.primary, null), PorterDuff.Mode.SRC_IN);
         binding.uploadFilesSpinnerBehaviour.setSelection(localBehaviour);
 
         // setup the toolbar
@@ -232,6 +236,7 @@ public void onCreate(Bundle savedInstanceState) {
 
         showToolbarSpinner();
         mToolbarSpinner.setAdapter(mDirectories);
+        mToolbarSpinner.getBackground().setColorFilter(Color.TRANSPARENT, PorterDuff.Mode.SRC_IN);
         mToolbarSpinner.setOnItemSelectedListener(new AdapterView.OnItemSelectedListener() {
             @Override
             public void onItemSelected(AdapterView<?> parent, View view, int position, long id) {
diff --git a/app/src/main/java/com/owncloud/android/ui/adapter/SyncedFolderAdapter.kt b/app/src/main/java/com/owncloud/android/ui/adapter/SyncedFolderAdapter.kt
@@ -14,6 +14,7 @@ import android.view.MenuItem
 import android.view.View
 import android.view.ViewGroup
 import android.widget.PopupMenu
+import androidx.appcompat.view.ContextThemeWrapper
 import androidx.annotation.VisibleForTesting
 import androidx.core.content.ContextCompat
 import androidx.core.view.isVisible
@@ -374,7 +375,9 @@ class SyncedFolderAdapter(
     }
 
     private fun onOverflowIconClicked(section: Int, item: SyncedFolderDisplayItem, view: View) {
-        val popup = PopupMenu(context, view).apply {
+        // NMC Customisation
+        val ctw = ContextThemeWrapper(context, R.style.CustomPopupTheme)
+        val popup = PopupMenu(ctw, view).apply {
             inflate(R.menu.synced_folders_adapter)
             setOnMenuItemClickListener { i: MenuItem -> optionsItemSelected(i, section, item) }
             menu
diff --git a/app/src/main/java/com/owncloud/android/ui/adapter/UploadListAdapter.java b/app/src/main/java/com/owncloud/android/ui/adapter/UploadListAdapter.java
@@ -70,6 +70,7 @@
 
 import androidx.annotation.NonNull;
 import kotlin.Unit;
+import androidx.appcompat.view.ContextThemeWrapper;
 
 /**
  * This Adapter populates a ListView with following types of uploads: pending, active, completed. Filtering possible.
@@ -691,7 +692,9 @@ private void showItemConflictPopup(User user,
                                        OCUpload item,
                                        String status,
                                        View view) {
-        PopupMenu popup = new PopupMenu(MainApp.getAppContext(), view);
+        //NMC Customisation
+        ContextThemeWrapper ctw = new ContextThemeWrapper(MainApp.getAppContext(), R.style.CustomPopupTheme);
+        PopupMenu popup = new PopupMenu(ctw, view);
         popup.inflate(R.menu.upload_list_item_file_conflict);
         popup.setOnMenuItemClickListener(i -> {
             int itemId = i.getItemId();
diff --git a/app/src/main/java/com/owncloud/android/ui/fragment/GalleryFragment.java b/app/src/main/java/com/owncloud/android/ui/fragment/GalleryFragment.java
@@ -42,6 +42,7 @@
 
 import androidx.annotation.NonNull;
 import androidx.annotation.Nullable;
+import androidx.core.content.ContextCompat;
 import androidx.localbroadcastmanager.content.LocalBroadcastManager;
 import androidx.recyclerview.widget.GridLayoutManager;
 import androidx.recyclerview.widget.RecyclerView;
@@ -288,7 +289,8 @@ public void onCreateOptionsMenu(Menu menu, @NonNull MenuInflater inflater) {
         MenuItem menuItem = menu.findItem(R.id.action_three_dot_icon);
 
         if (menuItem != null) {
-            viewThemeUtils.platform.colorMenuItemText(requireContext(), menuItem);
+            //NMC customization
+            menuItem.setIcon(viewThemeUtils.platform.colorDrawable(menuItem.getIcon(), ContextCompat.getColor(requireContext(), R.color.fontAppbar)));
         }
 
     }
diff --git a/app/src/main/java/com/owncloud/android/ui/fragment/OCFileListFragment.java b/app/src/main/java/com/owncloud/android/ui/fragment/OCFileListFragment.java
@@ -821,7 +821,8 @@ public boolean onCreateActionMode(ActionMode mode, Menu menu) {
 
             final MenuItem item = menu.findItem(R.id.custom_menu_placeholder_item);
             if (item.getIcon() != null) {
-                item.setIcon(viewThemeUtils.platform.colorDrawable(item.getIcon(), ContextCompat.getColor(requireContext(), R.color.white)));
+                // NMC customization
+                item.setIcon(viewThemeUtils.platform.colorDrawable(item.getIcon(), ContextCompat.getColor(requireContext(), R.color.fontAppbar)));
             }
 
             mActiveActionMode.invalidate();
diff --git a/app/src/main/java/com/owncloud/android/ui/preview/PreviewImageFragment.kt b/app/src/main/java/com/owncloud/android/ui/preview/PreviewImageFragment.kt
@@ -355,10 +355,11 @@ class PreviewImageFragment :
                     val item = menu.findItem(R.id.custom_menu_placeholder_item)
 
                     item.icon?.let {
+                        // NMC customization
                         item.setIcon(
                             viewThemeUtils.platform.colorDrawable(
                                 it,
-                                ContextCompat.getColor(requireContext(), R.color.white)
+                                ContextCompat.getColor(requireContext(), R.color.fontAppbar)
                             )
                         )
                     }
diff --git a/app/src/main/java/com/owncloud/android/ui/preview/PreviewMediaFragment.kt b/app/src/main/java/com/owncloud/android/ui/preview/PreviewMediaFragment.kt
@@ -33,6 +33,7 @@ import android.view.ViewGroup
 import androidx.annotation.OptIn
 import androidx.annotation.StringRes
 import androidx.core.net.toUri
+import androidx.core.content.ContextCompat
 import androidx.core.view.MenuHost
 import androidx.core.view.MenuProvider
 import androidx.drawerlayout.widget.DrawerLayout
@@ -71,6 +72,7 @@ import com.owncloud.android.ui.dialog.ConfirmationDialogFragment
 import com.owncloud.android.ui.dialog.RemoveFilesDialogFragment
 import com.owncloud.android.ui.fragment.FileFragment
 import com.owncloud.android.utils.MimeTypeUtil
+import com.owncloud.android.utils.theme.ViewThemeUtils
 import java.lang.ref.WeakReference
 import java.util.concurrent.Executors
 import javax.inject.Inject
@@ -121,6 +123,9 @@ class PreviewMediaFragment :
     @Inject
     lateinit var backgroundJobManager: BackgroundJobManager
 
+    @Inject
+    lateinit var viewThemeUtils: ViewThemeUtils
+
     lateinit var binding: FragmentPreviewMediaBinding
     private var emptyListView: ViewGroup? = null
     private var exoPlayer: ExoPlayer? = null
@@ -312,6 +317,16 @@ class PreviewMediaFragment :
                 override fun onCreateMenu(menu: Menu, menuInflater: MenuInflater) {
                     menu.removeItem(R.id.action_search)
                     menuInflater.inflate(R.menu.custom_menu_placeholder, menu)
+                    // NMC customization
+                    val item = menu.findItem(R.id.custom_menu_placeholder_item)
+                    item.icon?.let {
+                        item.setIcon(
+                            viewThemeUtils.platform.colorDrawable(
+                                it,
+                                ContextCompat.getColor(requireContext(), R.color.fontAppbar)
+                            )
+                        )
+                    }
                 }
 
                 override fun onMenuItemSelected(menuItem: MenuItem): Boolean {
diff --git a/app/src/main/java/com/owncloud/android/ui/trashbin/TrashbinActivity.kt b/app/src/main/java/com/owncloud/android/ui/trashbin/TrashbinActivity.kt
@@ -23,6 +23,7 @@ import androidx.activity.OnBackPressedCallback
 import androidx.annotation.IdRes
 import androidx.annotation.VisibleForTesting
 import androidx.core.content.ContextCompat
+import androidx.appcompat.view.ContextThemeWrapper
 import androidx.core.content.res.ResourcesCompat
 import androidx.drawerlayout.widget.DrawerLayout
 import androidx.recyclerview.widget.LinearLayoutManager
@@ -237,7 +238,9 @@ class TrashbinActivity :
     }
 
     override fun onOverflowIconClicked(file: TrashbinFile, view: View) {
-        val popup = PopupMenu(this, view)
+        // NMC Customization
+        val ctw = ContextThemeWrapper(this, R.style.CustomPopupTheme)
+        val popup = PopupMenu(ctw, view)
         popup.inflate(R.menu.item_trashbin)
         popup.setOnMenuItemClickListener {
             onFileActionChosen(it.itemId, setOf(file))
@@ -569,11 +572,12 @@ class TrashbinActivity :
             val inflater: MenuInflater = activity.menuInflater
             inflater.inflate(R.menu.custom_menu_placeholder, menu)
             val item = menu.findItem(R.id.custom_menu_placeholder_item)
+            // NMC Customization
             item.icon?.let {
                 item.setIcon(
                     viewThemeUtils.platform.colorDrawable(
                         it,
-                        ContextCompat.getColor(activity, R.color.white)
+                        ContextCompat.getColor(activity, R.color.fontAppbar)
                     )
                 )
             }
diff --git a/app/src/main/java/com/owncloud/android/utils/theme/FilesSpecificViewThemeUtils.kt b/app/src/main/java/com/owncloud/android/utils/theme/FilesSpecificViewThemeUtils.kt
@@ -107,7 +107,8 @@ class FilesSpecificViewThemeUtils @Inject constructor(
                 .setThumbDrawable(getThumbDrawable(context))
                 .setPopupStyle {
                     PopupStyles.MD2.accept(it)
-                    it.background = FastScrollPopupBackground(context, scheme.primary)
+                    //NMC customisation
+                    it.background = FastScrollPopupBackground(context, context.resources.getColor(R.color.primary, null))
                 }
         }
 
@@ -118,7 +119,7 @@ class FilesSpecificViewThemeUtils @Inject constructor(
                 me.zhanghai.android.fastscroll.R.drawable.afs_md2_thumb,
                 null
             )
-        return androidViewThemeUtils.tintPrimaryDrawable(context, thumbDrawable)!!
+        return androidViewThemeUtils.colorDrawable(thumbDrawable!!, context.resources.getColor(R.color.primary, null))
     }
 
     private fun getHomeAsUpIcon(isMenu: Boolean): Int {
diff --git a/app/src/main/res/drawable/bg_spinner.xml b/app/src/main/res/drawable/bg_spinner.xml
@@ -0,0 +1,9 @@
+<?xml version="1.0" encoding="utf-8"?>
+<selector xmlns:android="http://schemas.android.com/apk/res/android">
+    <item>
+        <layer-list>
+            <item android:drawable="@drawable/ic_keyboard_arrow_down"
+                android:gravity="center_vertical|right" android:right="5dp" />
+        </layer-list>
+    </item>
+</selector>
diff --git a/app/src/main/res/layout/simple_spinner_item.xml b/app/src/main/res/layout/simple_spinner_item.xml
@@ -0,0 +1,10 @@
+<?xml version="1.0" encoding="utf-8"?>
+<TextView xmlns:android="http://schemas.android.com/apk/res/android"
+    android:id="@android:id/text1"
+    style="?android:attr/spinnerItemStyle"
+    android:singleLine="true"
+    android:textColor="@color/primary"
+    android:layout_width="match_parent"
+    android:layout_height="wrap_content"
+    android:ellipsize="marquee"
+    android:textAlignment="inherit"/>
diff --git a/app/src/main/res/layout/upload_files_layout.xml b/app/src/main/res/layout/upload_files_layout.xml
@@ -60,7 +60,9 @@
         <Spinner
             android:layout_width="match_parent"
             android:layout_height="0dp"
+            style="@style/SpinnerTheme"
             android:id="@+id/upload_files_spinner_behaviour"
+            android:paddingRight="40dp"
             android:layout_weight="1"/>
     </LinearLayout>
 
diff --git a/app/src/main/res/values-night/colors.xml b/app/src/main/res/values-night/colors.xml
@@ -39,4 +39,69 @@
     <color name="fontAppbar">@android:color/white</color>
 
     <color name="actionbar_color">#101418</color>
+
+    <!-- NMC Colors -->
+    <color name="icon_color">#FFFFFF</color>
+    <color name="sort_text_color">@color/grey_30</color>
+    <color name="list_icon_color">@color/grey_30</color>
+    <color name="warning_icon_color">#CCCCCC</color>
+    <color name="divider_color">@color/grey_70</color>
+    <color name="spinner_bg_color">@color/grey_80</color>
+    <color name="refresh_layout_bg_color">#2D2D2D</color>
+    <color name="primary_button_disabled_color">@color/grey_70</color>
+    <color name="toolbar_divider_color">@color/grey_70</color>
+
+    <!-- Snackbar Colors -->
+    <color name="snackbar_bg_color">@color/grey_80</color>
+    <color name="snackbar_txt_color">@color/grey_0</color>
+
+    <!-- Alert Dialog Colors -->
+    <color name="alert_bg_color">@color/grey_80</color>
+    <color name="alert_txt_color">@color/grey_0</color>
+
+    <!--  NavigationView colors  -->
+    <color name="nav_selected_bg_color">@color/grey_60</color>
+    <color name="nav_txt_unselected_color">@color/grey_0</color>
+    <color name="nav_txt_selected_color">@color/grey_0</color>
+    <color name="nav_icon_unselected_color">@color/grey_30</color>
+    <color name="nav_icon_selected_color">#FFFFFF</color>
+    <color name="nav_divider_color">@color/grey_30</color>
+    <color name="nav_bg_color">@color/grey_80</color>
+    <color name="drawer_quota_txt_color">#FFFFFF</color>
+
+    <!-- Bottom Sheet Colors -->
+    <color name="bottom_sheet_bg_color">@color/grey_80</color>
+    <color name="bottom_sheet_icon_color">@color/grey_30</color>
+    <color name="bottom_sheet_txt_color">@color/grey_0</color>
+
+    <!-- Popup Menu Colors -->
+    <color name="popup_menu_bg">@color/grey_80</color>
+    <color name="popup_menu_txt_color">@color/grey_0</color>
+    <color name="overflow_bg_color">@color/grey_80</color>
+
+    <!-- Switch Compat Colors -->
+    <color name="switch_thumb_disabled">@color/grey_70</color>
+    <color name="switch_track_disabled">@color/grey_60</color>
+
+    <!-- Checkbox Colors -->
+    <color name="checkbox_checked_disabled">@color/grey_70</color>
+    <color name="checkbox_unchecked_disabled">@color/grey_70</color>
+
+    <!-- Share Colors -->
+    <color name="share_title_txt_color">#FFFFFF</color>
+    <color name="share_subtitle_txt_color">@color/grey_30</color>
+    <color name="share_info_txt_color">@color/grey_0</color>
+    <color name="share_search_border_color">@color/grey_0</color>
+    <color name="share_btn_txt_color">@color/grey_0</color>
+    <color name="share_list_item_txt_color">@color/grey_0</color>
+    <color name="share_disabled_txt_color">@color/grey_60</color>
+    <color name="share_txt_color">@color/grey_0</color>
+    <color name="share_et_divider">#FFFFFF</color>
+    <color name="share_blue_color">#7d94f9</color>
+
+    <!-- Scan Colors -->
+    <color name="scan_doc_bg_color">#121212</color>
+    <color name="scan_text_color">@color/grey_0</color>
+    <color name="scan_edit_bottom_color">@color/grey_80</color>
+    <color name="scan_count_bg_color">@color/grey_80</color>
 </resources>
diff --git a/app/src/main/res/values/colors.xml b/app/src/main/res/values/colors.xml
diff --git a/app/src/main/res/values/nmc_popup_styles.xml b/app/src/main/res/values/nmc_popup_styles.xml
diff --git a/app/src/main/res/values/nmc_spinner_styles.xml b/app/src/main/res/values/nmc_spinner_styles.xml
diff --git a/app/src/main/res/values/styles.xml b/app/src/main/res/values/styles.xml

Original file line number	Diff line number	Diff line change
`@@ -42,6 +42,7 @@`
`42`	`42`
`43`	`43`	`import androidx.annotation.NonNull;`
`44`	`44`	`import androidx.annotation.Nullable;`
	`45`	`+import androidx.core.content.ContextCompat;`
`45`	`46`	`import androidx.localbroadcastmanager.content.LocalBroadcastManager;`
`46`	`47`	`import androidx.recyclerview.widget.GridLayoutManager;`
`47`	`48`	`import androidx.recyclerview.widget.RecyclerView;`
`@@ -288,7 +289,8 @@ public void onCreateOptionsMenu(Menu menu, @NonNull MenuInflater inflater) {`
`288`	`289`	`MenuItem menuItem = menu.findItem(R.id.action_three_dot_icon);`
`289`	`290`
`290`	`291`	`if (menuItem != null) {`
`291`		`- viewThemeUtils.platform.colorMenuItemText(requireContext(), menuItem);`
	`292`	`+ //NMC customization`
	`293`	`+ menuItem.setIcon(viewThemeUtils.platform.colorDrawable(menuItem.getIcon(), ContextCompat.getColor(requireContext(), R.color.fontAppbar)));`
`292`	`294`	`}`
`293`	`295`
`294`	`296`	`}`
Original file line number	Diff line number	Diff line change
`@@ -821,7 +821,8 @@ public boolean onCreateActionMode(ActionMode mode, Menu menu) {`
`821`	`821`
`822`	`822`	`final MenuItem item = menu.findItem(R.id.custom_menu_placeholder_item);`
`823`	`823`	`if (item.getIcon() != null) {`
`824`		`- item.setIcon(viewThemeUtils.platform.colorDrawable(item.getIcon(), ContextCompat.getColor(requireContext(), R.color.white)));`
	`824`	`+ // NMC customization`
	`825`	`+ item.setIcon(viewThemeUtils.platform.colorDrawable(item.getIcon(), ContextCompat.getColor(requireContext(), R.color.fontAppbar)));`
`825`	`826`	`}`
`826`	`827`
`827`	`828`	`mActiveActionMode.invalidate();`
Original file line number	Diff line number	Diff line change
`@@ -355,10 +355,11 @@ class PreviewImageFragment :`
`355`	`355`	`val item = menu.findItem(R.id.custom_menu_placeholder_item)`
`356`	`356`
`357`	`357`	`item.icon?.let {`
	`358`	`+ // NMC customization`
`358`	`359`	`item.setIcon(`
`359`	`360`	`viewThemeUtils.platform.colorDrawable(`
`360`	`361`	`it,`
`361`		`- ContextCompat.getColor(requireContext(), R.color.white)`
	`362`	`+ ContextCompat.getColor(requireContext(), R.color.fontAppbar)`
`362`	`363`	`)`
`363`	`364`	`)`
`364`	`365`	`}`
Original file line number	Diff line number	Diff line change
`@@ -107,7 +107,8 @@ class FilesSpecificViewThemeUtils @Inject constructor(`
`107`	`107`	`.setThumbDrawable(getThumbDrawable(context))`
`108`	`108`	`.setPopupStyle {`
`109`	`109`	`PopupStyles.MD2.accept(it)`
`110`		`- it.background = FastScrollPopupBackground(context, scheme.primary)`
	`110`	`+ //NMC customisation`
	`111`	`+ it.background = FastScrollPopupBackground(context, context.resources.getColor(R.color.primary, null))`
`111`	`112`	`}`
`112`	`113`	`}`
`113`	`114`
`@@ -118,7 +119,7 @@ class FilesSpecificViewThemeUtils @Inject constructor(`
`118`	`119`	`me.zhanghai.android.fastscroll.R.drawable.afs_md2_thumb,`
`119`	`120`	`null`
`120`	`121`	`)`
`121`		`- return androidViewThemeUtils.tintPrimaryDrawable(context, thumbDrawable)!!`
	`122`	`+ return androidViewThemeUtils.colorDrawable(thumbDrawable!!, context.resources.getColor(R.color.primary, null))`
`122`	`123`	`}`
`123`	`124`
`124`	`125`	`private fun getHomeAsUpIcon(isMenu: Boolean): Int {`