diff --git a/app/src/debug/res/values/setup.xml b/app/src/debug/res/values/setup.xml new file mode 100644 index 000000000000..046f7830a774 --- /dev/null +++ b/app/src/debug/res/values/setup.xml @@ -0,0 +1,6 @@ + + + + + \ No newline at end of file diff --git a/app/src/main/java/com/owncloud/android/authentication/AuthenticatorActivity.java b/app/src/main/java/com/owncloud/android/authentication/AuthenticatorActivity.java index c881c400b64c..6daeb4e6894e 100644 --- a/app/src/main/java/com/owncloud/android/authentication/AuthenticatorActivity.java +++ b/app/src/main/java/com/owncloud/android/authentication/AuthenticatorActivity.java @@ -415,7 +415,13 @@ public boolean onKeyDown(int keyCode, KeyEvent event) { if (accountSetupWebviewBinding != null && event.getAction() == KeyEvent.ACTION_DOWN && keyCode == KeyEvent.KEYCODE_BACK) { if (accountSetupWebviewBinding.loginWebview.canGoBack()) { - accountSetupWebviewBinding.loginWebview.goBack(); + // NMC-2602 Fix + // On back press "Webpage not available" error comes + // because login urls doesn't maintain the backstack hierarchy + // to solve it we are recreating the activity with the actual login url + // if user presses back from other urls which is not first or login url + // it will recreate the activity else it will finish the activity + recreate(); } else { finish(); } @@ -457,6 +463,10 @@ public boolean shouldOverrideUrlLoading(WebView view, String url) { public void onPageFinished(WebView view, String url) { super.onPageFinished(view, url); + //scroll to top when url loads + //because directly loading Telekom login page it scrolls down automatically + view.scrollTo(0,0); + accountSetupWebviewBinding.loginWebviewProgressBar.setVisibility(View.GONE); accountSetupWebviewBinding.loginWebview.setVisibility(View.VISIBLE); diff --git a/app/src/main/java/com/owncloud/android/ui/activity/BaseActivity.java b/app/src/main/java/com/owncloud/android/ui/activity/BaseActivity.java index 4c1e79f28de8..01084174325b 100644 --- a/app/src/main/java/com/owncloud/android/ui/activity/BaseActivity.java +++ b/app/src/main/java/com/owncloud/android/ui/activity/BaseActivity.java @@ -109,7 +109,10 @@ protected void onNewIntent(Intent intent) { protected void onRestart() { Log_OC.v(TAG, "onRestart() start"); super.onRestart(); - mixinRegistry.onRestart(); + //Fix of NMC-2303 and NMC-2441 + if (enableAccountHandling) { + mixinRegistry.onRestart(); + } } private void onThemeSettingsModeChanged() { diff --git a/app/src/main/java/com/owncloud/android/ui/activity/DrawerActivity.java b/app/src/main/java/com/owncloud/android/ui/activity/DrawerActivity.java index 0dd4e2aa3b70..dbe48a70c550 100644 --- a/app/src/main/java/com/owncloud/android/ui/activity/DrawerActivity.java +++ b/app/src/main/java/com/owncloud/android/ui/activity/DrawerActivity.java @@ -1170,7 +1170,8 @@ protected void onStop() { @Subscribe(threadMode = ThreadMode.MAIN) public void onAccountRemovedEvent(AccountRemovedEvent event) { - restart(); + //NMC customization + finish(); } /** diff --git a/app/src/main/res/values/setup.xml b/app/src/main/res/values/setup.xml index dc03a9fcabc6..61e604e3c733 100644 --- a/app/src/main/res/values/setup.xml +++ b/app/src/main/res/values/setup.xml @@ -54,7 +54,7 @@ #7fC0E3 - true + false false diff --git a/app/src/release/res/values/setup.xml b/app/src/release/res/values/setup.xml new file mode 100644 index 000000000000..a4600f0ff88a --- /dev/null +++ b/app/src/release/res/values/setup.xml @@ -0,0 +1,5 @@ + + + + https://magentacloud.de/index.php/login/flow + \ No newline at end of file