Skip to content

Publish_NIMS.yml failures sometimes leave the repo's branch protection rules in an incorrect state #940

@bkeryan

Description

@bkeryan

Tech Debt

https://github.com/ni/measurement-plugin-python/blob/main/.github/workflows/Publish_NIMS.yml uses the https://github.com/CasperWA/push-protected action, which edits the repo's branch protection rules to temporarily unprotect reviews. Sometimes the Publish_NIMS.yml workflow fails and the original branch protection rules are not restored.

We should figure out whether this issue is caused by upstream or we're doing something wrong. If it's a problem with upstream, we should report it.

It could also make sense to stop using push-protected, or to split updating the package version in pyproject.toml into a separate workflow to decouple it from publishing.

AB#2867320

Metadata

Metadata

Assignees

No one assigned

    Labels

    tech debtNon-user-visible improvement to code or development process

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions