Test PATCH combined deletion and insertion.

Author: RubenVerborgh

test/integration/patch.js

@@ -87,7 +87,7 @@ describe('PATCH', () => {
   })
 
   describe('appending', () => {
-    describe('to a resource with read-only access', () => {
+    describe('on a resource with read-only access', () => {
       it('returns a 403', () =>
         request.patch('/read-only.ttl')
           .set('Authorization', `Bearer ${userCredentials}`)
@@ -108,7 +108,7 @@ describe('PATCH', () => {
       })
     })
 
-    describe('to a non-existing file', () => {
+    describe('on a non-existing file', () => {
       after(() => rm('patch/new.ttl'))
 
       it('returns a 200', () =>
@@ -131,7 +131,7 @@ describe('PATCH', () => {
       })
     })
 
-    describe('to a resource with append access', () => {
+    describe('on a resource with append access', () => {
       before(() => backup('patch/append-only.ttl'))
       after(() => restore('patch/append-only.ttl'))
 
@@ -155,7 +155,7 @@ describe('PATCH', () => {
       })
     })
 
-    describe('to a resource with write access', () => {
+    describe('on a resource with write access', () => {
       before(() => backup('patch/write-only.ttl'))
       after(() => restore('patch/write-only.ttl'))
 
@@ -181,7 +181,7 @@ describe('PATCH', () => {
   })
 
   describe('deleting', () => {
-    describe('from a resource with read-only access', () => {
+    describe('on a resource with read-only access', () => {
       it('returns a 403', () =>
         request.patch('/read-only.ttl')
           .set('Authorization', `Bearer ${userCredentials}`)
@@ -202,7 +202,7 @@ describe('PATCH', () => {
       })
     })
 
-    describe('from a non-existing file', () => {
+    describe('on a non-existing file', () => {
       after(() => rm('patch/new.ttl'))
 
       it('returns a 409', () =>
@@ -224,7 +224,7 @@ describe('PATCH', () => {
       })
     })
 
-    describe.skip('from a resource with append-only access', () => {
+    describe.skip('on a resource with append-only access', () => {
       before(() => backup('patch/append-only.ttl'))
       after(() => restore('patch/append-only.ttl'))
 
@@ -248,7 +248,7 @@ describe('PATCH', () => {
       })
     })
 
-    describe.skip('from a resource with write-only access', () => {
+    describe.skip('on a resource with write-only access', () => {
       before(() => backup('patch/write-only.ttl'))
       after(() => restore('patch/write-only.ttl'))
 
@@ -275,7 +275,7 @@ describe('PATCH', () => {
       })
     })
 
-    describe('from a resource with read-write access', () => {
+    describe('on a resource with read-write access', () => {
       describe('with a patch for existing data', () => {
         before(() => backup('patch/read-write.ttl'))
         after(() => restore('patch/read-write.ttl'))
@@ -325,6 +325,173 @@ describe('PATCH', () => {
       })
     })
   })
+
+  describe('deleting and inserting', () => {
+    describe('on a resource with read-only access', () => {
+      it('returns a 403', () =>
+        request.patch('/read-only.ttl')
+          .set('Authorization', `Bearer ${userCredentials}`)
+          .set('Content-Type', 'text/n3')
+          .send(n3Patch(`
+            <> p:patches <https://tim.localhost:7777/read-only.ttl>;
+               p:insert { <x> <y> <z>. };
+               p:delete { <a> <b> <c>. }.`
+          ))
+          .expect(403)
+          .then(response => {
+            assert.include(response.text, 'Access denied')
+          })
+      )
+
+      it('does not modify the file', () => {
+        assert.equal(read('patch/read-only.ttl'),
+          '<a> <b> <c>.\n<d> <e> <f>.\n')
+      })
+    })
+
+    describe('on a non-existing file', () => {
+      after(() => rm('patch/new.ttl'))
+
+      it('returns a 409', () =>
+        request.patch('/new.ttl')
+          .set('Authorization', `Bearer ${userCredentials}`)
+          .set('Content-Type', 'text/n3')
+          .send(n3Patch(`
+            <> p:patches <https://tim.localhost:7777/new.ttl>;
+               p:insert { <x> <y> <z>. };
+               p:delete { <a> <b> <c>. }.`
+          ))
+          .expect(409)
+          .then(response => {
+            assert.include(response.text, 'The patch could not be applied')
+          })
+      )
+
+      it('does not create the file', () => {
+        assert.isFalse(fs.existsSync('patch/new.ttl'))
+      })
+    })
+
+    describe.skip('on a resource with append-only access', () => {
+      before(() => backup('patch/append-only.ttl'))
+      after(() => restore('patch/append-only.ttl'))
+
+      it('returns a 403', () =>
+        request.patch('/append-only.ttl')
+          .set('Authorization', `Bearer ${userCredentials}`)
+          .set('Content-Type', 'text/n3')
+          .send(n3Patch(`
+            <> p:patches <https://tim.localhost:7777/append-only.ttl>;
+               p:insert { <x> <y> <z>. };
+               p:delete { <a> <b> <c>. }.`
+          ))
+          .expect(403)
+          .then(response => {
+            assert.include(response.text, 'Access denied')
+          })
+      )
+
+      it('does not modify the file', () => {
+        assert.equal(read('patch/append-only.ttl'),
+          '<a> <b> <c>.\n<d> <e> <f>.\n')
+      })
+    })
+
+    describe.skip('on a resource with write-only access', () => {
+      before(() => backup('patch/write-only.ttl'))
+      after(() => restore('patch/write-only.ttl'))
+
+      // Allowing the delete would either return 200 or 409,
+      // thereby incorrectly giving the user (guess-based) read access;
+      // therefore, we need to return 403.
+      it('returns a 403', () =>
+        request.patch('/write-only.ttl')
+          .set('Authorization', `Bearer ${userCredentials}`)
+          .set('Content-Type', 'text/n3')
+          .send(n3Patch(`
+            <> p:patches <https://tim.localhost:7777/write-only.ttl>;
+               p:insert { <x> <y> <z>. };
+               p:delete { <a> <b> <c>. }.`
+          ))
+          .expect(403)
+          .then(response => {
+            assert.include(response.text, 'Access denied')
+          })
+      )
+
+      it('does not modify the file', () => {
+        assert.equal(read('patch/append-only.ttl'),
+          '<a> <b> <c>.\n<d> <e> <f>.\n')
+      })
+    })
+
+    describe('on a resource with read-write access', () => {
+      describe('with a patch for existing data', () => {
+        before(() => backup('patch/read-write.ttl'))
+        after(() => restore('patch/read-write.ttl'))
+
+        it('returns a 200', () =>
+          request.patch('/read-write.ttl')
+            .set('Authorization', `Bearer ${userCredentials}`)
+            .set('Content-Type', 'text/n3')
+            .send(n3Patch(`
+              <> p:patches <https://tim.localhost:7777/read-write.ttl>;
+               p:insert { <x> <y> <z>. };
+               p:delete { <a> <b> <c>. }.`
+            ))
+            .expect(200)
+            .then(response => {
+              assert.include(response.text, 'Patch applied successfully')
+            })
+        )
+
+        it('patches the file', () => {
+          assert.equal(read('patch/read-write.ttl'),
+            '@prefix : </read-write.ttl#>.\n@prefix tim: </>.\n\ntim:d tim:e tim:f.\n\ntim:x tim:y tim:z.\n\n')
+        })
+      })
+
+      describe('with a patch for non-existing data', () => {
+        before(() => backup('patch/read-write.ttl'))
+        after(() => restore('patch/read-write.ttl'))
+
+        it('returns a 409', () =>
+          request.patch('/read-write.ttl')
+            .set('Authorization', `Bearer ${userCredentials}`)
+            .set('Content-Type', 'text/n3')
+            .send(n3Patch(`
+              <> p:patches <https://tim.localhost:7777/read-write.ttl>;
+               p:insert { <x> <y> <z>. };
+               p:delete { <q> <s> <s>. }.`
+            ))
+            .expect(409)
+            .then(response => {
+              assert.include(response.text, 'The patch could not be applied')
+            })
+        )
+
+        it('does not change the file', () => {
+          assert.equal(read('patch/read-write.ttl'),
+            '<a> <b> <c>.\n<d> <e> <f>.\n')
+        })
+      })
+
+      it('executes deletes before inserts', () =>
+        request.patch('/read-write.ttl')
+          .set('Authorization', `Bearer ${userCredentials}`)
+          .set('Content-Type', 'text/n3')
+          .send(n3Patch(`
+            <> p:patches <https://tim.localhost:7777/read-write.ttl>;
+             p:insert { <x> <y> <z>. };
+             p:delete { <x> <y> <z>. }.`
+          ))
+          .expect(409)
+          .then(response => {
+            assert.include(response.text, 'The patch could not be applied')
+          })
+        )
+    })
+  })
 })
 
 function n3Patch (contents) {