Skip to content

Commit 47697ca

Browse files
RubenVerborghdmitrizagidulin
authored andcommitted
Remove redundant "identified" setting.
1 parent 1f4fd48 commit 47697ca

File tree

6 files changed

+2
-8
lines changed

6 files changed

+2
-8
lines changed

lib/api/authn/force-user.js

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,6 @@ function initialize (app, argv) {
99
app.use('/', (req, res, next) => {
1010
debug(`Identified user (override): ${forceUserId}`)
1111
req.session.userId = forceUserId
12-
req.session.identified = true
1312
res.set('User', forceUserId)
1413
next()
1514
})

lib/api/authn/webid-tls.js

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ function initialize (app, argv) {
1313

1414
function handler (req, res, next) {
1515
// User already logged in? skip
16-
if (req.session.userId && req.session.identified) {
16+
if (req.session.userId) {
1717
debug('User: ' + req.session.userId)
1818
res.set('User', req.session.userId)
1919
return next()
@@ -34,7 +34,6 @@ function handler (req, res, next) {
3434
return next()
3535
}
3636
req.session.userId = result
37-
req.session.identified = true
3837
debug('Identified user: ' + req.session.userId)
3938
res.set('User', req.session.userId)
4039
return next()
@@ -88,7 +87,6 @@ function getCertificateViaHeader (req) {
8887

8988
function setEmptySession (req) {
9089
req.session.userId = ''
91-
req.session.identified = false
9290
}
9391

9492
/**

lib/create-app.js

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -159,7 +159,6 @@ function initWebId (argv, app, ldp) {
159159
debug(`Rejecting session for ${userId} from ${origin}`)
160160
// Destroy session data
161161
delete req.session.userId
162-
delete req.session.identified
163162
// Ensure this modified session is not saved
164163
req.session.save = (done) => done()
165164
}

lib/requests/auth-request.js

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -155,7 +155,6 @@ class AuthRequest {
155155
debug('Initializing user session with webId: ', userAccount.webId)
156156

157157
session.userId = userAccount.webId
158-
session.identified = true
159158
session.subject = {
160159
_id: userAccount.webId
161160
}

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -59,7 +59,7 @@
5959
"node-forge": "^0.6.38",
6060
"nodemailer": "^3.1.4",
6161
"nomnom": "^1.8.1",
62-
"oidc-auth-manager": "^0.7.2",
62+
"oidc-auth-manager": "^0.7.3",
6363
"oidc-op-express": "^0.0.3",
6464
"rdflib": "^0.15.0",
6565
"recursive-readdir": "^2.1.0",

test/unit/auth-request.js

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -92,7 +92,6 @@ describe('AuthRequest', () => {
9292
request.initUserSession(alice)
9393

9494
expect(request.session.userId).to.equal(webId)
95-
expect(request.session.identified).to.be.true()
9695
let subject = request.session.subject
9796
expect(subject['_id']).to.equal(webId)
9897
})

0 commit comments

Comments
 (0)