Merge pull request #717 from solid/feature/sonarjs

Set up SonarJS static analysis

Author: kjetilk

.travis.yml

@@ -18,6 +18,11 @@ addons:
     - tim.localhost
     - nicola.localhost
 
+script:
+  - npm run standard
+  - npm run sonar
+  - npm run nyc
+
 cache:
   apt: true
   directories:

bin/lib/options.js

@@ -277,7 +277,7 @@ module.exports = [
       return answers.useEmail
     },
     validate: (value) => {
-      if (!value || value === '') {
+      if (!value) {
         return 'You must enter this information'
       }
       return true
@@ -330,7 +330,7 @@ function validPath (value) {
   if (value === 'default') {
     return Promise.resolve(true)
   }
-  if (!value || value === '') {
+  if (!value) {
     return Promise.resolve('You must enter a valid path')
   }
   return new Promise((resolve) => {

lib/acl-checker.js

@@ -49,9 +49,8 @@ class ACLChecker {
     const { resource } = this
     let isContainer = false
     // Create a cascade of reject handlers (one for each possible ACL)
-    let nearestACL = Promise.reject()
-    for (const acl of this.getPossibleACLs()) {
-      nearestACL = nearestACL.catch(() => new Promise((resolve, reject) => {
+    const nearestACL = this.getPossibleACLs().reduce((prevACL, acl) => {
+      return prevACL.catch(() => new Promise((resolve, reject) => {
         this.fetch(acl, (err, graph) => {
           if (err || !graph || !graph.length) {
             isContainer = true
@@ -63,7 +62,7 @@ class ACLChecker {
           }
         })
       }))
-    }
+    }, Promise.reject())
     return nearestACL.catch(e => { throw new Error('No ACL resource found') })
   }
 

lib/handlers/get.js

@@ -95,14 +95,14 @@ function handler (req, res, next) {
         debug('   sending data browser file: ' + dataBrowserPath)
         res.sendFile(dataBrowserPath)
         return
-      } else {
+      } else if (stream) {
         res.setHeader('Content-Type', contentType)
         return stream.pipe(res)
       }
     }
 
     // If request accepts the content-type we found
-    if (negotiator.mediaType([contentType])) {
+    if (stream && negotiator.mediaType([contentType])) {
       res.setHeader('Content-Type', contentType)
       if (contentRange) {
         const headers = { 'Content-Range': contentRange, 'Accept-Ranges': 'bytes', 'Content-Length': chunksize }

lib/handlers/post.js

@@ -37,16 +37,16 @@ function handler (req, res, next) {
     }
 
     // Check if container is a directory
-    if (!stats.isDirectory()) {
+    if (stats && !stats.isDirectory()) {
       debug('Path is not a container, 405!')
       return next(error(405, 'Requested resource is not a container'))
     }
 
     // Dispatch to the right handler
     if (req.is('multipart/form-data')) {
-      multi(req, res, next)
+      multi()
     } else {
-      one(req, res, next)
+      one()
     }
   })