Preserving values if user encounter an error in account creation

This solves #1204

Author: megoth

default-views/account/register-form.hbs

@@ -8,7 +8,7 @@
           <div class="form-group">
             <label class="control-label" for="username">Username*</label>
             <input type="text" class="form-control" name="username" id="username" placeholder="alice"
-                   required/>
+                   required value="{{username}}"/>
 
 	    {{#if multiuser}}
 	    <p>Your username should be a lower-case word with only
@@ -54,18 +54,18 @@
 
           <div class="form-group">
             <label class="control-label" for="name">Name*</label>
-            <input type="text" class="form-control" name="name" id="name" required/>
+            <input type="text" class="form-control" name="name" id="name" required value="{{name}}"/>
           </div>
 
           <div class="form-group">
             <label class="control-label" for="email">Email*</label>
-            <input type="email" class="form-control" name="email" id="email"/>
+            <input type="email" class="form-control" name="email" id="email" value="{{email}}"/>
             <span class="help-block">Your email will only be used for account recovery</span>
           </div>
 
           <div class="form-group">
             <label class="control-label" for="externalWebId">External WebID:</label>
-            <input type="text" class="form-control" name="externalWebId" id="externalWebId"/>
+            <input type="text" class="form-control" name="externalWebId" id="externalWebId" value="{{externalWebId}}"/>
             <span class="help-block">
                 We will generate a Web ID when you register, but if you already have a Web ID hosted elsewhere that you'd prefer to use to log in, enter it here
             </span>
@@ -75,7 +75,7 @@
             {{#if tocUri}}
               <div class="checkbox">
                 <label>
-                  <input type="checkbox" name="acceptToc" value="true">
+                  <input type="checkbox" name="acceptToc" value="true" {{acceptToc ? "checked" : ""}}>
                   I agree to the <a href="{{tocUri}}" target="_blank">Terms &amp; Conditions</a> of this service
                 </label>
               </div>

lib/requests/auth-request.js

@@ -150,10 +150,10 @@ class AuthRequest {
    *
    * @param error {Error}
    */
-  error (error) {
+  error (error, body) {
     error.statusCode = error.statusCode || 400
 
-    this.renderForm(error)
+    this.renderForm(error, body)
   }
 
   /**

lib/requests/create-account-request.js

@@ -91,7 +91,7 @@ class CreateAccountRequest extends AuthRequest {
       request.validate()
       await request.createAccount()
     } catch (error) {
-      request.error(error)
+      request.error(error, req.body)
     }
   }
 
@@ -106,7 +106,7 @@ class CreateAccountRequest extends AuthRequest {
   /**
    * Renders the Register form
    */
-  renderForm (error) {
+  renderForm (error, data = {}) {
     let authMethod = this.accountManager.authMethod
 
     let params = Object.assign({}, this.authQueryParams, {
@@ -116,7 +116,12 @@ class CreateAccountRequest extends AuthRequest {
       registerDisabled: authMethod === 'tls',
       returnToUrl: this.returnToUrl,
       tocUri: this.tocUri,
-      disablePasswordChecks: this.disablePasswordChecks
+      disablePasswordChecks: this.disablePasswordChecks,
+      username: data.username,
+      name: data.name,
+      email: data.email,
+      externalWebId: data.externalWebId,
+      acceptToc: data.acceptToc
     })
 
     if (error) {