Skip to content

Commit 85dfa38

Browse files
kjetilkrubensworks
authored andcommitted
our own origin should be denied; Improve comments
1 parent 08485b6 commit 85dfa38

File tree

1 file changed

+5
-19
lines changed

1 file changed

+5
-19
lines changed

test/integration/authentication-oidc-test.js

Lines changed: 5 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -192,8 +192,8 @@ describe('Authentication API (OIDC)', () => {
192192
})
193193
})
194194

195-
// TODO: Are the next two tests correct?
196-
describe('with that cookie and a this origin', () => {
195+
// Shouldn't occur in the wild, so what to do?
196+
describe('with that cookie and our origin', () => {
197197
let response
198198
before(done => {
199199
alice.get('/')
@@ -210,7 +210,8 @@ describe('Authentication API (OIDC)', () => {
210210
})
211211
})
212212

213-
describe('without that cookie but with a this origin', () => {
213+
// Our own origin
214+
describe('without that cookie but with our origin', () => {
214215
let response
215216
before(done => {
216217
alice.get('/')
@@ -221,21 +222,6 @@ describe('Authentication API (OIDC)', () => {
221222
})
222223
})
223224

224-
it('Should return a 401', () => {
225-
expect(response).to.have.property('status', 401)
226-
})
227-
})
228-
describe('without that cookie and a matching origin', () => {
229-
let response
230-
before(done => {
231-
alice.get('/')
232-
.set('Origin', bobServerUri)
233-
.end((err, res) => {
234-
response = res
235-
done(err)
236-
})
237-
})
238-
239225
it('should return a 403', () => {
240226
expect(response).to.have.property('status', 403)
241227
})
@@ -258,7 +244,7 @@ describe('Authentication API (OIDC)', () => {
258244
})
259245
})
260246

261-
// TODO Does this really make sense?
247+
// Shouldn't occur in the wild, so what do we do?
262248
describe('with that cookie and a non-matching origin', () => {
263249
let response
264250
before(done => {

0 commit comments

Comments
 (0)