Skip to content

Commit f8d467d

Browse files
kjetilkrubensworks
authored andcommitted
Fix some tests; improve documentation (review with @RubenVerborgh)
1 parent cbf61e4 commit f8d467d

File tree

1 file changed

+6
-5
lines changed

1 file changed

+6
-5
lines changed

test/integration/authentication-oidc-test.js

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -205,8 +205,8 @@ describe('Authentication API (OIDC)', () => {
205205
})
206206
})
207207

208-
it('should return a 403', () => {
209-
expect(response).to.have.property('status', 403)
208+
it('should return a 401', () => {
209+
expect(response).to.have.property('status', 401)
210210
})
211211
})
212212

@@ -294,12 +294,13 @@ describe('Authentication API (OIDC)', () => {
294294
})
295295
})
296296

297-
it('should return a 403', () => {
298-
expect(response).to.have.property('status', 403)
297+
it('should return a 401', () => {
298+
expect(response).to.have.property('status', 401)
299299
})
300300
})
301301

302-
// Not authenticated but also wrong origin, TODO 401 or 403?
302+
// Not authenticated but also wrong origin,
303+
// 403 because authenticating wouldn't help, since the Origin is wrong
303304
describe('without that cookie and a matching origin', () => {
304305
let response
305306
before(done => {

0 commit comments

Comments
 (0)