Merge pull request libgit2#4956 from pks-t/pks/examples-cgit2-standalone

examples: produce single cgit2 binary

Author: pks-t

examples/CMakeLists.txt

@@ -1,25 +1,15 @@
 INCLUDE_DIRECTORIES(${LIBGIT2_INCLUDES})
 INCLUDE_DIRECTORIES(SYSTEM ${LIBGIT2_SYSTEM_INCLUDES})
 
-FILE(GLOB_RECURSE SRC_EXAMPLE_GIT2 network/*.c network/*.h common.?)
-ADD_EXECUTABLE(cgit2 ${SRC_EXAMPLE_GIT2})
-SET_TARGET_PROPERTIES(cgit2 PROPERTIES C_STANDARD 90)
+FILE(GLOB LG2_SOURCES *.c)
+ADD_EXECUTABLE(lg2 ${LG2_SOURCES})
+SET_TARGET_PROPERTIES(lg2 PROPERTIES C_STANDARD 90)
 
 # Ensure that we do not use deprecated functions internally
 ADD_DEFINITIONS(-DGIT_DEPRECATE_HARD)
 
 IF(WIN32 OR ANDROID)
-	TARGET_LINK_LIBRARIES(cgit2 git2)
+	TARGET_LINK_LIBRARIES(lg2 git2)
 ELSE()
-	TARGET_LINK_LIBRARIES(cgit2 git2 pthread)
+	TARGET_LINK_LIBRARIES(lg2 git2 pthread)
 ENDIF()
-
-FILE(GLOB SRC_EXAMPLE_APPS RELATIVE ${CMAKE_CURRENT_SOURCE_DIR} *.c)
-FOREACH(src_app ${SRC_EXAMPLE_APPS})
-	STRING(REPLACE ".c" "" app_name ${src_app})
-	IF(NOT ${app_name} STREQUAL "common")
-		ADD_EXECUTABLE(${app_name} ${src_app} "common.c")
-		TARGET_LINK_LIBRARIES(${app_name} git2)
-		SET_TARGET_PROPERTIES(${app_name} PROPERTIES C_STANDARD 90)
-	ENDIF()
-ENDFOREACH()

examples/add.c

@@ -15,6 +15,18 @@
 #include "common.h"
 #include <assert.h>
 
+/**
+ * The following example demonstrates how to add files with libgit2.
+ *
+ * It will use the repository in the current working directory, and act
+ * on files passed as its parameters.
+ *
+ * Recognized options are:
+ *   -v/--verbose: show the file's status after acting on it.
+ *   -n/--dry-run: do not actually change the index.
+ *   -u/--update: update the index instead of adding to it.
+ */
+
 enum print_options {
 	SKIP = 1,
 	VERBOSE = 2,
@@ -31,65 +43,66 @@ static void parse_opts(int *options, int *count, int argc, char *argv[]);
 void init_array(git_strarray *array, int argc, char **argv);
 int print_matched_cb(const char *path, const char *matched_pathspec, void *payload);
 
-int main (int argc, char** argv)
+int lg2_add(git_repository *repo, int argc, char** argv)
 {
 	git_index_matched_path_cb matched_cb = NULL;
-	git_repository *repo = NULL;
 	git_index *index;
 	git_strarray array = {0};
 	int options = 0, count = 0;
 	struct print_payload payload = {0};
 
-	git_libgit2_init();
-
 	parse_opts(&options, &count, argc, argv);
-
 	init_array(&array, argc-count, argv+count);
 
-	check_lg2(git_repository_open(&repo, "."), "No git repository", NULL);
 	check_lg2(git_repository_index(&index, repo), "Could not open repository index", NULL);
 
-	if (options&VERBOSE || options&SKIP) {
+	/* Setup a callback if the requested options need it */
+	if ((options & VERBOSE) || (options & SKIP)) {
 		matched_cb = &print_matched_cb;
 	}
 
+	/* Perform the requested action with the index and files */
 	payload.options = options;
 	payload.repo = repo;
 
-	if (options&UPDATE) {
+	if (options & UPDATE) {
 		git_index_update_all(index, &array, matched_cb, &payload);
 	} else {
 		git_index_add_all(index, &array, 0, matched_cb, &payload);
 	}
 
+	/* Cleanup memory */
 	git_index_write(index);
 	git_index_free(index);
-	git_repository_free(repo);
-
-	git_libgit2_shutdown();
 
 	return 0;
 }
 
+/*
+ * This callback is called for each file under consideration by
+ * git_index_(update|add)_all above.
+ * It makes uses of the callback's ability to abort the action.
+ */
 int print_matched_cb(const char *path, const char *matched_pathspec, void *payload)
 {
 	struct print_payload p = *(struct print_payload*)(payload);
 	int ret;
 	unsigned status;
 	(void)matched_pathspec;
 
+	/* Get the file status */
 	if (git_status_file(&status, p.repo, path)) {
 		return -1;
 	}
 
-	if (status & GIT_STATUS_WT_MODIFIED || status & GIT_STATUS_WT_NEW) {
+	if ((status & GIT_STATUS_WT_MODIFIED) || (status & GIT_STATUS_WT_NEW)) {
 		printf("add '%s'\n", path);
 		ret = 0;
 	} else {
 		ret = 1;
 	}
 
-	if(p.options & SKIP) {
+	if ((p.options & SKIP)) {
 		ret = 1;
 	}
 
@@ -101,11 +114,11 @@ void init_array(git_strarray *array, int argc, char **argv)
 	unsigned int i;
 
 	array->count = argc;
-	array->strings = malloc(sizeof(char*) * array->count);
-	assert(array->strings!=NULL);
+	array->strings = calloc(array->count, sizeof(char *));
+	assert(array->strings != NULL);
 
-	for(i=0; i<array->count; i++) {
-		array->strings[i]=argv[i];
+	for (i = 0; i < array->count; i++) {
+		array->strings[i] = argv[i];
 	}
 
 	return;
@@ -125,33 +138,27 @@ static void parse_opts(int *options, int *count, int argc, char *argv[])
 	int i;
 
 	for (i = 1; i < argc; ++i) {
-		if (argv[i][0] != '-') {
+		if (argv[i][0] != '-')
 			break;
-		}
-		else if(!strcmp(argv[i], "--verbose") || !strcmp(argv[i], "-v")) {
+		else if (!strcmp(argv[i], "--verbose") || !strcmp(argv[i], "-v"))
 			*options |= VERBOSE;
-		}
-		else if(!strcmp(argv[i], "--dry-run") || !strcmp(argv[i], "-n")) {
+		else if (!strcmp(argv[i], "--dry-run") || !strcmp(argv[i], "-n"))
 			*options |= SKIP;
-		}
-		else if(!strcmp(argv[i], "--update") || !strcmp(argv[i], "-u")) {
+		else if (!strcmp(argv[i], "--update") || !strcmp(argv[i], "-u"))
 			*options |= UPDATE;
-		}
-		else if(!strcmp(argv[i], "-h")) {
+		else if (!strcmp(argv[i], "-h")) {
 			print_usage();
 			break;
-		}
-		else if(!strcmp(argv[i], "--")) {
+		} else if (!strcmp(argv[i], "--")) {
 			i++;
 			break;
-		}
-		else {
+		} else {
 			fprintf(stderr, "Unsupported option %s.\n", argv[i]);
 			print_usage();
 		}
 	}
 
-	if (argc<=i)
+	if (argc <= i)
 		print_usage();
 
 	*count = i;

examples/blame.c

@@ -35,30 +35,24 @@ struct opts {
 };
 static void parse_opts(struct opts *o, int argc, char *argv[]);
 
-int main(int argc, char *argv[])
+int lg2_blame(git_repository *repo, int argc, char *argv[])
 {
 	int line, break_on_null_hunk;
 	size_t i, rawsize;
 	char spec[1024] = {0};
 	struct opts o = {0};
 	const char *rawdata;
-	git_repository *repo = NULL;
 	git_revspec revspec = {0};
 	git_blame_options blameopts = GIT_BLAME_OPTIONS_INIT;
 	git_blame *blame = NULL;
 	git_blob *blob;
 	git_object *obj;
 
-	git_libgit2_init();
-
 	parse_opts(&o, argc, argv);
 	if (o.M) blameopts.flags |= GIT_BLAME_TRACK_COPIES_SAME_COMMIT_MOVES;
 	if (o.C) blameopts.flags |= GIT_BLAME_TRACK_COPIES_SAME_COMMIT_COPIES;
 	if (o.F) blameopts.flags |= GIT_BLAME_FIRST_PARENT;
 
-	/** Open the repository. */
-	check_lg2(git_repository_open_ext(&repo, ".", 0, NULL), "Couldn't open repository", NULL);
-
 	/**
 	 * The commit range comes in "commitish" form. Use the rev-parse API to
 	 * nail down the end points.
@@ -131,9 +125,6 @@ int main(int argc, char *argv[])
 	/** Cleanup. */
 	git_blob_free(blob);
 	git_blame_free(blame);
-	git_repository_free(repo);
-
-	git_libgit2_shutdown();
 
 	return 0;
 }

examples/cat-file.c

@@ -120,19 +120,14 @@ static void parse_opts(struct opts *o, int argc, char *argv[]);
 
 
 /** Entry point for this command */
-int main(int argc, char *argv[])
+int lg2_cat_file(git_repository *repo, int argc, char *argv[])
 {
-	git_repository *repo;
 	struct opts o = { ".", NULL, 0, 0 };
 	git_object *obj = NULL;
 	char oidstr[GIT_OID_HEXSZ + 1];
 
-	git_libgit2_init();
-
 	parse_opts(&o, argc, argv);
 
-	check_lg2(git_repository_open_ext(&repo, o.dir, 0, NULL),
-			"Could not open repository", NULL);
 	check_lg2(git_revparse_single(&obj, repo, o.rev),
 			"Could not resolve", o.rev);
 
@@ -188,9 +183,6 @@ int main(int argc, char *argv[])
 	}
 
 	git_object_free(obj);
-	git_repository_free(repo);
-
-	git_libgit2_shutdown();
 
 	return 0;
 }

examples/checkout.c

@@ -172,9 +172,8 @@ static int perform_checkout_ref(git_repository *repo, git_annotated_commit *targ
 }
 
 /** That example's entry point */
-int main(int argc, char **argv)
+int lg2_checkout(git_repository *repo, int argc, char **argv)
 {
-	git_repository *repo = NULL;
 	struct args_info args = ARGS_INFO_INIT;
 	checkout_options opts;
 	git_repository_state_t state;
@@ -185,15 +184,6 @@ int main(int argc, char **argv)
 	/** Parse our command line options */
 	parse_options(&path, &opts, &args);
 
-	/** Initialize the library */
-	err = git_libgit2_init();
-	if (!err)
-		check_lg2(err, "Failed to initialize libgit2", NULL);
-
-	/** Open the repository corresponding to the options */
-	check_lg2(git_repository_open_ext(&repo, path, 0, NULL),
-			  "Could not open repository", NULL);
-
 	/** Make sure we're not about to checkout while something else is going on */
 	state = git_repository_state(repo);
 	if (state != GIT_REPOSITORY_STATE_NONE) {
@@ -228,8 +218,5 @@ int main(int argc, char **argv)
 cleanup:
 	git_annotated_commit_free(checkout_target);
 
-	git_repository_free(repo);
-	git_libgit2_shutdown();
-
 	return err;
 }

examples/network/clone.c examples/clone.cexamples/network/clone.c renamed to examples/clone.c

@@ -1,13 +1,4 @@
 #include "common.h"
-#include <git2.h>
-#include <git2/clone.h>
-#include <stdio.h>
-#include <stdlib.h>
-#include <string.h>
-#ifndef _WIN32
-# include <pthread.h>
-# include <unistd.h>
-#endif
 
 typedef struct progress_data {
 	git_transfer_progress fetch_progress;
@@ -72,7 +63,7 @@ static void checkout_progress(const char *path, size_t cur, size_t tot, void *pa
 }
 
 
-int do_clone(git_repository *repo, int argc, char **argv)
+int lg2_clone(git_repository *repo, int argc, char **argv)
 {
 	progress_data pd = {{0}};
 	git_repository *cloned_repo = NULL;