Skip to content

Commit abfdb8a

Browse files
committed
git_pool_init: return an int
Let `git_pool_init` return an int so that it could fail.
1 parent e4bdba5 commit abfdb8a

File tree

2 files changed

+7
-3
lines changed

2 files changed

+7
-3
lines changed

src/pool.c

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -37,14 +37,16 @@ size_t git_pool__system_page_size(void)
3737
}
3838

3939
#ifndef GIT_DEBUG_POOL
40-
void git_pool_init(git_pool *pool, size_t item_size)
40+
int git_pool_init(git_pool *pool, size_t item_size)
4141
{
4242
assert(pool);
4343
assert(item_size >= 1);
4444

4545
memset(pool, 0, sizeof(git_pool));
4646
pool->item_size = item_size;
4747
pool->page_size = git_pool__system_page_size();
48+
49+
return 0;
4850
}
4951

5052
void git_pool_clear(git_pool *pool)
@@ -125,7 +127,7 @@ static int git_pool__ptr_cmp(const void * a, const void * b)
125127
}
126128
}
127129

128-
void git_pool_init(git_pool *pool, size_t item_size)
130+
int git_pool_init(git_pool *pool, size_t item_size)
129131
{
130132
assert(pool);
131133
assert(item_size >= 1);
@@ -134,6 +136,8 @@ void git_pool_init(git_pool *pool, size_t item_size)
134136
pool->item_size = item_size;
135137
pool->page_size = git_pool__system_page_size();
136138
git_vector_init(&pool->allocations, 100, git_pool__ptr_cmp);
139+
140+
return 0;
137141
}
138142

139143
void git_pool_clear(git_pool *pool)

src/pool.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -81,7 +81,7 @@ typedef struct {
8181
* Of course, you can use this in other ways, but those are the
8282
* two most common patterns.
8383
*/
84-
extern void git_pool_init(git_pool *pool, size_t item_size);
84+
extern int git_pool_init(git_pool *pool, size_t item_size);
8585

8686
/**
8787
* Free all items in pool

0 commit comments

Comments
 (0)