use tabindex when href is not available

bjohansebas · bjohansebas · commit 072aa0da4a91 · 2024-11-20T18:16:40.000-05:00
diff --git a/apps/site/components/Common/Button/index.tsx b/apps/site/components/Common/Button/index.tsx
@@ -24,6 +24,7 @@ const Button: FC<ButtonProps> = ({
     href={disabled ? undefined : href}
     aria-disabled={disabled}
     className={classNames(styles.button, styles[kind], className)}
+    tabIndex={!href ? 0 : undefined}
     {...props}
   >
     {children}

Original file line number	Diff line number	Diff line change
`@@ -24,6 +24,7 @@ const Button: FC<ButtonProps> = ({`
`24`	`24`	`href={disabled ? undefined : href}`
`25`	`25`	`aria-disabled={disabled}`
`26`	`26`	`className={classNames(styles.button, styles[kind], className)}`
	`27`	`+ tabIndex={!href ? 0 : undefined}`
`27`	`28`	`{...props}`
`28`	`29`	`>`
`29`	`30`	`{children}`