simplify mocks

Author: avivkeller

packages/mdx/lib/__tests__/shiki.test.mjs

@@ -3,7 +3,6 @@ import { mock, it, describe } from 'node:test';
 
 import { SKIP } from 'unist-util-visit';
 
-// Mock dependencies
 mock.module('classNames', {
   defaultExport: (...args) => args.filter(Boolean).join(' '),
 });
@@ -17,20 +16,13 @@ mock.module('hast-util-to-string', {
 mock.module('unist-util-visit', {
   namedExports: {
     visit: (tree, nodeType, visitor) => {
-      const traverseNode = (node, index, parent) => {
-        if (node.type === nodeType) {
-          const result = visitor(node, index, parent);
-          if (result?.[0] === SKIP) return true;
-        }
-
-        if (node.children) {
-          for (let i = 0; i < node.children.length; i++) {
-            if (traverseNode(node.children[i], i, node)) return true;
-          }
-        }
-      };
-
-      traverseNode(tree, null, null);
+      if (tree.type === nodeType) visitor(tree, null, null);
+      tree.children?.forEach((child, i) => {
+        if (child.type === nodeType) visitor(child, i, tree);
+        child.children?.forEach((subChild, j) => {
+          if (subChild.type === nodeType) visitor(subChild, j, child);
+        });
+      });
     },
     SKIP,
   },
@@ -48,7 +40,6 @@ mock.module('../highlighter', {
             {
               type: 'element',
               tagName: 'code',
-              properties: {},
               children: [{ type: 'text', value: `highlighted ${code}` }],
             },
           ],
@@ -68,7 +59,7 @@ const {
 describe('rehypeShikiji module', () => {
   describe('Utility functions', () => {
     it('getMetaParameter extracts values from meta strings', () => {
-      const testCases = [
+      const tests = [
         {
           meta: 'displayName="JavaScript"',
           param: 'displayName',
@@ -91,7 +82,7 @@ describe('rehypeShikiji module', () => {
         { meta: 'otherKey="value"', param: 'key', expected: undefined },
       ];
 
-      testCases.forEach(({ meta, param, expected }) => {
+      tests.forEach(({ meta, param, expected }) => {
         assert.equal(getMetaParameter(meta, param), expected);
       });
     });
@@ -126,9 +117,7 @@ describe('rehypeShikiji module', () => {
       ];
 
       assert.ok(isCodeBlock(validBlock));
-      invalidCases.forEach(testCase => {
-        assert.ok(!isCodeBlock(testCase));
-      });
+      invalidCases.forEach(testCase => assert.ok(!isCodeBlock(testCase)));
     });
   });