feat: refactor partner retrieval logic and add providePartners function for weighted shuffling

Author: bjohansebas

apps/site/components/Common/Partners/index.tsx

@@ -3,8 +3,8 @@
 import Tooltip from '@node-core/ui-components/Common/Tooltip';
 import * as PartnerLogos from '@node-core/ui-components/Icons/PartnerLogos';
 
-import { partners } from '#site/next.json.mjs';
-import { shuffle } from '#site/util/array';
+import { providePartners } from '#site/next-data/providers/partners';
+import { partners as allPartners } from '#site/next.json.mjs';
 
 import type { Partner, PartnerCategory } from '#site/types';
 import type { FC } from 'react';
@@ -25,33 +25,19 @@ const getPartners = async (
   category?: PartnerCategory,
   sort?: 'name' | 'weight'
 ) => {
-  let result: Array<Partner> = [];
-
-  const filteredPartners = category
-    ? partners.filter(partner => partner.categories.includes(category))
-    : partners;
+  let result: Array<Partner>;
 
   if (sort === 'name') {
-    filteredPartners.sort((a, b) => a.name.localeCompare(b.name));
-    result = [...filteredPartners];
-  }
-
-  if (sort === 'weight') {
-    const weightedPartners = filteredPartners.flatMap(partner => {
-      const weight = partner.weight ?? 0;
-      return Array(weight > 0 ? weight : 1).fill(partner);
-    });
-
+    // For name sorting, just filter and sort directly - no need for weighted shuffling
+    const filtered = category
+      ? allPartners.filter(p => p.categories.includes(category))
+      : allPartners;
+    result = filtered.toSorted((a, b) => a.name.localeCompare(b.name));
+  } else {
+    // For weight sorting, use cached weighted partners
     const minutes = 300; // Change every 5 minutes
     const seed = Math.floor(Date.now() / (minutes * 1000));
-
-    // Create a copy of the array to avoid modifying the original
-    const shuffled = await shuffle(weightedPartners, seed);
-
-    // Remove duplicates while preserving order
-    const unique = Array.from(new Set(shuffled));
-
-    result = [...unique];
+    result = await providePartners(seed, category);
   }
 
   return length ? result.slice(0, length) : result;

apps/site/next-data/providers/partners.ts

@@ -0,0 +1,31 @@
+'use cache';
+
+import { partners } from '#site/next.json.mjs';
+import { shuffle } from '#site/util/array';
+
+import type { Partner, PartnerCategory } from '#site/types';
+
+/**
+ * Provides the weighted and shuffled partners array.
+ * Results are cached using React's cache directive.
+ * @param seed - The seed for deterministic shuffling
+ * @param category - Optional category to filter partners
+ */
+export const providePartners = async (
+  seed: number,
+  category?: PartnerCategory
+): Promise<Array<Partner>> => {
+  // Create weighted array (duplicates based on weight)
+  const weightedPartners = partners.flatMap(partner => {
+    const weight = partner.weight ?? 0;
+    return Array(weight > 0 ? weight : 1).fill(partner);
+  });
+
+  // Shuffle and remove duplicates
+  const shuffled = await shuffle(weightedPartners, seed);
+  const unique = Array.from(new Set(shuffled));
+
+  return category
+    ? unique.filter(p => p.categories.includes(category))
+    : unique;
+};