code review

Author: avivkeller

.husky/pre-commit

@@ -1,5 +1,4 @@
 # lint and format staged files
-
 pnpm dlx lint-staged
 
 # verify typescript staged files

CONTRIBUTING.md

@@ -181,9 +181,6 @@ Commits should be signed. You can read more about [Commit Signing][] here.
 
 This project uses [Husky][] for Git pre-commit hooks.
 
-- Some JSON files are generated during Build time with empty files as placeholders. Build time happens when you run `pnpm serve` or `pnpm build`.
-- We don't want to commit those unnecessary changes. Since these files exist in the repository, `.gitignore` won't work for them. As a workaround, we have a pre-commit hook to discard those changes.
-
 ## Pull Request Policy
 
 This policy governs how contributions should land within this repository. The lines below state the checks and policies to be followed before merging and in the act of merging.

apps/site/hooks/react-client/useClientContext.ts

@@ -2,8 +2,8 @@
 
 import { useContext } from 'react';
 
-import { MatterContext } from '../../providers/matterProvider';
-import type { ClientSharedServerContext } from '../../types';
+import { MatterContext } from '@/providers/matterProvider';
+import type { ClientSharedServerContext } from '@/types';
 
 const useClientContext = (): ClientSharedServerContext => {
   const {

apps/site/hooks/react-client/useDetectOS.ts

@@ -2,9 +2,9 @@
 
 import { useEffect, useState } from 'react';
 
-import type { UserArchitecture, UserBitness, UserOS } from '../../types/userOS';
-import { detectOS } from '../../util/detectOS';
-import { getHighEntropyValues } from '../../util/getHighEntropyValues';
+import type { UserArchitecture, UserBitness, UserOS } from '@/types/userOS';
+import { detectOS } from '@/util/detectOS';
+import { getHighEntropyValues } from '@/util/getHighEntropyValues';
 
 type UserOSState = {
   os: UserOS | 'LOADING';

apps/site/hooks/react-client/useNavigationState.ts

@@ -3,8 +3,8 @@
 import type { RefObject } from 'react';
 import { useContext, useEffect } from 'react';
 
-import { NavigationStateContext } from '../../providers/navigationStateProvider';
-import { debounce } from '../../util/debounce';
+import { NavigationStateContext } from '@/providers/navigationStateProvider';
+import { debounce } from '@/util/debounce';
 
 const useNavigationState = <T extends HTMLElement>(
   id: string,

apps/site/hooks/react-client/useNotification.ts

@@ -2,7 +2,7 @@
 
 import { useContext } from 'react';
 
-import { NotificationDispatch } from '../../providers/notificationProvider';
+import { NotificationDispatch } from '@/providers/notificationProvider';
 
 const useNotification = () => useContext(NotificationDispatch);
 

apps/site/hooks/react-generic/useSiteNavigation.ts

@@ -2,14 +2,13 @@ import type { RichTranslationValues } from 'next-intl';
 import { useTranslations } from 'next-intl';
 import type { HTMLAttributeAnchorTarget } from 'react';
 
+import { siteNavigation } from '@/next.json.mjs';
 import type {
   FormattedMessage,
   NavigationEntry,
   NavigationKeys,
 } from '@/types';
 
-import { siteNavigation } from '../../next.json.mjs';
-
 type Context = Record<string, RichTranslationValues>;
 type Navigation = Record<string, NavigationEntry>;
 

apps/site/package.json

@@ -20,18 +20,16 @@
     "test:unit": "cross-env NODE_NO_WARNINGS=1 node --experimental-test-coverage --test-coverage-exclude=**/*.test.* --experimental-test-module-mocks --enable-source-maps --import=global-jsdom/register --import=tsx --import=tests/setup.jsx --test **/*.test.*",
     "test:unit:watch": "cross-env NODE_OPTIONS=\"--watch\" pnpm test:unit"
   },
-  "peerDependencies": {
-    "@opentelemetry/api-logs": "~0.200.0",
-    "@opentelemetry/instrumentation": "~0.200.0",
-    "@opentelemetry/resources": "~1.30.1",
-    "@opentelemetry/sdk-logs": "~0.200.0"
-  },
   "dependencies": {
     "@heroicons/react": "~2.2.0",
     "@mdx-js/mdx": "^3.1.0",
     "@node-core/ui-components": "workspace:*",
     "@node-core/website-i18n": "workspace:*",
     "@nodevu/core": "0.3.0",
+    "@opentelemetry/api-logs": "~0.200.0",
+    "@opentelemetry/instrumentation": "~0.200.0",
+    "@opentelemetry/resources": "~1.30.1",
+    "@opentelemetry/sdk-logs": "~0.200.0",
     "@orama/react-components": "^0.6.4",
     "@oramacloud/client": "^2.1.4",
     "@radix-ui/react-slot": "^1.1.2",
@@ -108,7 +106,7 @@
     "tsx": "^4.19.3",
     "typescript": "~5.8.2",
     "typescript-eslint": "~8.29.0",
-    "unified": "11.0.5",
+    "unified": "^11.0.5",
     "user-agent-data-types": "0.4.2"
   }
 }

apps/site/providers/matterProvider.tsx

@@ -3,9 +3,9 @@
 import { createContext } from 'react';
 import type { FC, PropsWithChildren } from 'react';
 
-import { useDetectOS } from '../hooks';
-import type { ClientSharedServerContext } from '../types';
-import { assignClientContext } from '../util/assignClientContext';
+import { useDetectOS } from '@/hooks';
+import type { ClientSharedServerContext } from '@/types';
+import { assignClientContext } from '@/util/assignClientContext';
 
 export const MatterContext = createContext<ClientSharedServerContext>(
   assignClientContext({})

apps/site/providers/releaseProvider.tsx

@@ -9,9 +9,9 @@ import {
   useReducer,
 } from 'react';
 
-import reducer, { getActions, releaseState } from '../reducers/releaseReducer';
-import type { NodeRelease } from '../types';
-import type * as Types from '../types/release';
+import reducer, { getActions, releaseState } from '@/reducers/releaseReducer';
+import type { NodeRelease } from '@/types';
+import type * as Types from '@/types/release';
 
 export const ReleasesContext = createContext<Types.ReleasesContextType>({
   releases: [],