Skip to content

Commit 5ab2cbb

Browse files
committed
fix a11y issue on mdx rendering
1 parent e0f7c44 commit 5ab2cbb

File tree

2 files changed

+15
-6
lines changed

2 files changed

+15
-6
lines changed

apps/site/pages/en/eol.mdx

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -13,17 +13,17 @@ Major versions of Node.js are released, patched, and designated End-Of-Life on a
1313
[View the Node.js release schedule](/about/releases/).
1414

1515
<div className="flex flex-col items-start gap-4 xl:flex-row xl:items-center">
16-
<Button kind="primary" href="/download" className="flex-1">
17-
Upgrade to the latest LTS Node.js®
18-
</Button>
16+
{/* we want to keep the anchor text on the same line else it will be wrapped in a paragraph tag */}
17+
{/* prettier-ignore */}
18+
<Button kind="primary" href="/download" className="flex-1">Upgrade to the latest LTS Node.js®</Button>
1919
<span>or</span>
20+
{/* we want to keep the anchor text on the same line else it will be wrapped in a paragraph tag */}
21+
{/* prettier-ignore */}
2022
<Button
2123
kind="warning"
2224
href="https://nodejs.org/esp/herodevs"
2325
className="flex-1"
24-
>
25-
Get security support for EOL versions
26-
</Button>
26+
>Get security support for EOL versions</Button>
2727
</div>
2828

2929
## What Happens When a Release Line Reaches EOL

packages/ui-components/src/Common/BaseButton/index.stories.tsx

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -33,6 +33,15 @@ export const Secondary: Story = {
3333
},
3434
};
3535

36+
export const Warning: Story = {
37+
args: {
38+
kind: 'warning',
39+
children: 'Get security support for EOL versions ',
40+
disabled: false,
41+
size: 'default',
42+
},
43+
};
44+
3645
export const Special: Story = {
3746
args: {
3847
kind: 'special',

0 commit comments

Comments
 (0)