Commit 674b974
committed
fix(blog): Fix homepage link in RSS feed
When following the Node.js Blog at https://nodejs.org/en/blog in a feed reader
like NetNewsWire, the homepage link gets broken. Instead of navigating the
browser to the website, one gets a blank page and an unexpected RSS feed
download in the background.
The `<link>` tag in RSS 2.0 is for the HTML website. Note that the
"self" link from the RSS file back to itself is separate form this
and already auto-generated by the Feed class. [1]
While at it, fix the broken `<description>undefined</defined>` element.
This is often left empty and fine not to pass in `/apps/site/site.json`.
However, the upstream Feed class has a bug where it takes the undefined
and outputs the string "undefined" as the blog's description instead
of a sensible default like empty string.
[1]: https://github.com/jpmonette/feed
Signed-off-by: Timo Tijhof <krinkle@fastmail.com>1 parent f7e9126 commit 674b974
File tree
2 files changed
+4
-4
lines changed- apps/site/next-data/generators
- __tests__
2 files changed
+4
-4
lines changedLines changed: 2 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
30 | 30 | | |
31 | 31 | | |
32 | 32 | | |
33 | | - | |
34 | | - | |
| 33 | + | |
| 34 | + | |
35 | 35 | | |
36 | 36 | | |
37 | 37 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
32 | 32 | | |
33 | 33 | | |
34 | 34 | | |
35 | | - | |
36 | | - | |
| 35 | + | |
| 36 | + | |
37 | 37 | | |
38 | 38 | | |
39 | 39 | | |
| |||
0 commit comments