Update apps/site/components/Common/Partners/index.tsx

Co-authored-by: Aviv Keller <me@aviv.sh>
Signed-off-by: Sebastian Beltran <bjohansebas@gmail.com>

Author: bjohansebas

apps/site/components/Common/Partners/index.tsx

@@ -25,20 +25,11 @@ const getPartners = async (
   category?: PartnerCategory,
   sort?: 'name' | 'weight'
 ) => {
-  let result: Array<Partner>;
-
-  if (sort === 'name') {
-    // For name sorting, just filter and sort directly - no need for weighted shuffling
-    const filtered = category
-      ? partners.filter(p => p.categories.includes(category))
-      : partners;
-    result = filtered.toSorted((a, b) => a.name.localeCompare(b.name));
-  } else {
-    // For weight sorting, use cached weighted partners
-    const seconds = 300; // Change every 5 minutes
-    const seed = Math.floor(Date.now() / (seconds * 1000));
-    result = await providePartners(seed, category);
-  }
+  let result = sort === 'name' ? partners : await providePartners();
+
+  result = category
+    ? result.filter(p => p.categories.includes(category))
+    : result;
 
   return length ? result.slice(0, length) : result;
 };

apps/site/next-data/generators/partners.mjs

@@ -4,10 +4,12 @@ import { shuffle } from '#site/util/array';
 /**
  * Provides the weighted and shuffled partners array.
  * Results are cached using React's cache directive.
- * @param seed - The seed for deterministic shuffling
- * @param category - Optional category to filter partners
  */
-const providePartners = async (seed, category) => {
+const providePartners = async () => {
+  // For weight sorting, use cached weighted partners
+  const seconds = 300; // Change every 5 minutes
+  const seed = Math.floor(Date.now() / (seconds * 1000));
+
   // Create weighted array (duplicates based on weight)
   const weightedPartners = partners.flatMap(partner => {
     const weight = partner.weight ?? 0;
@@ -16,11 +18,8 @@ const providePartners = async (seed, category) => {
 
   // Shuffle and remove duplicates
   const shuffled = await shuffle(weightedPartners, seed);
-  const unique = Array.from(new Set(shuffled));
 
-  return category
-    ? unique.filter(p => p.categories.includes(category))
-    : unique;
+  return Array.from(new Set(shuffled));
 };
 
 export default providePartners;