fix(sidebar): use RegExp for outgoing link detection (#7844)

* fix(sidebar): use RegExp for outgoing link detection

Signed-off-by: Aviv Keller <me@aviv.sh>

* also use regex in Link

---------

Signed-off-by: Aviv Keller <me@aviv.sh>

Author: avivkeller

apps/site/components/Link.tsx

@@ -7,7 +7,7 @@ const Link: FC<HTMLProps<HTMLAnchorElement>> = ({
   href,
   ...props
 }) => {
-  if (!href || href.toString().startsWith('http')) {
+  if (!href || /^https?:/.test(href.toString())) {
     return (
       <a href={href} {...props}>
         {children}

packages/ui-components/Containers/Sidebar/SidebarItem/index.tsx

@@ -36,7 +36,7 @@ const SidebarItem: FC<SidebarItemProps> = ({
     )}
     <span className={styles.label}>{label}</span>
 
-    {link.startsWith('http') && <ArrowUpRightIcon className={styles.icon} />}
+    {/^https?:/.test(link) && <ArrowUpRightIcon className={styles.icon} />}
   </BaseActiveLink>
 );