From 8d1086d63db9f188bb0facf9f7834f6bec49c3ce Mon Sep 17 00:00:00 2001 From: Aviv Keller Date: Sat, 7 Jun 2025 09:36:26 -0400 Subject: [PATCH 1/2] fix(sidebar): use RegExp for outgoing link detection Signed-off-by: Aviv Keller --- packages/ui-components/Containers/Sidebar/SidebarItem/index.tsx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/ui-components/Containers/Sidebar/SidebarItem/index.tsx b/packages/ui-components/Containers/Sidebar/SidebarItem/index.tsx index bcf429dc64026..0556c11c0d156 100644 --- a/packages/ui-components/Containers/Sidebar/SidebarItem/index.tsx +++ b/packages/ui-components/Containers/Sidebar/SidebarItem/index.tsx @@ -36,7 +36,7 @@ const SidebarItem: FC = ({ )} {label} - {link.startsWith('http') && } + {/^https?:/.test(link) && } ); From 39edd674a36311c3023245df4871feb4f91095d8 Mon Sep 17 00:00:00 2001 From: avivkeller Date: Sat, 7 Jun 2025 10:14:16 -0400 Subject: [PATCH 2/2] also use regex in Link --- apps/site/components/Link.tsx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/apps/site/components/Link.tsx b/apps/site/components/Link.tsx index 72ececf586631..b7d32ff911acd 100644 --- a/apps/site/components/Link.tsx +++ b/apps/site/components/Link.tsx @@ -7,7 +7,7 @@ const Link: FC> = ({ href, ...props }) => { - if (!href || href.toString().startsWith('http')) { + if (!href || /^https?:/.test(href.toString())) { return ( {children}