From 2fb2febe63f4ff8051087f04e609cd68c8a7a787 Mon Sep 17 00:00:00 2001 From: avivkeller Date: Sat, 19 Jul 2025 14:51:28 -0400 Subject: [PATCH 1/2] fix(CodeTabs): name overrides, duplicate name titles --- packages/ui-components/src/MDX/CodeTabs.tsx | 18 ++++++++++++++++-- 1 file changed, 16 insertions(+), 2 deletions(-) diff --git a/packages/ui-components/src/MDX/CodeTabs.tsx b/packages/ui-components/src/MDX/CodeTabs.tsx index 8728b460119f3..9fb1064deb211 100644 --- a/packages/ui-components/src/MDX/CodeTabs.tsx +++ b/packages/ui-components/src/MDX/CodeTabs.tsx @@ -10,6 +10,10 @@ type MDXCodeTabsProps = { defaultTab?: string; }; +const NAME_OVERRIDES: Record = { + mjs: 'ESM', +}; + const MDXCodeTabs: FC = ({ languages: rawLanguages, displayNames: rawDisplayNames, @@ -20,12 +24,22 @@ const MDXCodeTabs: FC = ({ const languages = rawLanguages.split('|'); const displayNames = rawDisplayNames?.split('|') ?? []; + const occurrences: Record = {}; + const tabs = languages.map((language, index) => { - const displayName = displayNames[index]; + const base = + displayNames[index]?.trim() || + NAME_OVERRIDES[language] || + language.toUpperCase(); + + const count = occurrences[base] ?? 0; + occurrences[base] = count + 1; + + const label = count === 0 ? base : `${base} (${count})`; return { key: `${language}-${index}`, - label: displayName?.length ? displayName : language.toUpperCase(), + label: label, }; }); From 4ebd32c704c31f87b20dda0c31d27fe8c07d059e Mon Sep 17 00:00:00 2001 From: Aviv Keller Date: Sat, 19 Jul 2025 15:03:08 -0400 Subject: [PATCH 2/2] Apply suggestion from @Copilot Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: Aviv Keller --- packages/ui-components/src/MDX/CodeTabs.tsx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/ui-components/src/MDX/CodeTabs.tsx b/packages/ui-components/src/MDX/CodeTabs.tsx index 9fb1064deb211..ab565767aa303 100644 --- a/packages/ui-components/src/MDX/CodeTabs.tsx +++ b/packages/ui-components/src/MDX/CodeTabs.tsx @@ -35,7 +35,7 @@ const MDXCodeTabs: FC = ({ const count = occurrences[base] ?? 0; occurrences[base] = count + 1; - const label = count === 0 ? base : `${base} (${count})`; + const label = count > 0 ? `${base} (${count + 1})` : base; return { key: `${language}-${index}`,