From dbadb86721b511ba0e14b50575ba8af47594c6d3 Mon Sep 17 00:00:00 2001 From: Mohit5Upadhyay Date: Sat, 26 Jul 2025 13:09:45 +0530 Subject: [PATCH 1/3] fix: consistent :hover styling (#8034) --- .../src/Containers/Sidebar/SidebarItem/index.module.css | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/ui-components/src/Containers/Sidebar/SidebarItem/index.module.css b/packages/ui-components/src/Containers/Sidebar/SidebarItem/index.module.css index 478de159f39fc..a98ecab650117 100644 --- a/packages/ui-components/src/Containers/Sidebar/SidebarItem/index.module.css +++ b/packages/ui-components/src/Containers/Sidebar/SidebarItem/index.module.css @@ -19,7 +19,7 @@ @apply rounded-sm bg-neutral-100 text-neutral-900 - dark:bg-neutral-800 + dark:bg-neutral-900 dark:text-neutral-100; } From 38ef6db79f92d99af697aefca65834b188f7fc98 Mon Sep 17 00:00:00 2001 From: Mohit5Upadhyay Date: Sat, 26 Jul 2025 20:41:26 +0530 Subject: [PATCH 2/3] chore: added comment linking hover style to related components (#8034) --- .../src/Containers/Sidebar/SidebarItem/index.module.css | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/packages/ui-components/src/Containers/Sidebar/SidebarItem/index.module.css b/packages/ui-components/src/Containers/Sidebar/SidebarItem/index.module.css index a98ecab650117..7c01fec7205c3 100644 --- a/packages/ui-components/src/Containers/Sidebar/SidebarItem/index.module.css +++ b/packages/ui-components/src/Containers/Sidebar/SidebarItem/index.module.css @@ -16,6 +16,12 @@ &:hover { &:not(.progression) .label { + /* + This ensures a consistent hover effect across the website in dark mode (bg-neutral-900) and light mode (bg-neutral-100). + See: + - src/Containers/NavBar/index.module.css (Navbar hover) + - src/Containers/NavBar/NavItem/index.module.css (Footer hover) + */ @apply rounded-sm bg-neutral-100 text-neutral-900 From b5ae8097eba7002d17f8f2613d809c49d32c986f Mon Sep 17 00:00:00 2001 From: Mohit5Upadhyay Date: Sat, 26 Jul 2025 21:11:07 +0530 Subject: [PATCH 3/3] chore: added refrence for hover effect synced with other files --- .../src/Containers/Sidebar/SidebarItem/index.module.css | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/packages/ui-components/src/Containers/Sidebar/SidebarItem/index.module.css b/packages/ui-components/src/Containers/Sidebar/SidebarItem/index.module.css index 7c01fec7205c3..9bdefab3df91c 100644 --- a/packages/ui-components/src/Containers/Sidebar/SidebarItem/index.module.css +++ b/packages/ui-components/src/Containers/Sidebar/SidebarItem/index.module.css @@ -16,12 +16,7 @@ &:hover { &:not(.progression) .label { - /* - This ensures a consistent hover effect across the website in dark mode (bg-neutral-900) and light mode (bg-neutral-100). - See: - - src/Containers/NavBar/index.module.css (Navbar hover) - - src/Containers/NavBar/NavItem/index.module.css (Footer hover) - */ + /* @see https://github.com/nodejs/nodejs.org/blob/main/packages/ui-components/src/Containers/NavBar/NavItem/index.module.css#L24 */ @apply rounded-sm bg-neutral-100 text-neutral-900