From 674b974e2275758e055fa4af8cd0219528bc82f2 Mon Sep 17 00:00:00 2001 From: Timo Tijhof Date: Mon, 18 Aug 2025 21:21:42 +0100 Subject: [PATCH] fix(blog): Fix homepage link in RSS feed When following the Node.js Blog at https://nodejs.org/en/blog in a feed reader like NetNewsWire, the homepage link gets broken. Instead of navigating the browser to the website, one gets a blank page and an unexpected RSS feed download in the background. The `` tag in RSS 2.0 is for the HTML website. Note that the "self" link from the RSS file back to itself is separate form this and already auto-generated by the Feed class. [1] While at it, fix the broken `undefined` element. This is often left empty and fine not to pass in `/apps/site/site.json`. However, the upstream Feed class has a bug where it takes the undefined and outputs the string "undefined" as the blog's description instead of a sensible default like empty string. [1]: https://github.com/jpmonette/feed Signed-off-by: Timo Tijhof --- .../site/next-data/generators/__tests__/websiteFeeds.test.mjs | 4 ++-- apps/site/next-data/generators/websiteFeeds.mjs | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/apps/site/next-data/generators/__tests__/websiteFeeds.test.mjs b/apps/site/next-data/generators/__tests__/websiteFeeds.test.mjs index 29de591c4b639..0619ab4b00b5b 100644 --- a/apps/site/next-data/generators/__tests__/websiteFeeds.test.mjs +++ b/apps/site/next-data/generators/__tests__/websiteFeeds.test.mjs @@ -30,8 +30,8 @@ describe('generateWebsiteFeeds', () => { id: siteConfig.rssFeeds[0].file, title: siteConfig.rssFeeds[0].title, language: 'en', - link: `${base}/feed/${siteConfig.rssFeeds[0].file}`, - description: siteConfig.rssFeeds[0].description, + link: base, + description: siteConfig.rssFeeds[0].description || '', }); const date = new Date(blogData.posts[0].date); diff --git a/apps/site/next-data/generators/websiteFeeds.mjs b/apps/site/next-data/generators/websiteFeeds.mjs index 2b00744704be1..c0f9bd47c7f64 100644 --- a/apps/site/next-data/generators/websiteFeeds.mjs +++ b/apps/site/next-data/generators/websiteFeeds.mjs @@ -32,8 +32,8 @@ const generateWebsiteFeeds = ({ posts }) => { id: file, title: title, language: 'en', - link: `${canonicalUrl}/feed/${file}`, - description: description, + link: canonicalUrl, + description: description || '', }); const blogFeedEntries = posts