From af6f24983e3d6bef2483bbdd5e27b704c8270f4f Mon Sep 17 00:00:00 2001 From: Aviv Keller Date: Mon, 29 Sep 2025 16:05:44 -0400 Subject: [PATCH 01/11] Create 2025-09-29.md --- meetings/2025-09-29.md | 100 +++++++++++++++++++++++++++++++++++++++++ 1 file changed, 100 insertions(+) create mode 100644 meetings/2025-09-29.md diff --git a/meetings/2025-09-29.md b/meetings/2025-09-29.md new file mode 100644 index 0000000..6ed3d60 --- /dev/null +++ b/meetings/2025-09-29.md @@ -0,0 +1,100 @@ +# Node.js Web Team Meeting 2025-09-29 + +## Links + +* **GitHub Issue**: https://github.com/nodejs/web-team/issues/43 + +## Present + +* Aviv Keller @avivkeller +* Claudio Wunder @ovflowd +* Alex Bit @alexbit-codemod (Guest, Userland Migrations) +* Dario Piotrowicz @dario-priotrowicz +* Matt Cowley @MattIPv4 +* Rene @Renegade334 (Guest, TypeScript) +* Jake Bailey @jakebailey (Guest, TypeScript) +* Brian Muenzenmeyer @bnuenzenmeyer +* Bruno Rodriguez (Guest, Userland Migrations) + +## Agenda + +* Extracted from **web-agenda** labelled issues and pull requests from the **nodejs org** prior to the meeting. + + +### nodejs/nodejs.org + +* content(`userland-migration`): make up to date [#8053](https://github.com/nodejs/nodejs.org/pull/8053) + * Alex, Codemod explanation. Codemods are only used when they are officially endorsed + * Alex, plan: + * "Userland Migrations" blog cat + * Migration guides + * Changelogs + * See other frameworks, like React, for inspiration + * "Userland Migrations" learn + * What is a codemod? + * Basic description + * **Not for migration guides** + * Use Docs banner for migration guides + * Claudio, Migrations don't need to go in Learn, it's for concepts, not "things" + * Leave things light, people can use MDN for specifics + * Release/Other blog posts are the ideal place for these + * (Aviv +1) + * It's important to understand that certain blog posts must come from a certain team, that's not entirely in the website team's control. Perhaps get in touch with Releasers and/or Marketing. + * Brian, can we add banners _after_ the fact, since Codemod's take time to develop + * Claudio, true, Codemod's won't be instantly ready, we'd need to change the banner dynamically. + +### nodejs/doc-kit + +* Generate Type Declarations [#437](https://github.com/nodejs/doc-kit/issues/437) + * Brian, why doesn't Node.js ship it's own types + * Claudio, no runtime does, each provides out-of-house + * It's hard for the system to know _which_ version of Node.js you are using, and thus, another package is ideal + * It's hard to identify _where_ the types are + * Jake, if it were bundled, we (Node.js) would be respnsosible for a lot of compat we aren't expert in + * Current issues: + * "Goofy" types for cross-compat with the DOM + * Too many manual changes + * The script doesn't really use the docs *super* offten + * Claudio, we would like to reduce the manual work + * New engine (`doc-kit`) can infer interfaces + * Aviv, while making `doc-kit`, we noticed many issues with the current Structure + * Rene, the source is _human_ readable, but not very _machine_ readable + * Current tooling can't do multiple types in a single Array, i.e. `buffer.Blob` + * It's hard to interop with the Web API + * Making it machine readable it's fruitful, since it'll still need changes in TypeScript + * Documentation isn't the primary focus of code review + * If the docs were strongly-typed, it would help, but it would make them extremely rigid. + * Claudio, this is something we can and should change + * Jake, types are also generic, when, it reality, they are different in various TypeScript versions. + * In TS's DOM Lib, the raw spec is taken, converted to types, and patches are applied on top. + * Brian, even if we don't make it perfect and hands-off, we can make it better + * Aviv, we should bring these types to the collaborators, and work to make the docs rigid + * Rene, unless there is a shift in code review, that'll always be a problem + * We could, however, build better types in the markdown + * Claudio, we have AST in our new generator to create very precise JSON + * We can make this format entirely our own, as consumable and reliable as possible + * It's worth it to make the DX high and the pain low + * Claudio, DefinetelyTyped can import `doc-kit` for their parsing + * Aviv, we can add a generator to put it in a format best of them + * Claudio, we can lint the docs to make their types compatible + * Rene, we can leverage this, but garbage in -> garabage out + * It'll cause an awful lot of upstream changes + * Aviv's PR to use the same list format was an example of something that helped standardize + * The primary objective is to make the docs readable for DT maintainers + * Claudio, if you (Rene + Jake) can look over the codebase, and find what stands out, and what is needed, now is the best time to make changes + * We appreciate DTS, and we wan't to give back + * We have the ability to do so much + * We do need to, however, change the status quo on the docs + * + +### nodejs/web-team + +* Create Means for Private Communications [#14](https://github.com/nodejs/web-team/issues/14) + + * Skipped as we ran out of time + +## Upcoming Meetings + +* **Node.js Project Calendar**: + +Click `+GoogleCalendar` at the bottom right to add to your own Google calendar. From 21b3a0e0d55e9de7ded5fcf551636c87e1992bd1 Mon Sep 17 00:00:00 2001 From: Aviv Keller Date: Mon, 29 Sep 2025 16:06:44 -0400 Subject: [PATCH 02/11] Update 2025-09-29.md --- meetings/2025-09-29.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/meetings/2025-09-29.md b/meetings/2025-09-29.md index 6ed3d60..9d54981 100644 --- a/meetings/2025-09-29.md +++ b/meetings/2025-09-29.md @@ -13,8 +13,8 @@ * Matt Cowley @MattIPv4 * Rene @Renegade334 (Guest, TypeScript) * Jake Bailey @jakebailey (Guest, TypeScript) -* Brian Muenzenmeyer @bnuenzenmeyer -* Bruno Rodriguez (Guest, Userland Migrations) +* Brian Muenzenmeyer @bmuenzenmeyer +* Bruno Rodriguez @brunocroh (Guest, Userland Migrations) ## Agenda From 50ff788c2cad9491b7fcdc5f453bd774153418ae Mon Sep 17 00:00:00 2001 From: Aviv Keller Date: Mon, 29 Sep 2025 16:07:40 -0400 Subject: [PATCH 03/11] Apply suggestion from @Copilot Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> --- meetings/2025-09-29.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/meetings/2025-09-29.md b/meetings/2025-09-29.md index 9d54981..56f6ee4 100644 --- a/meetings/2025-09-29.md +++ b/meetings/2025-09-29.md @@ -9,7 +9,7 @@ * Aviv Keller @avivkeller * Claudio Wunder @ovflowd * Alex Bit @alexbit-codemod (Guest, Userland Migrations) -* Dario Piotrowicz @dario-priotrowicz +* Dario Piotrowicz @dario-piotrowicz * Matt Cowley @MattIPv4 * Rene @Renegade334 (Guest, TypeScript) * Jake Bailey @jakebailey (Guest, TypeScript) From 7d742388bdb7fb39204784d4e165323167c84590 Mon Sep 17 00:00:00 2001 From: Aviv Keller Date: Mon, 29 Sep 2025 16:07:48 -0400 Subject: [PATCH 04/11] Apply suggestion from @Copilot Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> --- meetings/2025-09-29.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/meetings/2025-09-29.md b/meetings/2025-09-29.md index 56f6ee4..7b9a693 100644 --- a/meetings/2025-09-29.md +++ b/meetings/2025-09-29.md @@ -50,7 +50,7 @@ * Claudio, no runtime does, each provides out-of-house * It's hard for the system to know _which_ version of Node.js you are using, and thus, another package is ideal * It's hard to identify _where_ the types are - * Jake, if it were bundled, we (Node.js) would be respnsosible for a lot of compat we aren't expert in + * Jake, if it were bundled, we (Node.js) would be responsible for a lot of compat we aren't expert in * Current issues: * "Goofy" types for cross-compat with the DOM * Too many manual changes From 43ea6757ed910ab274ad6f6fd11098825cde7e7a Mon Sep 17 00:00:00 2001 From: Aviv Keller Date: Mon, 29 Sep 2025 16:07:55 -0400 Subject: [PATCH 05/11] Apply suggestion from @Copilot Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> --- meetings/2025-09-29.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/meetings/2025-09-29.md b/meetings/2025-09-29.md index 7b9a693..39baef4 100644 --- a/meetings/2025-09-29.md +++ b/meetings/2025-09-29.md @@ -54,7 +54,7 @@ * Current issues: * "Goofy" types for cross-compat with the DOM * Too many manual changes - * The script doesn't really use the docs *super* offten + * The script doesn't really use the docs *super* often * Claudio, we would like to reduce the manual work * New engine (`doc-kit`) can infer interfaces * Aviv, while making `doc-kit`, we noticed many issues with the current Structure From 778dd0ec4affa7bfc10f8d603e7371fdb2904a6c Mon Sep 17 00:00:00 2001 From: Aviv Keller Date: Mon, 29 Sep 2025 16:08:03 -0400 Subject: [PATCH 06/11] Apply suggestion from @Copilot Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> --- meetings/2025-09-29.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/meetings/2025-09-29.md b/meetings/2025-09-29.md index 39baef4..72104fc 100644 --- a/meetings/2025-09-29.md +++ b/meetings/2025-09-29.md @@ -74,7 +74,7 @@ * Claudio, we have AST in our new generator to create very precise JSON * We can make this format entirely our own, as consumable and reliable as possible * It's worth it to make the DX high and the pain low - * Claudio, DefinetelyTyped can import `doc-kit` for their parsing + * Claudio, DefinitelyTyped can import `doc-kit` for their parsing * Aviv, we can add a generator to put it in a format best of them * Claudio, we can lint the docs to make their types compatible * Rene, we can leverage this, but garbage in -> garabage out From 6fb35cb5488fb44a4094d3ceb2bcf4ff3e61a51f Mon Sep 17 00:00:00 2001 From: Aviv Keller Date: Mon, 29 Sep 2025 16:08:09 -0400 Subject: [PATCH 07/11] Apply suggestion from @Copilot Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> --- meetings/2025-09-29.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/meetings/2025-09-29.md b/meetings/2025-09-29.md index 72104fc..467c63a 100644 --- a/meetings/2025-09-29.md +++ b/meetings/2025-09-29.md @@ -77,7 +77,7 @@ * Claudio, DefinitelyTyped can import `doc-kit` for their parsing * Aviv, we can add a generator to put it in a format best of them * Claudio, we can lint the docs to make their types compatible - * Rene, we can leverage this, but garbage in -> garabage out + * Rene, we can leverage this, but garbage in -> garbage out * It'll cause an awful lot of upstream changes * Aviv's PR to use the same list format was an example of something that helped standardize * The primary objective is to make the docs readable for DT maintainers From 271f921ccda04aa69819a404f6317b979121ff6f Mon Sep 17 00:00:00 2001 From: Aviv Keller Date: Mon, 29 Sep 2025 16:08:15 -0400 Subject: [PATCH 08/11] Apply suggestion from @Copilot Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> --- meetings/2025-09-29.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/meetings/2025-09-29.md b/meetings/2025-09-29.md index 467c63a..7af689c 100644 --- a/meetings/2025-09-29.md +++ b/meetings/2025-09-29.md @@ -82,7 +82,7 @@ * Aviv's PR to use the same list format was an example of something that helped standardize * The primary objective is to make the docs readable for DT maintainers * Claudio, if you (Rene + Jake) can look over the codebase, and find what stands out, and what is needed, now is the best time to make changes - * We appreciate DTS, and we wan't to give back + * We appreciate DTS, and we want to give back * We have the ability to do so much * We do need to, however, change the status quo on the docs * From 51df74cf6cd557b043edb658acaed09183560da9 Mon Sep 17 00:00:00 2001 From: Aviv Keller Date: Mon, 29 Sep 2025 16:08:21 -0400 Subject: [PATCH 09/11] Apply suggestion from @Copilot Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> --- meetings/2025-09-29.md | 1 - 1 file changed, 1 deletion(-) diff --git a/meetings/2025-09-29.md b/meetings/2025-09-29.md index 7af689c..521b905 100644 --- a/meetings/2025-09-29.md +++ b/meetings/2025-09-29.md @@ -85,7 +85,6 @@ * We appreciate DTS, and we want to give back * We have the ability to do so much * We do need to, however, change the status quo on the docs - * ### nodejs/web-team From 481d4632938e1c963ae05aac70a216415ed07ebe Mon Sep 17 00:00:00 2001 From: Aviv Keller Date: Mon, 29 Sep 2025 16:10:14 -0400 Subject: [PATCH 10/11] Update meetings/2025-09-29.md Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> --- meetings/2025-09-29.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/meetings/2025-09-29.md b/meetings/2025-09-29.md index 521b905..d5cf57a 100644 --- a/meetings/2025-09-29.md +++ b/meetings/2025-09-29.md @@ -46,7 +46,7 @@ ### nodejs/doc-kit * Generate Type Declarations [#437](https://github.com/nodejs/doc-kit/issues/437) - * Brian, why doesn't Node.js ship it's own types + * Brian, why doesn't Node.js ship its own types * Claudio, no runtime does, each provides out-of-house * It's hard for the system to know _which_ version of Node.js you are using, and thus, another package is ideal * It's hard to identify _where_ the types are From 4aae6ed0ff4c8e0b2f16f67056174ce8901267f0 Mon Sep 17 00:00:00 2001 From: Aviv Keller Date: Mon, 29 Sep 2025 16:10:20 -0400 Subject: [PATCH 11/11] Update meetings/2025-09-29.md Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> --- meetings/2025-09-29.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/meetings/2025-09-29.md b/meetings/2025-09-29.md index d5cf57a..5cc9473 100644 --- a/meetings/2025-09-29.md +++ b/meetings/2025-09-29.md @@ -65,7 +65,7 @@ * Documentation isn't the primary focus of code review * If the docs were strongly-typed, it would help, but it would make them extremely rigid. * Claudio, this is something we can and should change - * Jake, types are also generic, when, it reality, they are different in various TypeScript versions. + * Jake, types are also generic, when, in reality, they are different in various TypeScript versions. * In TS's DOM Lib, the raw spec is taken, converted to types, and patches are applied on top. * Brian, even if we don't make it perfect and hands-off, we can make it better * Aviv, we should bring these types to the collaborators, and work to make the docs rigid