Skip to content

No error displayed when patch matches existing bytes #30

@A1mDev

Description

@A1mDev

Description:
Currently, the extension does not display any warning or error if the patch bytes are identical to the bytes already present in the binary.
This can mislead users into thinking a patch was applied when in fact nothing changed.

Additionally, this situation can occur if another plugin has already applied a similar patch. In such cases:

  • The patch may conflict with the existing one.

  • No errors or warnings are displayed.

  • The patch might not be removed correctly during unpatching.

Steps to reproduce:

  1. Apply a patch through another plugin or extension that modifies the same memory bytes.

  2. Load this extension and apply a patch with the same bytes.

  3. Observe that no error or warning is logged, and the patch may not behave as expected.

Expected behavior:

  • The extension should detect that the patch has no effect or conflicts with existing patches and log a warning or informational message.

  • Conflicting patches should be handled safely, and unpatching should restore memory correctly.

Additional context / suggestion:

  • Consider adding a check in Enable() or during parsing to compare vecPatch with the current memory bytes.

  • Log clear messages to help users troubleshoot patch conflicts.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions