-
Notifications
You must be signed in to change notification settings - Fork 302
Open
Labels
enhancementNew feature or requestNew feature or request
Description
Right now, when generating a release notes PR, if an included PR isn't labelled with notes:ready, we don't include the release notes at all. This means that for such PRs, the person writing the release notes has to manually copy the release notes from that PR.
I believe that most of the time, the absence of the notes:ready label just means that the PR author forgot to add the label. In any case, I think it's best if we included the PR's "Release Notes Summary" section in the generated release notes anyway. If the person writing the release notes doesn't like it, they can easily delete it.
This is the bit we need to touch. Easy peasy
nu_scripts/make_release/notes/generate.nu
Lines 29 to 34 in c0eef9b
| mut notes = if "## Release notes summary" in $pr.body { | |
| $pr.body | extract-notes | |
| } else if $has_ready_label { | |
| # If no release notes summary exists but ready label is set, treat as empty | |
| $pr = $pr | add-notice warning "no release notes section but notes:ready label" | |
| "" |
Metadata
Metadata
Assignees
Labels
enhancementNew feature or requestNew feature or request