Skip to content

Commit 156adf4

Browse files
authored
CUST-4675 added 'Skype for Consumer' and 'Skype for Business' to conferencing providers. (#294)
The SDK was failing to validate the responses due to these missing in the ConferencingProvider model. # License <!-- Your PR comment must contain the following line for us to merge the PR. --> I confirm that this contribution is made under the terms of the MIT license and that I have the authority necessary to make this contribution on behalf of its copyright owner.
1 parent 5ccd0b7 commit 156adf4

File tree

4 files changed

+16
-0
lines changed

4 files changed

+16
-0
lines changed

CHANGELOG.md

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,11 @@
11
# Nylas Java SDK Changelog
22

3+
## [Unreleased]
4+
5+
### Added
6+
* `Skype for Consumer` as a conferencing provider to ConferencingProvider
7+
* `Skype for Business` as a conferencing provider to ConferencingProvider
8+
39
## [2.13.0]
410

511
### Added

src/main/kotlin/com/nylas/models/ConferencingProvider.kt

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,12 @@ enum class ConferencingProvider {
2121
@Json(name = "Zoom Meeting")
2222
ZOOM_MEETING,
2323

24+
@Json(name = "Skype for Consumer")
25+
SKYPE_FOR_CONSUMER,
26+
27+
@Json(name = "Skype for Business")
28+
SKYPE_FOR_BUSINESS,
29+
2430
@Json(name = "unknown")
2531
UNKNOWN,
2632
}

src/main/kotlin/com/nylas/models/CreateEventRequest.kt

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -395,6 +395,8 @@ data class CreateEventRequest(
395395
ConferencingProvider.MICROSOFT_TEAMS -> CreateEventManualConferencingProvider.MICROSOFT_TEAMS
396396
ConferencingProvider.GOTOMEETING -> throw IllegalArgumentException("GoToMeeting is not supported in CreateEventManualConferencingProvider. Use the new enum directly.")
397397
ConferencingProvider.WEBEX -> throw IllegalArgumentException("WebEx is not supported in CreateEventManualConferencingProvider. Use the new enum directly.")
398+
ConferencingProvider.SKYPE_FOR_CONSUMER -> throw IllegalArgumentException("Skype for Consumer is not supported in CreateEventManualConferencingProvider. Use the new enum directly.")
399+
ConferencingProvider.SKYPE_FOR_BUSINESS -> throw IllegalArgumentException("Skype for Business is not supported in CreateEventManualConferencingProvider. Use the new enum directly.")
398400
ConferencingProvider.UNKNOWN -> throw IllegalArgumentException("Unknown provider is not supported for event creation. Use CreateEventManualConferencingProvider instead.")
399401
}
400402
return Details(newProvider, details)

src/main/kotlin/com/nylas/models/UpdateEventRequest.kt

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -457,6 +457,8 @@ data class UpdateEventRequest(
457457
ConferencingProvider.MICROSOFT_TEAMS -> UpdateEventManualConferencingProvider.MICROSOFT_TEAMS
458458
ConferencingProvider.GOTOMEETING -> throw IllegalArgumentException("GoToMeeting is not supported in UpdateEventManualConferencingProvider. Use the new enum directly.")
459459
ConferencingProvider.WEBEX -> throw IllegalArgumentException("WebEx is not supported in UpdateEventManualConferencingProvider. Use the new enum directly.")
460+
ConferencingProvider.SKYPE_FOR_CONSUMER -> throw IllegalArgumentException("Skype for Consumer is not supported in UpdateEventManualConferencingProvider. Use the new enum directly.")
461+
ConferencingProvider.SKYPE_FOR_BUSINESS -> throw IllegalArgumentException("Skype for Business is not supported in UpdateEventManualConferencingProvider. Use the new enum directly.")
460462
ConferencingProvider.UNKNOWN -> throw IllegalArgumentException("Unknown provider is not supported for event updates. Use UpdateEventManualConferencingProvider instead.")
461463
}
462464
return Details(newProvider, details)

0 commit comments

Comments
 (0)