`events.list` produces an invalid request URL

[leebenson]

Describe the bug

Attempting to retrieve events as a list throws "Unrecognized request URL".

{
  "error": {
    "message": "Failed to fetch events",
    "details": "Unrecognized request URL (GET: /v3/grants/<grantId>/events%3Fcalendar_id=primary). Please see https://developer.nylas.com/docs/api/v3/ecc/ or we can help at https://support.nylas.com/."
  }
}

I suspect it's the %3F encoding in place of a ? query string separator.

To Reproduce

const queryParams: ListEventQueryParams = { calendarId };

await nylas.events.list({
  identifier: grantId,
  queryParams,
});

Where calendarId and grantId are appropriately defined.

Expected behavior

Only queryParams values should be URL-encoded, and not the path prefix itself.

SDK Version:
7.13.1

Additional context

Downgrading to 7.11.0 throws a different error:

{
  "error": {
    "message": "Failed to fetch events",
    "details": "Invalid response body while trying to fetch https://api.us.nylas.com/v3/grants/<grantId>/events?calendar_id=primary: incorrect header check"
  }
}

But note ? is correctly unencoded in this case.

[AaronDDM]

Apologies for the delay. Still investigating this issue, will likely have sometime next week.

[AaronDDM]

Hey @leebenson - I am having a hard time replicating this issue. Here is what I have for my cloudflare deployment setup

I am trying out the edge-environment example from this repository, but I added a route for getting events:

    // Handle simple events list request
    if (request.method === 'GET' && url.pathname === '/events') {
      const nylas = new Nylas({
        apiKey: env.NYLAS_API_KEY,
        apiUri: env.NYLAS_API_URI || 'https://api.us.nylas.com',
      });

      const events = await nylas.events.list({
        identifier: env.NYLAS_GRANT_ID,
        queryParams: {
          calendarId: 'primary',
        },
      });

      return new Response(JSON.stringify({ events: events.data }), {
        headers: { 'Content-Type': 'application/json', ...corsHeaders },
      });
    }

I am not having any issues retrieving events. Any additional information you could provide?

[leebenson]

I'm using the Cloudflare Vite plugin locally. I wonder if that's introducing anything distinct.

I'll try to narrow this down further and get a minimal repro hosted.

[leebenson]

@AaronDDM, just an FYI that your working branch @ #680 fixed the issue. It seems that maybe the custom fetch wrapper was the culprit.