Merge branch 'release/1.2.8' into v1

Author: khalwat

CHANGELOG.md

@@ -1,5 +1,9 @@
 # Transcoder Changelog
 
+## 1.2.8 - 2019.11.12
+### Changed
+* Fixed more issues with the `synchronous` option
+
 ## 1.2.7 - 2019.11.12
 ### Changed
 * Fixed issues with the `synchronous` and `stripMetadata` options

composer.json

@@ -2,7 +2,7 @@
     "name": "nystudio107/craft-transcoder",
     "description": "Transcode video & audio files to various formats, and provide video thumbnails",
     "type": "craft-plugin",
-    "version": "1.2.7",
+    "version": "1.2.8",
     "keywords": [
         "craft",
         "cms",

src/services/Transcode.php

@@ -425,7 +425,7 @@ public function getAudioUrl($filePath, $audioOptions): string
                 $result = Craft::getAlias($url).$destAudioFile;
             } else {
                 // Kick off the transcoding
-                $this->executeShellCommand($ffmpegCmd);
+                $pid = $this->executeShellCommand($ffmpegCmd);
 
                 if ($synchronous) {
                     Craft::info($ffmpegCmd, __METHOD__);