Move settings from the composer.json “extra” to the plugin main class

Signed-off-by: Andrew Welch <andrew@nystudio107.com>

Author: khalwat

composer.json

@@ -40,13 +40,7 @@
     "extra": {
         "name": "Transcoder",
         "handle": "transcoder",
-        "schemaVersion": "1.0.0",
-        "hasCpSettings": false,
-        "hasCpSection": false,
         "changelogUrl": "https://raw.githubusercontent.com/nystudio107/craft-transcoder/v1/CHANGELOG.md",
-        "components": {
-            "transcode": "nystudio107\\transcoder\\services\\Transcode"
-        },
         "class": "nystudio107\\transcoder\\Transcoder"
     }
 }

src/Transcoder.php

@@ -64,6 +64,46 @@ class Transcoder extends Plugin
      */
     public static $settings;
 
+    // Static Methods
+    // =========================================================================
+
+    /**
+     * @inheritdoc
+     */
+    public function __construct($id, $parent = null, array $config = [])
+    {
+        $config['components'] = [
+            'transcode' => Transcode::class,
+            // Register the manifest service
+            'manifest' => [
+                'class' => ManifestService::class,
+                'assetClass' => TranscoderAsset::class,
+                'devServerManifestPath' => 'http://craft-transcoder-buildchain:8080/',
+                'devServerPublicPath' => 'http://craft-transcoder-buildchain:8080/',
+            ],
+        ];
+
+        parent::__construct($id, $parent, $config);
+    }
+
+    // Public Properties
+    // =========================================================================
+
+    /**
+     * @var string
+     */
+    public $schemaVersion = '1.0.0';
+
+    /**
+     * @var bool
+     */
+    public $hasCpSection = false;
+
+    /**
+     * @var bool
+     */
+    public $hasCpSettings = false;
+    
     // Public Methods
     // =========================================================================
 
@@ -137,14 +177,6 @@ protected function createSettingsModel()
      */
     protected function addComponents()
     {
-        // Register the manifest service
-        $this->set('manifest', [
-            'class' => ManifestService::class,
-            'assetClass' => TranscoderAsset::class,
-            'devServerManifestPath' => 'http://craft-transcoder-buildchain:8080/',
-            'devServerPublicPath' => 'http://craft-transcoder-buildchain:8080/',
-        ]);
-
         // Register our variables
         Event::on(
             CraftVariable::class,
@@ -250,8 +282,6 @@ function (RegisterUrlRulesEvent $event) {
     protected function customFrontendRoutes(): array
     {
         return [
-            // Make webpack async bundle loading work out of published AssetBundles
-            '/cpresources/transcoder/<resourceType:{handle}>/<fileName>' => 'transcoder/manifest/resource',
         ];
     }
 }