Skip to content

Commit 2632eab

Browse files
authored
Remove unnecessary quotes from _type_checking imported type hints (#744)
1 parent 7b1dc49 commit 2632eab

File tree

5 files changed

+20
-20
lines changed

5 files changed

+20
-20
lines changed

jsonargparse/_actions.py

Lines changed: 11 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,7 @@ def _is_branch_key(parser, key: str) -> bool:
4646

4747

4848
def _find_action_and_subcommand(
49-
parser: Union["ArgumentParser", "ActionsContainer"],
49+
parser: Union[ArgumentParser, ActionsContainer],
5050
dest: str,
5151
exclude: Optional[Union[Type[ArgparseAction], Tuple[Type[ArgparseAction], ...]]] = None,
5252
) -> Tuple[Optional[ArgparseAction], Optional[str]]:
@@ -83,15 +83,15 @@ def _find_action_and_subcommand(
8383

8484

8585
def _find_action(
86-
parser: Union["ArgumentParser", "ActionsContainer"],
86+
parser: Union[ArgumentParser, ActionsContainer],
8787
dest: str,
8888
exclude: Optional[Union[Type[ArgparseAction], Tuple[Type[ArgparseAction], ...]]] = None,
8989
) -> Optional[ArgparseAction]:
9090
return _find_action_and_subcommand(parser, dest, exclude=exclude)[0]
9191

9292

9393
def _find_parent_action_and_subcommand(
94-
parser: "ArgumentParser",
94+
parser: ArgumentParser,
9595
key: str,
9696
exclude: Optional[Union[Type[ArgparseAction], Tuple[Type[ArgparseAction], ...]]] = None,
9797
) -> Tuple[Optional[ArgparseAction], Optional[str]]:
@@ -106,7 +106,7 @@ def _find_parent_action_and_subcommand(
106106

107107

108108
def _find_parent_action(
109-
parser: "ArgumentParser",
109+
parser: ArgumentParser,
110110
key: str,
111111
exclude: Optional[Union[Type[ArgparseAction], Tuple[Type[ArgparseAction], ...]]] = None,
112112
) -> Optional[ArgparseAction]:
@@ -516,7 +516,7 @@ class ActionParser:
516516

517517
def __init__(
518518
self,
519-
parser: Optional["ArgumentParser"] = None,
519+
parser: Optional[ArgumentParser] = None,
520520
):
521521
"""Initializer for ActionParser instance.
522522
@@ -616,7 +616,7 @@ def parent_parsers_context(key, parser):
616616
class _ActionSubCommands(_SubParsersAction):
617617
"""Extension of argparse._SubParsersAction to modify subcommands functionality."""
618618

619-
parent_parser: "ArgumentParser"
619+
parent_parser: ArgumentParser
620620
env_prefix: str
621621

622622
def add_parser(self, name, **kwargs):
@@ -692,11 +692,11 @@ def not_single_subcommand():
692692

693693
@staticmethod
694694
def get_subcommands(
695-
parser: "ArgumentParser",
695+
parser: ArgumentParser,
696696
cfg: Namespace,
697697
prefix: str = "",
698698
fail_no_subcommand: bool = True,
699-
) -> Tuple[Optional[List[str]], Optional[List["ArgumentParser"]]]:
699+
) -> Tuple[Optional[List[str]], Optional[List[ArgumentParser]]]:
700700
"""Returns subcommand names and corresponding subparsers."""
701701
if parser._subcommands_action is None:
702702
return None, None
@@ -748,11 +748,11 @@ def get_subcommands(
748748

749749
@staticmethod
750750
def get_subcommand(
751-
parser: "ArgumentParser",
751+
parser: ArgumentParser,
752752
cfg: Namespace,
753753
prefix: str = "",
754754
fail_no_subcommand: bool = True,
755-
) -> Tuple[Optional[str], Optional["ArgumentParser"]]:
755+
) -> Tuple[Optional[str], Optional[ArgumentParser]]:
756756
"""Returns a single subcommand name and corresponding subparser."""
757757
subcommands, subparsers = _ActionSubCommands.get_subcommands(
758758
parser,
@@ -764,7 +764,7 @@ def get_subcommand(
764764

765765
@staticmethod
766766
def handle_subcommands(
767-
parser: "ArgumentParser",
767+
parser: ArgumentParser,
768768
cfg: Namespace,
769769
env: Optional[bool],
770770
defaults: bool,

jsonargparse/_deprecated.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -524,7 +524,7 @@ class DebugException(Exception):
524524
this function.
525525
"""
526526
)
527-
def usage_and_exit_error_handler(parser: "ArgumentParser", message: str) -> None:
527+
def usage_and_exit_error_handler(parser: ArgumentParser, message: str) -> None:
528528
"""Prints the usage and exits with error code 2 (same behavior as argparse).
529529
530530
Args:

jsonargparse/_formatters.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -242,7 +242,7 @@ def set_comments(cfg, prefix="", depth=0):
242242
def set_yaml_start_comment(
243243
self,
244244
text: str,
245-
cfg: "ruyamlCommentedMap",
245+
cfg: ruyamlCommentedMap,
246246
):
247247
"""Sets the start comment to a ruyaml object.
248248
@@ -255,7 +255,7 @@ def set_yaml_start_comment(
255255
def set_yaml_group_comment(
256256
self,
257257
text: str,
258-
cfg: "ruyamlCommentedMap",
258+
cfg: ruyamlCommentedMap,
259259
key: str,
260260
depth: int,
261261
):
@@ -272,7 +272,7 @@ def set_yaml_group_comment(
272272
def set_yaml_argument_comment(
273273
self,
274274
text: str,
275-
cfg: "ruyamlCommentedMap",
275+
cfg: ruyamlCommentedMap,
276276
key: str,
277277
depth: int,
278278
):

jsonargparse/_link_arguments.py

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@
2626

2727

2828
def find_parent_or_child_actions(
29-
parser: "ArgumentParser",
29+
parser: ArgumentParser,
3030
key: str,
3131
exclude: Optional[Union[Type[ArgparseAction], Tuple[Type[ArgparseAction], ...]]] = None,
3232
) -> Optional[List[ArgparseAction]]:
@@ -44,7 +44,7 @@ def find_parent_or_child_actions(
4444

4545

4646
def find_subclass_action_or_class_group(
47-
parser: "ArgumentParser",
47+
parser: ArgumentParser,
4848
key: str,
4949
exclude: Optional[Union[Type[ArgparseAction], Tuple[Type[ArgparseAction], ...]]] = None,
5050
) -> Optional[Union[ArgparseAction, "ArgumentGroup"]]:
@@ -271,7 +271,7 @@ def call_compute_fn(self, args):
271271
raise ValueError(f"Call to compute_fn of link '{link}' with args ({args}) failed: {ex}") from ex
272272

273273
@staticmethod
274-
def apply_parsing_links(parser: "ArgumentParser", cfg: Namespace) -> None:
274+
def apply_parsing_links(parser: ArgumentParser, cfg: Namespace) -> None:
275275
if apply_config_skip.get() or _ActionPrintConfig.is_print_config_requested(parser):
276276
return
277277

@@ -473,7 +473,7 @@ def del_target_key(target_key):
473473
ActionLink.strip_link_target_keys(subparsers[num], cfg[subcommand])
474474

475475

476-
def get_link_actions(parser: "ArgumentParser", apply_on: str, skip=set()) -> List[ActionLink]:
476+
def get_link_actions(parser: ArgumentParser, apply_on: str, skip=set()) -> List[ActionLink]:
477477
if not hasattr(parser, "_links_group"):
478478
return []
479479
return [a for a in parser._links_group._group_actions if a.apply_on == apply_on and a not in skip]

jsonargparse/_loaders_dumpers.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -269,7 +269,7 @@ def check_valid_dump_format(dump_format: str):
269269
raise ValueError(f'Unknown output format "{dump_format}".')
270270

271271

272-
def dump_using_format(parser: "ArgumentParser", data: dict, dump_format: str) -> str:
272+
def dump_using_format(parser: ArgumentParser, data: dict, dump_format: str) -> str:
273273
if dump_format == "parser_mode":
274274
dump_format = parser.parser_mode if parser.parser_mode in dumpers else "yaml"
275275
args = (data, parser) if dump_format == "yaml_comments" else (data,)

0 commit comments

Comments
 (0)