Skip to content

Commit 5fbb73f

Browse files
authored
Changelog fixes (#750)
1 parent d11582e commit 5fbb73f

File tree

2 files changed

+16
-23
lines changed

2 files changed

+16
-23
lines changed

.github/PULL_REQUEST_TEMPLATE.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,4 +23,4 @@ task is not relevant or leave empty when in doubt.
2323
- [ ] Did you write **unit tests** such that there is 100% coverage on related code? (required for bug fixes and new features)
2424
- [ ] Did you verify that new and existing **tests pass locally**?
2525
- [ ] Did you make sure that all changes preserve **backward compatibility**?
26-
- [ ] Did you update **the CHANGELOG**? (not for typos, docs, test updates, or minor internal changes/refactors)
26+
- [ ] Did you update **the CHANGELOG** with the pull request link? (not for typos, docs, test updates, or minor internal changes/refactors)

CHANGELOG.rst

Lines changed: 15 additions & 22 deletions
Original file line numberDiff line numberDiff line change
@@ -154,7 +154,7 @@ Fixed
154154
<https://github.com/omni-us/jsonargparse/pull/686>`__).
155155
- Help incorrectly showing environment variable name for ``--print_shtab``.
156156
- ``add_argument`` raises error when type is assigned with ``action=None``
157-
(`#687 <https://github.com/omni-us/jsonargparse/issues/687>`__).
157+
(`#687 <https://github.com/omni-us/jsonargparse/pull/687>`__).
158158
- ``shtab`` failing when parser has positional arguments (`#693
159159
<https://github.com/omni-us/jsonargparse/pull/693>`__).
160160

@@ -381,22 +381,17 @@ Added
381381
- Support for ``OrderedDict`` as a type (`#545
382382
<https://github.com/omni-us/jsonargparse/pull/545>`__).
383383
- New function ``get_loader`` to get the current loader for a given parser mode
384-
(`#479 comment
385-
<https://github.com/omni-us/jsonargparse/issues/479#issuecomment-2022596544>`__,
386-
`#536 comment
387-
<https://github.com/omni-us/jsonargparse/issues/536#issuecomment-2186961644>`__).
384+
(`#543 <https://github.com/omni-us/jsonargparse/pull/543>`__).
388385

389386
Fixed
390387
^^^^^
391388
- ``dump`` failing when a link target requires serialization and
392389
``skip_link_targets=False`` (`#542
393390
<https://github.com/omni-us/jsonargparse/pull/542>`__).
394391
- ``default_config_files`` making parse fail for subcommands and nested subclass
395-
types (`lightning-forums#5963
396-
<https://lightning.ai/forums/t/problem-lightningcli-with-default-config-files/5963>`__).
397-
- Fixes related to transformers ``PreTrainedModel.from_pretrained``
398-
(`lightning#19863 comment
399-
<https://github.com/Lightning-AI/pytorch-lightning/discussions/19863#discussioncomment-9821765>`__):
392+
types (`#549 <https://github.com/omni-us/jsonargparse/pull/549>`__).
393+
- Fixes related to transformers ``PreTrainedModel.from_pretrained`` (`#551
394+
<https://github.com/omni-us/jsonargparse/pull/551>`__):
400395

401396
- Import path of inherited classmethod not resolving correctly (`#548
402397
<https://github.com/omni-us/jsonargparse/pull/548>`__).
@@ -426,8 +421,7 @@ Fixed
426421
- Resolving of import paths for some ``torch`` functions not working (`#535
427422
<https://github.com/omni-us/jsonargparse/pull/535>`__).
428423
- ``--print_shtab`` crashing on failure to get signature parameters from one
429-
class (`lightning#10858 comment
430-
<https://github.com/Lightning-AI/pytorch-lightning/discussions/10858#discussioncomment-9846252>`__).
424+
class (`#537 <https://github.com/omni-us/jsonargparse/pull/537>`__).
431425

432426
Changed
433427
^^^^^^^
@@ -452,10 +446,10 @@ Added
452446
Fixed
453447
^^^^^
454448
- Parsing incorrectly provides file content when type is a union with a
455-
subclass, PathLike and string (`#516
456-
<https://github.com/omni-us/jsonargparse/issues/516>`__).
457-
- ``--print_config`` failing in some cases (`#517
458-
<https://github.com/omni-us/jsonargparse/issues/517>`__).
449+
subclass, PathLike and string (`#518
450+
<https://github.com/omni-us/jsonargparse/pull/518>`__).
451+
- ``--print_config`` failing in some cases (`#531
452+
<https://github.com/omni-us/jsonargparse/pull/531>`__).
459453
- Callable that returns class not using required parameter default from lambda
460454
(`#523 <https://github.com/omni-us/jsonargparse/pull/523>`__).
461455
- Failing to parse list of dataclasses with nested optional dataclass (`#527
@@ -464,7 +458,7 @@ Fixed
464458
``python>=3.11`` (`#522
465459
<https://github.com/omni-us/jsonargparse/pull/522>`__).
466460
- Optional pydantic model failing to parse with `__pydantic_private__` error
467-
(`#521 <https://github.com/omni-us/jsonargparse/issues/521>`__).
461+
(`#530 <https://github.com/omni-us/jsonargparse/pull/530>`__).
468462

469463

470464
v4.29.0 (2024-05-24)
@@ -485,15 +479,14 @@ Fixed
485479
``Union`` types (`#498 <https://github.com/omni-us/jsonargparse/pull/498>`__).
486480
- Nested parameters failing to parse from command line when value includes
487481
space (`#499 <https://github.com/omni-us/jsonargparse/pull/499>`__).
488-
- ``format_usage()`` not working (`#501
489-
<https://github.com/omni-us/jsonargparse/issues/501>`__).
482+
- ``format_usage()`` not working (`#502
483+
<https://github.com/omni-us/jsonargparse/pull/502>`__).
490484
- Not able to modify init args for callable with class return and default class
491485
(`#504 <https://github.com/omni-us/jsonargparse/pull/504>`__).
492486
- Nested values not validated when type not subclass and nested keys for
493-
subclass (`#503 comment
494-
<https://github.com/omni-us/jsonargparse/issues/503#issuecomment-2119724341>`__).
487+
subclass (`#506 <https://github.com/omni-us/jsonargparse/pull/506>`__).
495488
- Dataclass with nested optional dataclass and default field factory failing to
496-
parse (`#507 <https://github.com/omni-us/jsonargparse/issues/507>`__).
489+
parse (`#508 <https://github.com/omni-us/jsonargparse/pull/508>`__).
497490

498491
Changed
499492
^^^^^^^

0 commit comments

Comments
 (0)