Skip to content

Commit d291ce0

Browse files
authored
Update contribution instructions (#762)
1 parent 5930317 commit d291ce0

File tree

8 files changed

+99
-31
lines changed

8 files changed

+99
-31
lines changed

.github/ISSUE_TEMPLATE/1-bug.md

Lines changed: 12 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,18 @@ labels: bug
66
assignees: ''
77
---
88

9-
<!-- If you like this project, please ⭐ star it https://github.com/omni-us/jsonargparse/ -->
9+
<!--
10+
Thank you very much for contributing! If you enjoy this project, please consider
11+
giving it a ⭐ star on [GitHub](https://github.com/omni-us/jsonargparse/) or
12+
sponsor it via [GitHub Sponsors](https://github.com/sponsors/mauvilsa). Even the
13+
smallest donation is greatly appreciated and helps support the project.
14+
-->
15+
16+
<!--
17+
Note: If you already understand the bug and know how to resolve it, please
18+
proceed to create a pull request directly. This helps avoid having a redundant
19+
issue.
20+
-->
1021

1122
## 🐛 Bug report
1223

.github/ISSUE_TEMPLATE/2-regression.md

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,11 +6,16 @@ labels: bug
66
assignees: ''
77
---
88

9-
<!-- If you like this project, please ⭐ star it https://github.com/omni-us/jsonargparse/ -->
9+
<!--
10+
Thank you very much for contributing! If you enjoy this project, please consider
11+
giving it a ⭐ star on [GitHub](https://github.com/omni-us/jsonargparse/) or
12+
sponsor it via [GitHub Sponsors](https://github.com/sponsors/mauvilsa). Even the
13+
smallest donation is greatly appreciated and helps support the project.
14+
-->
1015

1116
## 🕰️ Regression report
1217

13-
<!-- A clear and concise description of the regression. -->
18+
<!-- Here write a clear and concise description of the regression. -->
1419

1520
### To reproduce
1621

.github/ISSUE_TEMPLATE/3-documentation.md

Lines changed: 12 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -6,11 +6,18 @@ labels: documentation
66
assignees: ''
77
---
88

9-
<!-- If you like this project, please ⭐ star it https://github.com/omni-us/jsonargparse/ -->
10-
11-
## 📚 Documentation improvement
9+
<!--
10+
Thank you very much for contributing! If you enjoy this project, please consider
11+
giving it a ⭐ star on [GitHub](https://github.com/omni-us/jsonargparse/) or
12+
sponsor it via [GitHub Sponsors](https://github.com/sponsors/mauvilsa). Even the
13+
smallest donation is greatly appreciated and helps support the project.
14+
-->
1215

1316
<!--
14-
For simple improvements and typo fixes, please create a pull request without a
15-
linked issue. Otherwise, describe here your proposal.
17+
Note: For minor improvements or corrections, such as fixing typos, feel free to
18+
submit a pull request directly without opening a related issue.
1619
-->
20+
21+
## 📚 Documentation improvement
22+
23+
<!-- Here describe your proposal. -->

.github/ISSUE_TEMPLATE/4-enhancement.md

Lines changed: 12 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,11 +6,21 @@ labels: enhancement
66
assignees: ''
77
---
88

9-
<!-- If you like this project, please ⭐ star it https://github.com/omni-us/jsonargparse/ -->
9+
<!--
10+
Thank you very much for contributing! If you enjoy this project, please consider
11+
giving it a ⭐ star on [GitHub](https://github.com/omni-us/jsonargparse/) or
12+
sponsor it via [GitHub Sponsors](https://github.com/sponsors/mauvilsa). Even the
13+
smallest donation is greatly appreciated and helps support the project.
14+
-->
15+
16+
<!--
17+
Note: If your proposal is better explained through actual code changes, feel
18+
free to create a pull request directly instead of opening an issue.
19+
-->
1020

1121
## 🚀 Feature request
1222

13-
<!-- A clear and concise description of the feature proposal. -->
23+
<!-- Here write a clear and concise description of the feature proposal. -->
1424

1525
### Motivation
1626

.github/ISSUE_TEMPLATE/5-refactor.md

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,8 +6,13 @@ labels: refactor
66
assignees: ''
77
---
88

9-
<!-- If you like this project, please ⭐ star it https://github.com/omni-us/jsonargparse/ -->
9+
<!--
10+
Thank you very much for contributing! If you enjoy this project, please consider
11+
giving it a ⭐ star on [GitHub](https://github.com/omni-us/jsonargparse/) or
12+
sponsor it via [GitHub Sponsors](https://github.com/sponsors/mauvilsa). Even the
13+
smallest donation is greatly appreciated and helps support the project.
14+
-->
1015

1116
## 🔧 Code refactor
1217

13-
<!-- A clear and concise description of the code refactor. -->
18+
<!-- Here write a clear and concise description of the proposed code refactor. -->

.github/ISSUE_TEMPLATE/6-other.md

Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,4 +6,11 @@ labels: ''
66
assignees: ''
77
---
88

9-
<!-- If you like this project, please ⭐ star it https://github.com/omni-us/jsonargparse/ -->
9+
<!--
10+
Thank you very much for contributing! If you enjoy this project, please consider
11+
giving it a ⭐ star on [GitHub](https://github.com/omni-us/jsonargparse/) or
12+
sponsor it via [GitHub Sponsors](https://github.com/sponsors/mauvilsa). Even the
13+
smallest donation is greatly appreciated and helps support the project.
14+
-->
15+
16+
<!-- Here describe your issue. -->

.github/PULL_REQUEST_TEMPLATE.md

Lines changed: 14 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,13 +1,23 @@
11
<!--
2-
Thank you very much for contributing! If you like this project, please ⭐ star it
3-
https://github.com/omni-us/jsonargparse/
2+
Thank you very much for contributing! If you enjoy this project, please consider
3+
giving it a ⭐ star on [GitHub](https://github.com/omni-us/jsonargparse/) or
4+
sponsor it via [GitHub Sponsors](https://github.com/sponsors/mauvilsa). Even the
5+
smallest donation is greatly appreciated and helps support the project.
6+
-->
7+
8+
<!--
9+
Note: it is fine to create a pull request without the need to have a
10+
corresponding issue. In fact, if the issue would describe essentially the same
11+
as the pull request, please don't create an issue to avoid duplication.
412
-->
513

614
## What does this PR do?
715

816
<!--
917
Concisely describe what this pull request does. If available, include links to
10-
issues web pages where the need for this change has been motivated.
18+
issues web pages where the need for this change has been motivated. If you
19+
opted for creating a pull request without an issue, still have a look at the
20+
issue templates to include more information depending on the type.
1121
-->
1222

1323
## Before submitting
@@ -23,4 +33,4 @@ task is not relevant or leave empty when in doubt.
2333
- [ ] Did you write **unit tests** such that there is 100% coverage on related code? (required for bug fixes and new features)
2434
- [ ] Did you verify that new and existing **tests pass locally**?
2535
- [ ] Did you make sure that all changes preserve **backward compatibility**?
26-
- [ ] Did you update **the CHANGELOG** with the pull request link? (not for typos, docs, test updates, or minor internal changes/refactors)
36+
- [ ] Did you update **the CHANGELOG** including a pull request link? (not for typos, docs, test updates, or minor internal changes/refactors)

CONTRIBUTING.rst

Lines changed: 27 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,15 @@ people to help and contribute, among them:
1717
- Create `pull requests <https://github.com/omni-us/jsonargparse/pulls>`__ with
1818
documentation improvements, bug fixes or new features.
1919

20+
.. note::
21+
22+
While creating an issue before submitting a pull request is not mandatory,
23+
it might be helpful. Issues allow for discussion and feedback before
24+
significant development effort is invested. However, in some cases, code
25+
changes can better illustrate a proposal, making it more effective to submit
26+
a pull request directly. In such cases please avoid opening a largely
27+
redundant issue.
28+
2029
Development environment
2130
-----------------------
2231

@@ -49,24 +58,27 @@ The crucial step is installing the requirements which would be done by running:
4958
pre-commit
5059
----------
5160

52-
Please also install the `pre-commit <https://pre-commit.com/>`__ git hook
53-
scripts so that unit tests and code checks are automatically run locally. This
54-
is done as follows:
61+
Please also install the `pre-commit <https://pre-commit.com/>`__ git hooks so
62+
that unit tests and code checks are automatically run locally. This is done as
63+
follows:
5564

5665
.. code-block:: bash
5766
5867
pre-commit install
5968
6069
.. note::
6170

62-
``.pre-commit-config.yaml`` is configured to run the hooks using python
63-
3.12. Thus, you need to have python 3.12 installed for pre-commit to work.
71+
``.pre-commit-config.yaml`` is configured to run the hooks using Python
72+
3.12. Ensure you have Python 3.12 installed and available in your
73+
environment for ``pre-commit`` to function correctly. For development, other
74+
Python versions will work, but for convenience, Python 3.12 can also be
75+
used.
6476

65-
The ``pre-push`` stage runs several hooks (tests, doctests, mypy, coverage) that
66-
take some time. These hooks are intended to inform developers of issues that
67-
must be resolved before any pull request can be considered for merging. If you
68-
wish to push without running these hooks, use the command ``git push
69-
--no-verify``.
77+
The ``pre-push`` stage runs several hooks, including tests, doctests, mypy, and
78+
coverage. These hooks are designed to inform developers of issues that must be
79+
resolved before a pull request can be merged. Note that these hooks may take
80+
some time to complete. If you wish to push without running these hooks, use the
81+
command ``git push --no-verify``.
7082

7183
Formatting of the code is done automatically by pre-commit. If some pre-commit
7284
hooks fail and you decide to skip them, the formatting will be automatically
@@ -87,7 +99,7 @@ browser.
8799
Tests
88100
-----
89101

90-
Running the unit tests can be done either using using `pytest
102+
Running the unit tests can be done either using `pytest
91103
<https://docs.pytest.org/>`__ or `tox
92104
<https://tox.readthedocs.io/en/stable/>`__. The tests are also installed with
93105
the package, thus can be run in a production system. Also pre-commit runs some
@@ -150,9 +162,10 @@ example:
150162
^^^^^
151163
-
152164
153-
If no such section exists, just add it. Have a look at previous releases to
154-
decide under which subsection the new entry should go. If you are unsure, ask in
155-
the pull request.
165+
If no such section exists, just add it. New sections should include ``-??`` in
166+
the date to illustrate that the release date is not known yet. Have a look at
167+
previous releases to decide under which subsection the new entry should go. If
168+
you are unsure, ask in the pull request.
156169

157170
Please don't open pull requests with breaking changes unless this has been
158171
discussed and agreed upon in an issue.

0 commit comments

Comments
 (0)