@@ -17,6 +17,15 @@ people to help and contribute, among them:
1717- Create `pull requests <https://github.com/omni-us/jsonargparse/pulls >`__ with
1818 documentation improvements, bug fixes or new features.
1919
20+ .. note ::
21+
22+ While creating an issue before submitting a pull request is not mandatory,
23+ it might be helpful. Issues allow for discussion and feedback before
24+ significant development effort is invested. However, in some cases, code
25+ changes can better illustrate a proposal, making it more effective to submit
26+ a pull request directly. In such cases please avoid opening a largely
27+ redundant issue.
28+
2029Development environment
2130-----------------------
2231
@@ -49,24 +58,27 @@ The crucial step is installing the requirements which would be done by running:
4958 pre-commit
5059----------
5160
52- Please also install the `pre-commit <https://pre-commit.com/ >`__ git hook
53- scripts so that unit tests and code checks are automatically run locally. This
54- is done as follows:
61+ Please also install the `pre-commit <https://pre-commit.com/ >`__ git hooks so
62+ that unit tests and code checks are automatically run locally. This is done as
63+ follows:
5564
5665.. code-block :: bash
5766
5867 pre-commit install
5968
6069 .. note ::
6170
62- ``.pre-commit-config.yaml `` is configured to run the hooks using python
63- 3.12. Thus, you need to have python 3.12 installed for pre-commit to work.
71+ ``.pre-commit-config.yaml `` is configured to run the hooks using Python
72+ 3.12. Ensure you have Python 3.12 installed and available in your
73+ environment for ``pre-commit `` to function correctly. For development, other
74+ Python versions will work, but for convenience, Python 3.12 can also be
75+ used.
6476
65- The ``pre-push `` stage runs several hooks ( tests, doctests, mypy, coverage) that
66- take some time . These hooks are intended to inform developers of issues that
67- must be resolved before any pull request can be considered for merging. If you
68- wish to push without running these hooks, use the command `` git push
69- --no-verify ``.
77+ The ``pre-push `` stage runs several hooks, including tests, doctests, mypy, and
78+ coverage . These hooks are designed to inform developers of issues that must be
79+ resolved before a pull request can be merged. Note that these hooks may take
80+ some time to complete. If you wish to push without running these hooks, use the
81+ command `` git push --no-verify ``.
7082
7183Formatting of the code is done automatically by pre-commit. If some pre-commit
7284hooks fail and you decide to skip them, the formatting will be automatically
@@ -87,7 +99,7 @@ browser.
8799Tests
88100-----
89101
90- Running the unit tests can be done either using using `pytest
102+ Running the unit tests can be done either using `pytest
91103<https://docs.pytest.org/> `__ or `tox
92104<https://tox.readthedocs.io/en/stable/> `__. The tests are also installed with
93105the package, thus can be run in a production system. Also pre-commit runs some
@@ -150,9 +162,10 @@ example:
150162 ^^^^^
151163 -
152164
153- If no such section exists, just add it. Have a look at previous releases to
154- decide under which subsection the new entry should go. If you are unsure, ask in
155- the pull request.
165+ If no such section exists, just add it. New sections should include ``-?? `` in
166+ the date to illustrate that the release date is not known yet. Have a look at
167+ previous releases to decide under which subsection the new entry should go. If
168+ you are unsure, ask in the pull request.
156169
157170Please don't open pull requests with breaking changes unless this has been
158171discussed and agreed upon in an issue.
0 commit comments