From 04c609c70b3c20a585272fea2ea704f7a8d8bda8 Mon Sep 17 00:00:00 2001 From: Tom Tan Date: Thu, 22 May 2025 19:59:19 -0700 Subject: [PATCH 1/2] [BUILD] Propagate INTERFACE_COMPILE_DEFINITIONS from API through common_foo_library --- CHANGELOG.md | 3 +++ examples/common/foo_library/CMakeLists.txt | 2 +- examples/common/logs_foo_library/CMakeLists.txt | 2 +- examples/common/metrics_foo_library/CMakeLists.txt | 2 +- 4 files changed, 6 insertions(+), 3 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index a6f91d0b50..0c16bd077a 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -15,6 +15,9 @@ Increment the: ## [Unreleased] +* [BUILD] Propagate INTERFACE_COMPILE_DEFINITIONS from API through common_foo_library + [#3450](https://github.com/open-telemetry/opentelemetry-cpp/pull/3450) + * [Metrics SDK] Use nostd::function_ref in AttributesHashMap [#3393](https://github.com/open-telemetry/opentelemetry-cpp/pull/3393) diff --git a/examples/common/foo_library/CMakeLists.txt b/examples/common/foo_library/CMakeLists.txt index 7306c3a5af..58cb179f81 100644 --- a/examples/common/foo_library/CMakeLists.txt +++ b/examples/common/foo_library/CMakeLists.txt @@ -12,4 +12,4 @@ endif() target_include_directories(common_foo_library PUBLIC "$") -target_link_libraries(common_foo_library PRIVATE opentelemetry-cpp::api) +target_link_libraries(common_foo_library PUBLIC opentelemetry-cpp::api) diff --git a/examples/common/logs_foo_library/CMakeLists.txt b/examples/common/logs_foo_library/CMakeLists.txt index 5d66099e8a..af6207ca96 100644 --- a/examples/common/logs_foo_library/CMakeLists.txt +++ b/examples/common/logs_foo_library/CMakeLists.txt @@ -13,4 +13,4 @@ endif() target_include_directories(common_logs_foo_library PUBLIC $) -target_link_libraries(common_logs_foo_library PRIVATE opentelemetry-cpp::api) +target_link_libraries(common_logs_foo_library PUBLIC opentelemetry-cpp::api) diff --git a/examples/common/metrics_foo_library/CMakeLists.txt b/examples/common/metrics_foo_library/CMakeLists.txt index 1c9e388966..64a4b53aca 100644 --- a/examples/common/metrics_foo_library/CMakeLists.txt +++ b/examples/common/metrics_foo_library/CMakeLists.txt @@ -13,4 +13,4 @@ endif() target_include_directories(common_metrics_foo_library PUBLIC $) -target_link_libraries(common_metrics_foo_library PRIVATE opentelemetry-cpp::api) +target_link_libraries(common_metrics_foo_library PUBLIC opentelemetry-cpp::api) From 49251092accad11b2c63c4a48da8f31875693e5f Mon Sep 17 00:00:00 2001 From: Tom Tan Date: Thu, 22 May 2025 21:13:55 -0700 Subject: [PATCH 2/2] Update PR number --- CHANGELOG.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 0c16bd077a..3793f7666c 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -16,7 +16,7 @@ Increment the: ## [Unreleased] * [BUILD] Propagate INTERFACE_COMPILE_DEFINITIONS from API through common_foo_library - [#3450](https://github.com/open-telemetry/opentelemetry-cpp/pull/3450) + [#3440](https://github.com/open-telemetry/opentelemetry-cpp/pull/3440) * [Metrics SDK] Use nostd::function_ref in AttributesHashMap [#3393](https://github.com/open-telemetry/opentelemetry-cpp/pull/3393)