Skip to content

Commit a988380

Browse files
authored
Add declarative config support for view unit (#7942)
1 parent 3cd680c commit a988380

File tree

2 files changed

+5
-0
lines changed

2 files changed

+5
-0
lines changed

sdk-extensions/incubator/src/main/java/io/opentelemetry/sdk/extension/incubator/fileconfig/InstrumentSelectorFactory.java

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -37,6 +37,9 @@ public InstrumentSelector create(ViewSelectorModel model, DeclarativeConfigConte
3737
}
3838
builder.setType(instrumentType);
3939
}
40+
if (model.getUnit() != null) {
41+
builder.setUnit(model.getUnit());
42+
}
4043
if (model.getMeterName() != null) {
4144
builder.setMeterName(model.getMeterName());
4245
}

sdk-extensions/incubator/src/test/java/io/opentelemetry/sdk/extension/incubator/fileconfig/InstrumentSelectorFactoryTest.java

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -35,6 +35,7 @@ void create() {
3535
new ViewSelectorModel()
3636
.withInstrumentName("instrument-name")
3737
.withInstrumentType(ViewSelectorModel.InstrumentType.COUNTER)
38+
.withUnit("ms")
3839
.withMeterName("meter-name")
3940
.withMeterSchemaUrl("https://opentelemetry.io/schemas/1.16.0")
4041
.withMeterVersion("1.0.0"),
@@ -43,6 +44,7 @@ void create() {
4344
InstrumentSelector.builder()
4445
.setName("instrument-name")
4546
.setType(InstrumentType.COUNTER)
47+
.setUnit("ms")
4648
.setMeterName("meter-name")
4749
.setMeterSchemaUrl("https://opentelemetry.io/schemas/1.16.0")
4850
.setMeterVersion("1.0.0")

0 commit comments

Comments
 (0)