From 23ecd1c9afb8f9c83a8b65856cb909dd403c6c28 Mon Sep 17 00:00:00 2001 From: Sylvain Juge <763082+SylvainJuge@users.noreply.github.com> Date: Fri, 19 Dec 2025 17:27:18 +0100 Subject: [PATCH] fix minor inconsistency in sampler test --- .../trace/samplers/ComposableRuleBasedSamplerTest.java | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/sdk-extensions/incubator/src/test/java/io/opentelemetry/sdk/extension/incubator/trace/samplers/ComposableRuleBasedSamplerTest.java b/sdk-extensions/incubator/src/test/java/io/opentelemetry/sdk/extension/incubator/trace/samplers/ComposableRuleBasedSamplerTest.java index 39c1a0b26e1..af6c7d1f84d 100644 --- a/sdk-extensions/incubator/src/test/java/io/opentelemetry/sdk/extension/incubator/trace/samplers/ComposableRuleBasedSamplerTest.java +++ b/sdk-extensions/incubator/src/test/java/io/opentelemetry/sdk/extension/incubator/trace/samplers/ComposableRuleBasedSamplerTest.java @@ -31,10 +31,12 @@ class ComposableRuleBasedSamplerTest { private static final class AttributePredicate implements SamplingPredicate { private final AttributeKey key; + private final T value; private final String description; private AttributePredicate(AttributeKey key, T value) { this.key = key; + this.value = value; this.description = key.getKey() + "=" + value; } @@ -46,7 +48,7 @@ public boolean matches( SpanKind spanKind, Attributes attributes, List parentLinks) { - return "/health".equals(attributes.get(key)); + return value.equals(attributes.get(key)); } @Override @@ -116,7 +118,7 @@ void rules() { Sampler sampler = CompositeSampler.wrap( ComposableSampler.ruleBasedBuilder() - .add(new AttributePredicate<>(HTTP_ROUTE, "/health"), ComposableSampler.alwaysOff()) + .add(new AttributePredicate<>(HTTP_ROUTE, "/check"), ComposableSampler.alwaysOff()) .add(IsRootPredicate.INSTANCE, ComposableSampler.alwaysOn()) .build()); @@ -128,7 +130,7 @@ void rules() { TraceId.fromLongs(1, 2), SpanId.fromLong(3), SpanKind.SERVER, - Attributes.of(HTTP_ROUTE, "/health"), + Attributes.of(HTTP_ROUTE, "/check"), Collections.emptyList()) .getDecision()) .isEqualTo(SamplingDecision.DROP);