Continue processing async instruments if callback fails (#2614)

lzchen · web-flow · commit dd56e7f0b364 · 2022-04-19T22:16:46.000+05:30
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -7,6 +7,8 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ## [Unreleased](https://github.com/open-telemetry/opentelemetry-python/compare/v1.11.0-0.30b0...HEAD)
 
+- Fix unhandled callback exceptions on async instruments
+  ([#2614](https://github.com/open-telemetry/opentelemetry-python/pull/2614))
 - Rename `DefaultCounter`, `DefaultHistogram`, `DefaultObservableCounter`,
   `DefaultObservableGauge`, `DefaultObservableUpDownCounter`, `DefaultUpDownCounter`
   instruments to `NoOpCounter`, `NoOpHistogram`, `NoOpObservableCounter`,
diff --git a/opentelemetry-sdk/src/opentelemetry/sdk/_metrics/instrument.py b/opentelemetry-sdk/src/opentelemetry/sdk/_metrics/instrument.py
@@ -97,6 +97,10 @@ def callback(self) -> Iterable[Measurement]:
                     )
             except StopIteration:
                 pass
+            except Exception:  # pylint: disable=broad-except
+                _logger.exception(
+                    "Callback failed for instrument %s.", self.name
+                )
 
 
 class Counter(_Synchronous, APICounter):

Original file line number	Diff line number	Diff line change
`@@ -97,6 +97,10 @@ def callback(self) -> Iterable[Measurement]:`
`97`	`97`	`)`
`98`	`98`	`except StopIteration:`
`99`	`99`	`pass`
	`100`	`+ except Exception: # pylint: disable=broad-except`
	`101`	`+ _logger.exception(`
	`102`	`+ "Callback failed for instrument %s.", self.name`
	`103`	`+ )`
`100`	`104`
`101`	`105`
`102`	`106`	`class Counter(_Synchronous, APICounter):`