Some OnePlus devices freeze on trying to boot TWRP

[MagicLike]

Continuation of #246 (comment)

Describe the bug
It seems like it freezes every time after giving the command to boot something, as fastboot does not respond to any commands anymore. The OAI log does not show any interesting or relevant information regarding the error - just the normal log...

2023-09-15 18:51:08.329 | INFO     | tooling:logging:88 - Boot custom recovery with fastboot. - Parameters: {'recovery': '/*/twrp-3.6.2_9-0-bacon.img', 'is_ab': False, 'bin_path': PosixPath('/*/openandroidinstaller/openandroidinstaller/bin')}
2023-09-15 18:51:08.329 | INFO     | tooling:fastboot_boot_recovery:414 - Boot custom recovery with fastboot.
2023-09-15 18:51:08.329 | INFO     | tooling:run_command:60 - Run command: ['/*/openandroidinstaller/openandroidinstaller/bin/fastboot', 'boot', '/*/twrp-3.6.2_9-0-bacon.img']
2023-09-15 18:51:09.099 | INFO     | tooling:run_command:73 - Sending 'boot.img' (15256 KB)                      OKAY [  0.480s]
2023-09-15 18:51:09.126 | INFO     | tooling:run_command:73 - Booting                                            OKAY [  0.026s]
2023-09-15 18:51:09.127 | INFO     | tooling:run_command:73 - Finished. Total time: 0.535s
2023-09-15 18:51:09.128 | INFO     | tooling:logging:88 - Wait for recovery - Parameters: {'bin_path': PosixPath('/*/openandroidinstaller/openandroidinstaller/bin')}
2023-09-15 18:51:09.128 | INFO     | tooling:run_command:60 - Run command: ['/*/openandroidinstaller/openandroidinstaller/bin/adb', 'wait-for-recovery']

To Reproduce
Steps to reproduce the behavior:

1. Boot into fastboot
2. fastboot boot ./*.img

Desktop (please complete the following information):

• OS: Ubuntu
• Version 23.04

Smartphone (please complete the following information):

• Device: OnePlus One
• OS: Stock -> Lineage OS for microG

Additional context
The issue occurs on 0.4.4 and the current beta branches. Interestingly it only happened after I flashed the stock firmware again. Maybe it is in some kind of soft-brick state...

[freechelmi]

I reproduced this exactly on OnePlus8T on 0.5.2-dev , OAI is stuck at Recovery step.

No problem on OnePlus5T but I guess you don't Boot TWRP but flash it directly ?

Did I understood that you boot TWRP only on device that need additional partitions ?

[freechelmi]

I've tested by flashing first the vbmeta and dtbo image but booting the TWRP image is still impossible

[freechelmi]

I've started a discussion here

#377

@tsterbak may help

[tsterbak]

Wait a minute, OnePlus8T is not supported yet, right? 🤔 😅

[freechelmi]

Yes I was about to add it :-)

[tsterbak]

Ah great!
If you want to try to flash twrp instead of boot it, setting is_ab_device to false in the config will do that. (be aware, that this is not a tested workflow, so there might things be going wrong... but I cannot see any other side effects now)